[11.4] Fix double encoding of query parameters in Repositories::compare (#682)

Author: GrahamCampbell

src/Api/Repositories.php

@@ -413,9 +413,9 @@ public function postCommitBuildStatus($project_id, string $sha, string $state, a
     public function compare($project_id, string $fromShaOrMaster, string $toShaOrMaster, bool $straight = false)
     {
         $params = [
-            'from' => self::encodePath($fromShaOrMaster),
-            'to' => self::encodePath($toShaOrMaster),
-            'straight' => self::encodePath($straight ? 'true' : 'false'),
+            'from' => $fromShaOrMaster,
+            'to' => $toShaOrMaster,
+            'straight' => $straight ? 'true' : 'false',
         ];
 
         return $this->get($this->getProjectPath($project_id, 'repository/compare'), $params);

tests/Api/RepositoriesTest.php

@@ -541,6 +541,23 @@ public function shouldNotCompareStraight(): void
         $this->assertEquals($expectedArray, $api->compare(1, 'master', 'feature'));
     }
 
+    /**
+     * @test
+     */
+    public function shouldCompareComplexBranchName(): void
+    {
+        $expectedArray = ['commit' => 'object'];
+
+        $api = $this->getApiMock();
+        $api->expects($this->once())
+            ->method('get')
+            ->with('projects/1/repository/compare', ['from' => 'master', 'to' => 'feature/760.fake-branch', 'straight' => 'true'])
+            ->will($this->returnValue($expectedArray))
+        ;
+
+        $this->assertEquals($expectedArray, $api->compare(1, 'master', 'feature/760.fake-branch', true));
+    }
+
     /**
      * @test
      */