From cba97c227334a6a8e3ca0fdc18f90fde1f0e41ee Mon Sep 17 00:00:00 2001 From: Gabor Demeter Date: Thu, 20 Aug 2026 19:16:32 +0200 Subject: [PATCH] fix(gcp-secret-get): set export_to_environment: true google-github-actions/get-secretmanager-secrets@v3 defaults this to false -- without it, $SECRET_JSON is empty in the next step even after a successful fetch, so the JSON-parse guard fires with "Secret ... is empty or not valid JSON" even though the fetch genuinely worked. Caught by the first real end-to-end run of sf-org-login's gcp branch against the live salesforce-devhub secret. --- .github/actions/gcp-secret-get/action.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/actions/gcp-secret-get/action.yml b/.github/actions/gcp-secret-get/action.yml index 4a9e6e6..4e386c8 100644 --- a/.github/actions/gcp-secret-get/action.yml +++ b/.github/actions/gcp-secret-get/action.yml @@ -41,6 +41,7 @@ runs: - name: Fetch secret from Secret Manager uses: google-github-actions/get-secretmanager-secrets@v3 with: + export_to_environment: true # default is false — without this, $SECRET_JSON is empty in the next step secrets: |- SECRET_JSON:${{ inputs.gcp-project-id }}/${{ inputs.gcp-secret-name }}