Tests

Author: robotdan

src/main/java/io/fusionauth/http/server/HTTPServerConfiguration.java

@@ -206,8 +206,8 @@ public int getMaxPendingSocketConnections() {
    * The map that specifies the maximum size in bytes of the HTTP request body by Content-Type. This configuration excludes the size of the
    * HTTP request header.
    * <p>
-   * The returned map is keyed by Content-Type, and willy contain a default value identified by '*', and may optionally return content type
-   * values with a wild card '*' as the subtype.
+   * The returned map is keyed by Content-Type, and will contain a default value identified by '*', and may optionally contain a content
+   * type value with a wild card '*' as the subtype. For example, 'application/*' will match all subtypes of an application/ content type.
    *
    * @return the map keyed by Content-Type indicating the maximum size in bytes of the HTTP request body.  Defaults to 128 Megabytes as a
    *     default, and 10 Megabytes for application/x-www-form-urlencoded.

src/test/java/io/fusionauth/http/util/HTTPToolsTest.java

@@ -63,6 +63,17 @@ public void getMaxRequestBodySize() {
     assertMaxConfiguredSize("multipart/form-data", 5, configuration);
     assertMaxConfiguredSize("text/css", 6, configuration);
     assertMaxConfiguredSize("text/html", 7, configuration);
+
+    // We don't expect this at runtime, but ideally we won't explode. These would be invalid values.
+    // - Some of these are legit Content-Type headers, but at runtime we will have already parsed the header so we do
+    //   not expect any attributes;
+    assertMaxConfiguredSize("", 1, configuration);
+    assertMaxConfiguredSize("null", 1, configuration);
+    assertMaxConfiguredSize("application/json; foo=bar", 2, configuration);
+    assertMaxConfiguredSize("multipart/form-data; boundary=------", 1, configuration);
+    assertMaxConfiguredSize("text/css; charset=ISO-8859-1", 6, configuration);
+    assertMaxConfiguredSize("text/unexpected", 6, configuration);
+    assertMaxConfiguredSize("text/unexpected/value", 6, configuration);
   }
 
   @Test
@@ -264,7 +275,7 @@ private void assertHexValue(String s, String expected, Charset charset) {
   }
 
   private void assertMaxConfiguredSize(String contentType, int maximumSize, Map<String, Integer> maxRequestBodySize) {
-    assertEquals(maximumSize, HTTPTools.getMaxRequestBodySize(contentType, maxRequestBodySize));
+    assertEquals(HTTPTools.getMaxRequestBodySize(contentType, maxRequestBodySize), maximumSize);
   }
 
   private String hex(byte[] bytes) {