From a6a34bde13efa0ef54d7770c1a5809b613d40c69 Mon Sep 17 00:00:00 2001 From: Pwongchaiya Date: Tue, 17 Mar 2026 15:38:14 -0700 Subject: [PATCH 1/2] added validation for incoming enviornment cannot be null --- api/features/serializers.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/api/features/serializers.py b/api/features/serializers.py index c27ee5aa78e5..703314f6b2dd 100644 --- a/api/features/serializers.py +++ b/api/features/serializers.py @@ -588,7 +588,7 @@ def save(self, **kwargs): # type: ignore[no-untyped-def] except django.core.exceptions.ValidationError as e: raise serializers.ValidationError(str(e)) - + def validate_feature(self, feature): # type: ignore[no-untyped-def] if self.instance and self.instance.feature_id != feature.id: # type: ignore[union-attr] raise serializers.ValidationError( @@ -597,6 +597,11 @@ def validate_feature(self, feature): # type: ignore[no-untyped-def] return feature def validate_environment(self, environment): # type: ignore[no-untyped-def] + if environment is None: + raise serializers.ValidationError( + "Environment cannot be null" + ) + if self.instance and self.instance.environment_id != environment.id: # type: ignore[union-attr] raise serializers.ValidationError( "Cannot change the environment of a feature state" From 01607d62630091b79f33b5b33e802527f1367261 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Wed, 1 Apr 2026 22:21:17 +0000 Subject: [PATCH 2/2] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- api/features/serializers.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/api/features/serializers.py b/api/features/serializers.py index 703314f6b2dd..1345a337985d 100644 --- a/api/features/serializers.py +++ b/api/features/serializers.py @@ -588,7 +588,7 @@ def save(self, **kwargs): # type: ignore[no-untyped-def] except django.core.exceptions.ValidationError as e: raise serializers.ValidationError(str(e)) - + def validate_feature(self, feature): # type: ignore[no-untyped-def] if self.instance and self.instance.feature_id != feature.id: # type: ignore[union-attr] raise serializers.ValidationError( @@ -598,9 +598,7 @@ def validate_feature(self, feature): # type: ignore[no-untyped-def] def validate_environment(self, environment): # type: ignore[no-untyped-def] if environment is None: - raise serializers.ValidationError( - "Environment cannot be null" - ) + raise serializers.ValidationError("Environment cannot be null") if self.instance and self.instance.environment_id != environment.id: # type: ignore[union-attr] raise serializers.ValidationError(