ci: replace Docker with PSFirebird for unified Windows/Linux testing

Author: fdcastel

.github/workflows/ci.yml

@@ -7,111 +7,97 @@ on:
 
 jobs:
   test:
-    runs-on: ubuntu-latest
+    runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
       matrix:
         firebird-version: [3, 4, 5]
+        os: [ubuntu-22.04, windows-latest]
         include:
           - firebird-version: 3
             db-file: fbtest30.fdb
-            docker-image: firebirdsql/firebird:3
+            fb-semver: '3.0.13'
           - firebird-version: 4
             db-file: fbtest40.fdb
-            docker-image: firebirdsql/firebird:4
+            fb-semver: '4.0.6'
           - firebird-version: 5
             db-file: fbtest50.fdb
-            docker-image: firebirdsql/firebird:5
-    
+            fb-semver: '5.0.3'
+
+    defaults:
+      run:
+        shell: pwsh
+
+    env:
+      GITHUB_TOKEN: ${{ github.token }}
+
     steps:
     - uses: actions/checkout@v4
-    
+
     - name: Set up Python
       uses: actions/setup-python@v5
       with:
         python-version: '3.11'
-    
+
     - name: Install Hatch
       run: pip install hatch
-    
-    - name: Start Firebird Docker container
+
+    - name: Install PSFirebird
       run: |
-        # Create a tmp directory that will be bind-mounted to the container
-        # This ensures test files are accessible at the same paths inside and outside the container
-        mkdir -p /tmp/firebird-test
-        
-        # Start Firebird container with /tmp bind-mounted
-        # Configure RemoteAuxPort for Firebird events support
-        docker run -d \
-          --name firebird \
-          -e FIREBIRD_ROOT_PASSWORD=masterkey \
-          -e ISC_PASSWORD=masterkey \
-          -e FIREBIRD_CONF_RemoteAuxPort=3051 \
-          -p 3050:3050 \
-          -p 3051:3051 \
-          -v /tmp:/tmp:rw \
-          ${{ matrix.docker-image }}
-    
-    - name: Wait for Firebird to be ready
+        Set-PSRepository -Name PSGallery -InstallationPolicy Trusted
+        Install-PackageProvider -Name NuGet -MinimumVersion 2.8.5.201 -Force -Scope CurrentUser -ForceBootstrap -ErrorAction Continue
+        Install-Module -Name PSFirebird -Force -AllowClobber -Scope CurrentUser -Repository PSGallery
+
+    - name: Create Firebird environment
       run: |
-        echo "Waiting for Firebird to be fully ready..."
-        for i in {1..30}; do
-          if docker exec firebird /bin/bash -c "echo 'SELECT 1 FROM RDB\$DATABASE;' | /opt/firebird/bin/isql -u SYSDBA -p masterkey employee" &>/dev/null 2>&1; then
-            echo "Firebird is ready!"
-            exit 0
-          fi
-          echo "Waiting... ($i/30)"
-          sleep 2
-        done
-        echo "Firebird failed to start"
-        docker logs firebird
-        exit 1
-    
-    - name: Extract and install Firebird client library from container
+        $tempPath = if ($IsWindows) { $env:TEMP } else { '/tmp' }
+        $fbPath = Join-Path $tempPath 'firebird-${{ matrix.firebird-version }}'
+        New-FirebirdEnvironment -Version '${{ matrix.fb-semver }}' -Path $fbPath | Out-Null
+        Write-Output "FB_PATH=$fbPath" >> $env:GITHUB_ENV
+
+    - name: Configure and start Firebird
       run: |
-        # List available libraries in container for debugging
-        echo "Available libraries in container:"
-        docker exec firebird ls -la /opt/firebird/lib/ || docker exec firebird ls -la /usr/lib/
-        
-        # Find and extract client library from the running container
-        # Different versions may have different file names or locations
-        LIB_PATH=""
-        if docker exec firebird test -f /opt/firebird/lib/libfbclient.so.2; then
-          # Get the actual file path by resolving the symlink
-          LIB_PATH=$(docker exec firebird readlink -f /opt/firebird/lib/libfbclient.so.2)
-        elif docker exec firebird test -f /opt/firebird/lib/libfbclient.so; then
-          LIB_PATH=$(docker exec firebird readlink -f /opt/firebird/lib/libfbclient.so)
-        elif docker exec firebird test -f /usr/lib/libfbclient.so; then
-          LIB_PATH=$(docker exec firebird readlink -f /usr/lib/libfbclient.so)
-        elif docker exec firebird test -f /usr/lib/x86_64-linux-gnu/libfbclient.so.2; then
-          LIB_PATH=$(docker exec firebird readlink -f /usr/lib/x86_64-linux-gnu/libfbclient.so.2)
-        else
-          echo "Could not find libfbclient.so in container"
-          exit 1
-        fi
-        
-        echo "Copying library from: $LIB_PATH"
-        # Copy the actual library file (not the symlink)
-        docker cp firebird:$LIB_PATH ${{ github.workspace }}/libfbclient.so
-        
-        # Install to system
-        sudo cp ${{ github.workspace }}/libfbclient.so /usr/lib/x86_64-linux-gnu/
-        sudo ldconfig
-        
-        # Verify installation
-        ldconfig -p | grep libfbclient
-    
+        # Configure RemoteAuxPort for Firebird events support
+        $confPath = Join-Path $env:FB_PATH 'firebird.conf'
+        Write-FirebirdConfiguration -Path $confPath -Configuration @{ RemoteAuxPort = 3051 }
+        # Start Firebird server
+        Start-FirebirdInstance -Environment $env:FB_PATH | Out-Null
+        # Wait for the server to be ready
+        Write-Output "Waiting for Firebird to be ready..."
+        for ($i = 1; $i -le 30; $i++) {
+          try {
+            $tcp = [System.Net.Sockets.TcpClient]::new('localhost', 3050)
+            $tcp.Close()
+            Write-Output "Firebird is ready!"
+            break
+          } catch {
+            if ($i -eq 30) { Write-Error "Firebird failed to start"; exit 1 }
+            Write-Output "Waiting... ($i/30)"
+            Start-Sleep -Seconds 2
+          }
+        }
+
+    - name: Find Firebird client library
+      run: |
+        if ($IsWindows) {
+          $clientLib = Join-Path $env:FB_PATH 'fbclient.dll'
+        } else {
+          foreach ($name in @('lib/libfbclient.so.2', 'lib/libfbclient.so')) {
+            $p = Join-Path $env:FB_PATH $name
+            if (Test-Path $p) { $clientLib = $p; break }
+          }
+        }
+        Write-Output "Found client library: $clientLib"
+        Write-Output "FB_CLIENT_LIB=$clientLib" >> $env:GITHUB_ENV
+
     - name: Run tests
-      run: hatch test -- --host=localhost --port=3050 -v
+      run: hatch test -- --host=localhost --port=3050 "--client-lib=$env:FB_CLIENT_LIB" -v
       env:
         FIREBIRD_VERSION: ${{ matrix.firebird-version }}
-    
-    - name: Stop Firebird container
+
+    - name: Stop Firebird instance
       if: always()
-      run: |
-        docker logs firebird
-        docker stop firebird
-        docker rm firebird
+      run: Get-FirebirdInstance | Stop-FirebirdInstance
 
   build:
     needs: test