ci: upgrade to PSFirebird 1.2.2 -- fix SYSDBA init, use GetClientLibraryPath()

Author: fdcastel

.github/workflows/ci.yml

@@ -46,7 +46,7 @@ jobs:
       run: |
         Set-PSRepository -Name PSGallery -InstallationPolicy Trusted
         Install-PackageProvider -Name NuGet -MinimumVersion 2.8.5.201 -Force -Scope CurrentUser -ForceBootstrap -ErrorAction Continue
-        Install-Module -Name PSFirebird -Force -AllowClobber -Scope CurrentUser -Repository PSGallery
+        Install-Module -Name PSFirebird -MinimumVersion 1.2.2 -Force -AllowClobber -Scope CurrentUser -Repository PSGallery
 
     - name: Create Firebird environment
       run: |
@@ -55,45 +55,20 @@ jobs:
         $fbEnv = New-FirebirdEnvironment -Version '${{ matrix.fb-semver }}' -Path $fbPath
         Write-Output $fbEnv
         Write-Output "FB_PATH=$fbPath" >> $env:GITHUB_ENV
-        $global:LASTEXITCODE = 0
+        Write-Output "FB_CLIENT_LIB=$($fbEnv.GetClientLibraryPath())" >> $env:GITHUB_ENV
 
     - name: Configure and start Firebird
       run: |
+        # Initialize SYSDBA in security database via embedded connection (no server needed)
+        $tempDb = Join-Path $env:FB_PATH 'temp_init.fdb'
+        New-FirebirdDatabase -Database $tempDb -Environment $env:FB_PATH
+        "CREATE OR ALTER USER SYSDBA PASSWORD 'masterkey';" | Invoke-FirebirdIsql -Database $tempDb -Environment $env:FB_PATH
+        Remove-Item $tempDb -Force
         # Configure RemoteAuxPort for Firebird events support
         $confPath = Join-Path $env:FB_PATH 'firebird.conf'
         Write-FirebirdConfiguration -Path $confPath -Configuration @{ RemoteAuxPort = 3051 }
         # Start Firebird server
-        $instance = Start-FirebirdInstance -Environment $env:FB_PATH
-        Write-Output $instance
-        # Wait for the server to be ready
-        Write-Output "Waiting for Firebird to be ready..."
-        for ($i = 1; $i -le 30; $i++) {
-          try {
-            $tcp = [System.Net.Sockets.TcpClient]::new('localhost', 3050)
-            $tcp.Close()
-            Write-Output "Firebird is ready!"
-            break
-          } catch {
-            if ($i -eq 30) { Write-Error "Firebird failed to start"; exit 1 }
-            Write-Output "Waiting... ($i/30)"
-            Start-Sleep -Seconds 2
-          }
-        }
-        $global:LASTEXITCODE = 0
-
-    - name: Find Firebird client library
-      run: |
-        if ($IsWindows) {
-          $clientLib = Join-Path $env:FB_PATH 'fbclient.dll'
-        } else {
-          foreach ($name in @('lib/libfbclient.so.2', 'lib/libfbclient.so')) {
-            $p = Join-Path $env:FB_PATH $name
-            if (Test-Path $p) { $clientLib = $p; break }
-          }
-        }
-        Write-Output "Found client library: $clientLib"
-        Write-Output "FB_CLIENT_LIB=$clientLib" >> $env:GITHUB_ENV
-        $global:LASTEXITCODE = 0
+        Start-FirebirdInstance -Environment $env:FB_PATH | Write-Output
 
     - name: Run tests
       run: hatch test -- --host=localhost --port=3050 "--client-lib=$env:FB_CLIENT_LIB" -v
@@ -102,9 +77,7 @@ jobs:
 
     - name: Stop Firebird instance
       if: always()
-      run: |
-        Get-FirebirdInstance | Stop-FirebirdInstance
-        $global:LASTEXITCODE = 0
+      run: Get-FirebirdInstance | Stop-FirebirdInstance
 
   build:
     needs: test