Skip to content

Commit 44b7bb7

Browse files
committed
ci: create firebird.log before server start; fix test_connect_config on Windows
1 parent 7e16357 commit 44b7bb7

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,8 @@ jobs:
6868
$initDb = New-FirebirdDatabase -Database (Join-Path $env:FB_PATH 'init.fdb') -Environment $env:FB_PATH
6969
"CREATE USER SYSDBA PASSWORD 'masterkey';" | Invoke-FirebirdIsql -Database $initDb -Environment $env:FB_PATH
7070
Remove-FirebirdDatabase -Database $initDb -Force
71+
# Create empty firebird.log so get_log() service API calls succeed
72+
New-Item -ItemType File -Path (Join-Path $env:FB_PATH 'firebird.log') -Force | Out-Null
7173
# Start Firebird server
7274
Start-FirebirdInstance -Environment $env:FB_PATH | Write-Output
7375

tests/test_connection.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,6 @@ def test_connect_config(fb_vars, db_file, driver_cfg):
130130
[test_db1]
131131
server = server.local
132132
database = {db_file}
133-
utf8filename = true
134133
charset = UTF8
135134
sql_dialect = 3
136135
"""

0 commit comments

Comments
 (0)