Skip to content

Main thread blocking for full server join bypass permission check #6519

@Leymooo

Description

@Leymooo

Type of bug

Performance issue or memory leak

/ess dump all output

idc

Error log (if applicable)

No response

Bug description

Image

https://github.com/EssentialsX/Essentials/blob/2.x/Essentials/src/main/java/com/earth2me/essentials/perm/impl/LuckPermsHandler.java#L96

loadUser() always retvieves user from DataBase without any caching, you probaly want to use getUser() (get from cache if loaded) firstly and if null then loadUser(). At the context of PlayerServerFullCheckEvent, user should be always loaded.

Steps to reproduce

.

Expected behaviour

not blocking main thread

Actual behaviour

blocking main thread

Additional Information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug: unconfirmedPotential bugs that need replicating to verify.

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions