From 0d6be3ac3656f3177a8fd89649bf171c0c58f5cb Mon Sep 17 00:00:00 2001 From: daywalker90 Date: Thu, 8 Oct 2026 14:05:29 +0200 Subject: [PATCH] tests: wait for announcements in test_splice_rbf_htlc_sigs The splice changes the channel's short_channel_id. If the test does not wait for the channel to be announced first, a node can receive a node_announcement for a peer before the channel_announcement for the new scid. gossipd then logs "Bad gossip order: node_announcement: unknown node", and the teardown check fails the test even though its body passes. Wait for announcements before splicing, as the other splice tests do. Changelog-None --- tests/test_splicing.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_splicing.py b/tests/test_splicing.py index a2799247c5cc..c7eb16a46e1b 100644 --- a/tests/test_splicing.py +++ b/tests/test_splicing.py @@ -293,7 +293,7 @@ def test_splice_rbf_htlc_sigs(node_factory, bitcoind, executor): """Once a splice-RBF candidate confirms, only its HTLC signatures become the active set, even when the other candidates place the funding output at the same index.""" - l1, l2 = node_factory.line_graph(2, fundamount=1000000) + l1, l2 = node_factory.line_graph(2, fundamount=1000000, wait_for_announce=True) chan_id = l1.get_channel_id(l2) def htlc_sig_rows(node):