Skip to content

Commit 55c0353

Browse files
committed
Use non-generic TaskCompletionSource where applicable
1 parent 2e5c620 commit 55c0353

File tree

3 files changed

+18
-18
lines changed

3 files changed

+18
-18
lines changed

src/ElectronNET.API/API/Dialog.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -206,10 +206,10 @@ public Task ShowCertificateTrustDialogAsync(CertificateTrustDialogOptions option
206206
[SupportedOSPlatform("Windows")]
207207
public Task ShowCertificateTrustDialogAsync(BrowserWindow browserWindow, CertificateTrustDialogOptions options)
208208
{
209-
var tcs = new TaskCompletionSource<object>();
209+
var tcs = new TaskCompletionSource();
210210
string guid = Guid.NewGuid().ToString();
211211

212-
BridgeConnector.Socket.Once("showCertificateTrustDialogComplete" + guid, () => tcs.SetResult(null));
212+
BridgeConnector.Socket.Once("showCertificateTrustDialogComplete" + guid, () => tcs.SetResult());
213213
BridgeConnector.Socket.Emit("showCertificateTrustDialog",
214214
browserWindow,
215215
options,

src/ElectronNET.API/API/Session.cs

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,10 @@ public void AllowNTLMCredentialsForDomains(string domains)
4747
/// <returns></returns>
4848
public Task ClearAuthCacheAsync(RemovePassword options)
4949
{
50-
var tcs = new TaskCompletionSource<object>();
50+
var tcs = new TaskCompletionSource();
5151
string guid = Guid.NewGuid().ToString();
5252

53-
BridgeConnector.Socket.Once("webContents-session-clearAuthCache-completed" + guid, () => tcs.SetResult(null));
53+
BridgeConnector.Socket.Once("webContents-session-clearAuthCache-completed" + guid, () => tcs.SetResult());
5454
BridgeConnector.Socket.Emit("webContents-session-clearAuthCache", Id, options, guid);
5555

5656
return tcs.Task;
@@ -61,10 +61,10 @@ public Task ClearAuthCacheAsync(RemovePassword options)
6161
/// </summary>
6262
public Task ClearAuthCacheAsync()
6363
{
64-
var tcs = new TaskCompletionSource<object>();
64+
var tcs = new TaskCompletionSource();
6565
string guid = Guid.NewGuid().ToString();
6666

67-
BridgeConnector.Socket.Once("webContents-session-clearAuthCache-completed" + guid, () => tcs.SetResult(null));
67+
BridgeConnector.Socket.Once("webContents-session-clearAuthCache-completed" + guid, () => tcs.SetResult());
6868
BridgeConnector.Socket.Emit("webContents-session-clearAuthCache", Id, guid);
6969

7070
return tcs.Task;
@@ -76,10 +76,10 @@ public Task ClearAuthCacheAsync()
7676
/// <returns></returns>
7777
public Task ClearCacheAsync()
7878
{
79-
var tcs = new TaskCompletionSource<object>();
79+
var tcs = new TaskCompletionSource();
8080
string guid = Guid.NewGuid().ToString();
8181

82-
BridgeConnector.Socket.Once("webContents-session-clearCache-completed" + guid, () => tcs.SetResult(null));
82+
BridgeConnector.Socket.Once("webContents-session-clearCache-completed" + guid, () => tcs.SetResult());
8383
BridgeConnector.Socket.Emit("webContents-session-clearCache", Id, guid);
8484

8585
return tcs.Task;
@@ -91,10 +91,10 @@ public Task ClearCacheAsync()
9191
/// <returns></returns>
9292
public Task ClearHostResolverCacheAsync()
9393
{
94-
var tcs = new TaskCompletionSource<object>();
94+
var tcs = new TaskCompletionSource();
9595
string guid = Guid.NewGuid().ToString();
9696

97-
BridgeConnector.Socket.Once("webContents-session-clearHostResolverCache-completed" + guid, () => tcs.SetResult(null));
97+
BridgeConnector.Socket.Once("webContents-session-clearHostResolverCache-completed" + guid, () => tcs.SetResult());
9898
BridgeConnector.Socket.Emit("webContents-session-clearHostResolverCache", Id, guid);
9999

100100
return tcs.Task;
@@ -106,10 +106,10 @@ public Task ClearHostResolverCacheAsync()
106106
/// <returns></returns>
107107
public Task ClearStorageDataAsync()
108108
{
109-
var tcs = new TaskCompletionSource<object>();
109+
var tcs = new TaskCompletionSource();
110110
string guid = Guid.NewGuid().ToString();
111111

112-
BridgeConnector.Socket.Once("webContents-session-clearStorageData-completed" + guid, () => tcs.SetResult(null));
112+
BridgeConnector.Socket.Once("webContents-session-clearStorageData-completed" + guid, () => tcs.SetResult());
113113
BridgeConnector.Socket.Emit("webContents-session-clearStorageData", Id, guid);
114114

115115
return tcs.Task;
@@ -122,10 +122,10 @@ public Task ClearStorageDataAsync()
122122
/// <returns></returns>
123123
public Task ClearStorageDataAsync(ClearStorageDataOptions options)
124124
{
125-
var tcs = new TaskCompletionSource<object>();
125+
var tcs = new TaskCompletionSource();
126126
string guid = Guid.NewGuid().ToString();
127127

128-
BridgeConnector.Socket.Once("webContents-session-clearStorageData-options-completed" + guid, () => tcs.SetResult(null));
128+
BridgeConnector.Socket.Once("webContents-session-clearStorageData-options-completed" + guid, () => tcs.SetResult());
129129
BridgeConnector.Socket.Emit("webContents-session-clearStorageData-options", Id, options, guid);
130130

131131
return tcs.Task;
@@ -276,10 +276,10 @@ public void SetPreloads(string[] preloads)
276276
/// <returns></returns>
277277
public Task SetProxyAsync(ProxyConfig config)
278278
{
279-
var tcs = new TaskCompletionSource<object>();
279+
var tcs = new TaskCompletionSource();
280280
string guid = Guid.NewGuid().ToString();
281281

282-
BridgeConnector.Socket.Once("webContents-session-setProxy-completed" + guid, () => tcs.SetResult(null));
282+
BridgeConnector.Socket.Once("webContents-session-setProxy-completed" + guid, () => tcs.SetResult());
283283
BridgeConnector.Socket.Emit("webContents-session-setProxy", Id, config, guid);
284284

285285
return tcs.Task;

src/ElectronNET.API/API/WebContents.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -254,12 +254,12 @@ public Task LoadURLAsync(string url)
254254
/// <param name="options"></param>
255255
public Task LoadURLAsync(string url, LoadURLOptions options)
256256
{
257-
var tcs = new TaskCompletionSource<object>();
257+
var tcs = new TaskCompletionSource();
258258

259259
BridgeConnector.Socket.Once("webContents-loadURL-complete" + Id, () =>
260260
{
261261
BridgeConnector.Socket.Off("webContents-loadURL-error" + Id);
262-
tcs.SetResult(null);
262+
tcs.SetResult();
263263
});
264264

265265
BridgeConnector.Socket.Once<string>("webContents-loadURL-error" + Id, (error) => { tcs.SetException(new InvalidOperationException(error)); });

0 commit comments

Comments
 (0)