ShowItemInFolderAsync: Fix endless hang

softworkz · softworkz · commit 2e5c6200a64a · 2025-11-17T13:58:47.000+01:00
diff --git a/src/ElectronNET.API/API/Shell.cs b/src/ElectronNET.API/API/Shell.cs
@@ -42,13 +42,9 @@ internal static Shell Instance
         /// <param name="fullPath">The full path to the directory / file.</param>
         public Task ShowItemInFolderAsync(string fullPath)
         {
-            var tcs = new TaskCompletionSource<object>();
-
-            // Is this really useful?
-            BridgeConnector.Socket.Once("shell-showItemInFolderCompleted", () => { });
             BridgeConnector.Socket.Emit("shell-showItemInFolder", fullPath);
 
-            return tcs.Task;
+            return Task.CompletedTask;
         }
 
         /// <summary>

Original file line number	Diff line number	Diff line change
`@@ -42,13 +42,9 @@ internal static Shell Instance`
`42`	`42`	`/// <param name="fullPath">The full path to the directory / file.</param>`
`43`	`43`	`public Task ShowItemInFolderAsync(string fullPath)`
`44`	`44`	`{`
`45`		`- var tcs = new TaskCompletionSource<object>();`
`46`		`-`
`47`		`- // Is this really useful?`
`48`		`- BridgeConnector.Socket.Once("shell-showItemInFolderCompleted", () => { });`
`49`	`45`	`BridgeConnector.Socket.Emit("shell-showItemInFolder", fullPath);`
`50`	`46`
`51`		`- return tcs.Task;`
	`47`	`+ return Task.CompletedTask;`
`52`	`48`	`}`
`53`	`49`
`54`	`50`	`/// <summary>`