Skip to content

Commit 1d554fd

Browse files
authored
Merge pull request #945 from softworkz/submit_outpath
BrowserWindowOptions; Fix default and add more Tests
2 parents aa483eb + 2f4d37d commit 1d554fd

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

.github/workflows/integration-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
rid: linux-x64
2323
- os: windows-2022
2424
rid: win-x64
25-
- os: macos-14
25+
- os: macos-26
2626
rid: osx-arm64
2727

2828
env:

src/ElectronNET.API/API/Entities/BrowserWindowOptions.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,10 +115,11 @@ public class BrowserWindowOptions
115115

116116
/// <summary>
117117
/// Whether the window can be put into fullscreen mode. On macOS, also whether the
118-
/// maximize/zoom button should toggle full screen mode or maximize window.Default
119-
/// is true.
118+
/// maximize/zoom button should toggle full screen mode or maximize window. Default
119+
/// is true (Electron default).
120120
/// </summary>
121-
public bool Fullscreenable { get; set; }
121+
[DefaultValue(true)]
122+
public bool Fullscreenable { get; set; } = true; // FIX: previously defaulted to false in C#
122123

123124
/// <summary>
124125
/// Whether to show the window in taskbar. Default is false.

0 commit comments

Comments
 (0)