Bugfix missing depdency from Coveralls package (#29)

* Bugfix missing depdency from Coveralls package

* elaborate test

Author: Ekman

composer.json

@@ -38,7 +38,8 @@
 	"require-dev": {
 		"phpunit/phpunit": "^6.0||^7.0",
 		"friendsofphp/php-cs-fixer": "^2.15",
-		"php-coveralls/php-coveralls": "^2.1"
+		"php-coveralls/php-coveralls": "^2.1",
+		"symfony/yaml": "^5.0"
 	},
 	"scripts": {
 		"lint": "php-cs-fixer fix",

src/LuhnAlgorithm.php

@@ -79,13 +79,14 @@ public function calcCheckDigit(NumberInterface $number): int
      */
     public function calcChecksum(NumberInterface $number): int
     {
-        $nDigits = strlen($number->getNumber());
+        $num = $number->getNumber();
+        $nDigits = strlen($num);
         // Need to account for check digit
         $parity = ($nDigits + 1) % 2;
         $checksum = 0;
 
         for ($i = 0; $i < $nDigits; $i++) {
-            $digit = (int) $number->getNumber()[$i];
+            $digit = (int) $num[$i];
 
             // Every other digit, starting from the rightmost,
             // shall be doubled.

tests/LuhnAlgorithmTest.php

@@ -95,6 +95,7 @@ public function provideCalcChecksum_success()
     {
         return [
             "Valid checksum" => [new Number(3199723370002), 50],
+            "Checksum mod 10 is 0" => [new Number(31997), 30],
         ];
     }
 
@@ -112,6 +113,7 @@ public function provideCalcCheckDigit_success()
             "Valid number" => [new Number(12345), 5],
             "Swedish company organization ID" => [new Number(559114884), 5],
             "Swedish organization number" => [new Number(640319261), 7],
+            "Checksum mod 10 is 0" => [new Number(31997), 0],
         ];
     }
 }