Merge pull request #5834 from EdgeApp/sam/libertyx-cash-payment-type

Sam/libertyx cash payment type

Author: samholmes

CHANGELOG.md

@@ -6,6 +6,7 @@
 
 - added: BitsOfGold and LibertyX ramp plugins.
 - fixed: Fixed broken `logEvent` tracking calls by adding the needed `dispatch`.
+- fixed: Localized display names for payment types in new buy/sell feature.
 - removed: Remove change quote tracking.
 
 ## 4.38.0 (2025-11-04)

src/locales/en_US.ts

@@ -1979,6 +1979,32 @@ const strings = {
 
   // #endregion Home
 
+  // Payment types
+  ach_bank_transfer: 'ACH Bank Transfer',
+  apple_pay: 'Apple Pay',
+  bank_transfer: 'Bank Transfer',
+  in_person_cash_and_debit_card: 'In-person Cash and Debit Card',
+  colombia_bank_transfer: 'Colombia Bank Transfer',
+  credit_and_debit_card: 'Credit and Debit Card',
+  debit_card: 'Debit Card',
+  direct_to_bank: 'Direct to Bank',
+  faster_payments: 'Faster Payments',
+  google_pay: 'Google Pay',
+  instant_ach_bank_transfer: 'Instant ACH Bank Transfer',
+  ideal: 'iDEAL',
+  interac_e_transfer: 'Interac e-Transfer',
+  mexico_bank_transfer: 'Mexico Bank Transfer',
+  payid: 'PayID',
+  paypal: 'Paypal',
+  pix: 'PIX',
+  pse_payment: 'PSE Payment',
+  revolut: 'Revolut',
+  sepa_bank_transfer: 'SEPA Bank Transfer',
+  spei_bank_transfer: 'SPEI Bank Transfer',
+  turkish_bank_transfer: 'Turkish Bank Transfer',
+  venmo: 'Venmo',
+  bank_wire_transfer: 'Bank Wire Transfer',
+
   // #region UK Compliance
 
   uk_deposit_parent_crypto_modal_message_no_exchange_2s:

src/locales/strings/enUS.json

@@ -1512,6 +1512,30 @@
   "title_support": "Need Support?",
   "body_support": "Contact our team of experts to troubleshoot your crypto needs",
   "button_support": "Contact Support",
+  "ach_bank_transfer": "ACH Bank Transfer",
+  "apple_pay": "Apple Pay",
+  "bank_transfer": "Bank Transfer",
+  "in_person_cash_and_debit_card": "In-person Cash and Debit Card",
+  "colombia_bank_transfer": "Colombia Bank Transfer",
+  "credit_and_debit_card": "Credit and Debit Card",
+  "debit_card": "Debit Card",
+  "direct_to_bank": "Direct to Bank",
+  "faster_payments": "Faster Payments",
+  "google_pay": "Google Pay",
+  "instant_ach_bank_transfer": "Instant ACH Bank Transfer",
+  "ideal": "iDEAL",
+  "interac_e_transfer": "Interac e-Transfer",
+  "mexico_bank_transfer": "Mexico Bank Transfer",
+  "payid": "PayID",
+  "paypal": "Paypal",
+  "pix": "PIX",
+  "pse_payment": "PSE Payment",
+  "revolut": "Revolut",
+  "sepa_bank_transfer": "SEPA Bank Transfer",
+  "spei_bank_transfer": "SPEI Bank Transfer",
+  "turkish_bank_transfer": "Turkish Bank Transfer",
+  "venmo": "Venmo",
+  "bank_wire_transfer": "Bank Wire Transfer",
   "uk_deposit_parent_crypto_modal_message_no_exchange_2s": "%1$s%2$s is required to send this transaction. Please deposit %2$s and try again.",
   "uk_deposit_parent_crypto_modal_message_no_exchange_3s": "%1$s%2$s (on %3$s) is required to send this transaction. Please deposit %2$s and try again.",
   "uk_token_agreement_modal_message": "%1$s is required to pay the mining fees when sending tokens. The associated %1$s wallet must contain a sufficient amount of funds.\n\nIf you do not have %1$s, you can acquire it within %2$s using the Exchange function.",

src/plugins/gui/fiatPluginTypes.ts

@@ -45,6 +45,7 @@ export type FiatDirection = ReturnType<typeof asFiatDirection>
 export const asFiatPaymentType = asValue(
   'ach',
   'applepay',
+  'cash',
   'colombiabank',
   'credit',
   'directtobank',

src/plugins/ramps/libertyx/libertyxRampPlugin.ts

@@ -17,7 +17,7 @@ export const libertyxRampPlugin: RampPluginFactory = config => {
       partnerIcon: initOptions.partnerIcon,
       guiPlugin: guiPlugins.libertyx,
       buy: {
-        paymentTypes: ['wire', 'credit'],
+        paymentTypes: ['cash'],
         countries: ['US'],
         cryptoAssets: [{ pluginId: 'bitcoin', tokenId: null }],
         settlementRange: SETTLEMENT_INSTANT,

src/plugins/ramps/utils/getSettlementRange.ts

@@ -42,6 +42,8 @@ export function getBuySettlementRange(
       return RANGE(10, 'minutes', 30, 'minutes')
     case 'colombiabank':
       return RANGE(5, 'minutes', 24, 'hours')
+    case 'cash':
+      return INSTANT
     case 'credit':
       return RANGE(10, 'minutes', 30, 'minutes')
     case 'directtobank':
@@ -92,6 +94,8 @@ export function getSellSettlementRange(
       return RANGE(2, 'days', 3, 'days')
     case 'applepay':
       return RANGE(10, 'minutes', 30, 'minutes')
+    case 'cash':
+      return INSTANT
     case 'colombiabank':
       return RANGE(5, 'minutes', 24, 'hours')
     case 'credit':

src/util/paymentTypeIcons.ts

@@ -8,6 +8,7 @@ const paymentTypeToThemeKey: Record<FiatPaymentType, keyof Theme | null> = {
   ach: 'paymentTypeLogoBankTransfer', // Using bank transfer as fallback
   applepay: 'paymentTypeLogoApplePay',
   colombiabank: 'paymentTypeLogoBankTransfer', // Using bank transfer as fallback
+  cash: 'paymentTypeLogoCash',
   credit: 'paymentTypeLogoCreditCard',
   directtobank: 'paymentTypeLogoBankTransfer', // Using bank transfer as fallback
   fasterpayments: 'paymentTypeLogoFasterPayments',

src/util/paymentTypeUtils.ts

@@ -1,29 +1,32 @@
+import { lstrings } from '../locales/strings'
+
 // Payment type display name mapping based on plugin configurations
 const paymentTypeDisplayNames: Record<string, string> = {
-  ach: 'ACH Bank Transfer',
-  applepay: 'Apple Pay',
-  bank: 'Bank Transfer',
-  colombiabank: 'Colombia Bank Transfer',
-  credit: 'Credit and Debit Card',
-  debit: 'Debit Card',
-  directtobank: 'Direct to Bank',
-  fasterpayments: 'Faster Payments',
-  googlepay: 'Google Pay',
-  iach: 'Instant ACH Bank Transfer',
-  ideal: 'iDEAL',
-  interac: 'Interac e-Transfer',
-  iobank: 'Bank Transfer',
-  mexicobank: 'Mexico Bank Transfer',
-  payid: 'PayID',
-  paypal: 'Paypal',
-  pix: 'PIX',
-  pse: 'PSE Payment',
-  revolut: 'Revolut',
-  sepa: 'SEPA Bank Transfer',
-  spei: 'SPEI Bank Transfer',
-  turkishbank: 'Turkish Bank Transfer',
-  venmo: 'Venmo',
-  wire: 'Bank Wire Transfer'
+  ach: lstrings.ach_bank_transfer,
+  applepay: lstrings.apple_pay,
+  bank: lstrings.bank_transfer,
+  cash: lstrings.in_person_cash_and_debit_card,
+  colombiabank: lstrings.colombia_bank_transfer,
+  credit: lstrings.credit_and_debit_card,
+  debit: lstrings.debit_card,
+  directtobank: lstrings.direct_to_bank,
+  fasterpayments: lstrings.faster_payments,
+  googlepay: lstrings.google_pay,
+  iach: lstrings.instant_ach_bank_transfer,
+  ideal: lstrings.ideal,
+  interac: lstrings.interac_e_transfer,
+  iobank: lstrings.bank_transfer,
+  mexicobank: lstrings.mexico_bank_transfer,
+  payid: lstrings.payid,
+  paypal: lstrings.paypal,
+  pix: lstrings.pix,
+  pse: lstrings.pse_payment,
+  revolut: lstrings.revolut,
+  sepa: lstrings.sepa_bank_transfer,
+  spei: lstrings.spei_bank_transfer,
+  turkishbank: lstrings.turkish_bank_transfer,
+  venmo: lstrings.venmo,
+  wire: lstrings.bank_wire_transfer
 }
 
 /**