Hi,
Apparently, using std::normal_distribution with zero std is undefined behavior.
In some tests like this one (simple_localizer_tests.cpp), the std params are initialized to 0.0 and the CI now has those tests finishing with error due to an assertion (see #66).
In addition to fixing the tests, I propose adding a check or guard when initializing the localizers, so the std params can only have values greater than zero.
Hi,
Apparently, using
std::normal_distributionwith zero std is undefined behavior.In some tests like this one (simple_localizer_tests.cpp), the std params are initialized to 0.0 and the CI now has those tests finishing with error due to an assertion (see #66).
In addition to fixing the tests, I propose adding a check or guard when initializing the localizers, so the std params can only have values greater than zero.