Implemented observeAll

Author: Josema

.gitignore

@@ -20,3 +20,4 @@ package-lock.json
 yarn.lock
 examples/drag/package-lock.json
 examples/todomvc/package-lock.json
+.vscode/launch.json

.vscode/launch.json

@@ -26,7 +26,7 @@ dop.core.observer.prototype.observe = function(object, property) {
         type = 'observers_prop'
     }
 
-    return this._observe(path_id, type)
+    return this.observe(path_id, type)
 }
 
 dop.core.observer.prototype.observeAll = function(object) {
@@ -40,11 +40,10 @@ dop.core.observer.prototype.observeAll = function(object) {
         'observer.observeAll() The object you are passing is not allocated to a registered object'
     )
 
-    return this._observe(dop.core.getPathId(path), 'observers_all')
+    return this.observe(dop.core.getPathId(path), 'observers_all')
 }
 
-// private
-dop.core.observer.prototype._observe = function(path_id, type) {
+dop.core.observer.prototype.observe = function(path_id, type) {
     var data_path = dop.data.path
 
     if (data_path[path_id] === undefined) data_path[path_id] = {}
@@ -60,27 +59,6 @@ dop.core.observer.prototype._observe = function(path_id, type) {
     }.bind(this)
 }
 
-// dop.core.observer.prototype.unobserve = function(object, property) {
-//     dop.util.invariant(dop.isRegistered(object), 'observer.unobserve() needs a registered object as first parameter');
-//     var path = dop.getObjectPath(object);
-//     dop.util.invariant(isArray(path), 'observer.unobserve() The object you are passing is not allocated to a registered object');
-
-//     var path_id = dop.core.getPathId(path);
-//         data_path = dop.data.path,
-//         type = 'observers';
-
-//     // is observeProperty
-//     if (arguments.length === 2) {
-//         type = 'observers_prop';
-//         path_id += dop.core.pathSeparator(property);
-//     }
-
-//     if (data_path[path_id] !== undefined && data_path[path_id][type] !== undefined) {
-//         delete data_path[path_id][type][this.id];
-//         delete this[type][path_id];
-//     }
-// };
-
 dop.core.observer.prototype.destroy = function() {
     var path_id,
         data_path = dop.data.path

src/core/constructors/observer.js

@@ -42,18 +42,9 @@ dop.core.emitToObservers = function(mutations) {
                 data_path[path_id_all].observers_all !== undefined
             ) {
                 for (observer_id in data_path[path_id_all].observers_all) {
-                    console.log(
-                        { path_id_all, observer_id },
-                        data_path[path_id_all].observers_all[observer_id]
-                    )
-                    // if (
-                    //     mutations_by_observers[observer_id] ===
-                    //     undefined
-                    // )
-                    //     mutations_by_observers[observer_id] = []
-                    // mutations_by_observers[observer_id].push(
-                    //     mutation
-                    // )
+                    if (mutations_by_observers[observer_id] === undefined)
+                        mutations_by_observers[observer_id] = []
+                    mutations_by_observers[observer_id].push(mutation)
                 }
             }
         }

src/core/objects/emitToObservers.js

@@ -2,17 +2,62 @@ var test = require('tape')
 // require('tabe').createStream( test );
 var dop = require('./.proxy').create()
 
-test('observeAll', function(t) {
+test('observing root', function(t) {
     var object = dop.register({
         a: { a1: true },
         b: { b1: { b11: true } }
     })
     var observer = dop.createObserver(function(mutations) {
-        // t.equal(Array.isArray(mutations[0].swaps), true)
-        // t.end()
+        t.equal(mutations.length, 1)
+        t.end()
     })
-    observer.observeAll(object.b)
+    // observer.observeAll(object.b)
     observer.observeAll(object)
     object.b.b1.b11 = false
+})
+
+test('mutation above', function(t) {
+    var object = dop.register({
+        a: true,
+        b: { b1: { b11: true } }
+    })
+    var observer = dop.createObserver(function(mutations) {
+        t.equal(true, false, 'This should not happen')
+    })
+    observer.observeAll(object.b)
+    object.a = false
+    t.equal(true, true, 'All good')
     t.end()
 })
+
+test('mutating both levels observing root', function(t) {
+    var object = dop.register({
+        a: true,
+        b: { b1: { b11: true } }
+    })
+    var observer = dop.createObserver(function(mutations) {
+        t.equal(mutations.length, 2)
+        t.end()
+    })
+    observer.observeAll(object)
+    dop.action(function() {
+        object.a = false
+        object.b.b1.b11 = false
+    })()
+})
+
+test('mutating both levels observing deep', function(t) {
+    var object = dop.register({
+        a: true,
+        b: { b1: { b11: true } }
+    })
+    var observer = dop.createObserver(function(mutations) {
+        t.equal(mutations.length, 1)
+        t.end()
+    })
+    observer.observeAll(object.b.b1)
+    dop.action(function() {
+        object.a = false
+        object.b.b1.b11 = false
+    })()
+})