dop.action and passed ESLint

Author: Josema

package.json

@@ -1,6 +1,6 @@
 {
   "name": "dop",
-  "version": "0.24.3",
+  "version": "0.25.0",
   "main": "./dist/dop.nodejs.js",
   "browser": "./dist/dop.js",
   "unpkg": "./dist/dop.min.js",

src/api/action.js

@@ -0,0 +1,8 @@
+
+dop.action = function(func) {
+    return function() {
+        var collector = dop.collect();
+        func.apply(this, arguments);
+        collector.emit();
+    }
+};

src/api/getObjectPath.js

@@ -5,9 +5,10 @@ dop.getObjectPath = function(object, strict) {
         // path_id = '',
         parent,
         prop,
-        strict = strict !== false,
         object_dop = object[dop.cons.DOP];
 
+    strict = strict !== false;    
+
     while (object_dop._ !== undefined) {
         prop = object_dop.pr;
         parent = dop.getObjectTarget(object_dop._);

src/api/removeComputed.js

@@ -14,7 +14,7 @@ dop.removeComputed = function(object, property, callback) {
         derivation_pathid,
         derivations,
         index,
-        total,
+        // total,
         index2,
         total2;
 

src/core/constructors/observer.js

@@ -13,7 +13,7 @@ dop.core.observer.prototype.observe = function(object, property) {
     dop.util.invariant(isArray(path), 'observer.observe() The object you are passing is not allocated to a registered object');
 
 
-    var path_id = dop.core.getPathId(path);
+    var path_id = dop.core.getPathId(path),
         data_path = dop.data.path,
         type = 'observers';
 

src/core/constructors/snapshot.js

@@ -46,7 +46,7 @@ dop.core.snapshot.prototype.getUnpatch = function() {
 
 
 dop.core.snapshot.prototype.setPatch = function(patch) {
-    for (object_id in patch)
+    for (var object_id in patch)
         dop.core.setPatch(
             patch[object_id].object,
             patch[object_id].chunks,

src/core/mutators/splice.js

@@ -12,15 +12,16 @@ dop.core.splice = function(array, args) {
 
     // If enviroment do not allow proxies (objectTarget and objectProxy are same object in that case) 
     // or if the array is the proxy itself
-    if (path = dop.getObjectPath(array)) {
+    path = dop.getObjectPath(array)
+    if (path) {
 
         var argslength = args.length,
             length = objectTarget.length,
             index=2,
             start = Number(args[0]),
-            deleteCount = (Number(args[1])>0) ? args[1] : 0,
+            // deleteCount = (Number(args[1])>0) ? args[1] : 0,
             itemslength = (args.length>2) ? (args.length-2) : 0,
-            end, item, object_dop;
+            item;
 
 
         // Defaults for start
@@ -32,13 +33,13 @@ dop.core.splice = function(array, args) {
             start = originalLength;
 
 
-        // We dont need update becase no items remaining after splice
-        end = (argslength===1) ? 0 :
-            // If deleteCount is the same of items to add means the new lengh is the same and we only need to update the new elements
-            (argslength>2 && deleteCount===itemslength) ?
-                start+deleteCount
-            :
-                objectTarget.length;
+        // // We dont need update becase no items remaining after splice
+        // end = (argslength===1) ? 0 :
+        //     // If deleteCount is the same of items to add means the new lengh is the same and we only need to update the new elements
+        //     (argslength>2 && deleteCount===itemslength) ?
+        //         start+deleteCount
+        //     :
+        //         objectTarget.length;
 
 
         // We must register new objects

src/core/objects/configureObject.js

@@ -58,8 +58,7 @@ dop.core.configureObject = function(object, propertyParent, parent) {
         value,
         path,
         is_array = isArray(object_target),
-        is_function,
-        computed_pending = [];
+        is_function;
 
     for (property in object_target) {
         if (is_array)

src/core/objects/createComputed.js

@@ -1,14 +1,15 @@
 
 dop.core.createComputed = function (object, prop, f, shallWeSet, oldValue) {
     var data_path = dop.data.path,
-    computed_id = dop.data.computed_inc++,
-    computed = {
-        object_root: dop.getObjectRoot(object),
-        prop: prop,
-        function: f,
-        derivations: []
-    },
-    path = dop.getObjectPath(object, false);
+        value,
+        computed_id = dop.data.computed_inc++,
+        computed = {
+            object_root: dop.getObjectRoot(object),
+            prop: prop,
+            function: f,
+            derivations: []
+        },
+        path = dop.getObjectPath(object, false);
 
     computed.path = path.slice(1);
     computed.pathid = dop.core.getPathId(path.concat(prop));

src/core/objects/injectMutationInPatch.js

@@ -9,8 +9,11 @@ dop.core.injectMutationInPatch = function(patch, mutation) {
         isMutationArray = isMutationSplice || isMutationSwaps,
         typeofValue = dop.util.typeof(value),
         index = 1,
-        chunk = chunkParent = patch.chunks[patch.chunks.length-1],
-        chunkNext = chunkNextParent = chunkNextRoot = {},
+        chunk = patch.chunks[patch.chunks.length-1],
+        chunkParent = chunk,
+        chunkNext = {},
+        chunkNextParent = chunkNext,
+        chunkNextRoot = chunkNext,
         tofCurrentObject,
         specialInstruction,
         instructionsPatchs = dop.protocol.instructionsPatchs,