reject an rpc as 0 is converted to null

Author: Josema

package.json

@@ -1,6 +1,6 @@
 {
     "name": "dop",
-    "version": "1.0.1",
+    "version": "1.0.2",
     "main": "dist/dop.js",
     "browser": "dist/dop.umd.js",
     "license": "MIT",

src/api/createNodeFactory.js

@@ -72,12 +72,8 @@ export default function createNodeFactory({ encoders, decoders }) {
 
         function message(msg) {
             msg = deserialize(msg)
-            try {
-                msg = decode(msg)
-            } catch (e) {
-                // Invalid array to decode
-                return false
-            }
+            if (!isArray(msg)) return false
+            msg = decode(msg)
 
             let [id, function_id, args] = msg
             const response_id = -id
@@ -105,7 +101,7 @@ export default function createNodeFactory({ encoders, decoders }) {
                             if (value !== undefined) response.push(value)
                             api.send(encode(response))
                         }).catch(error => {
-                            response.push(error) // error
+                            response.push(error === 0 ? null : error)
                             api.send(encode(response))
                         })
                         args.push(req)

test/rpc.js

@@ -109,6 +109,18 @@ const localFunctions = {
 
     throwError: function() {
         throw new Error('whatever')
+    },
+
+    throwUndefined: function() {
+        throw undefined
+    },
+
+    throwNull: function() {
+        throw null
+    },
+
+    throwZero: function() {
+        throw 0
     }
 }
 
@@ -302,17 +314,62 @@ test('ReferenceError error', async function(t) {
     }
 })
 
-// test('throw new Error()', async function(t) {
-//     try {
-//         remoteFunctions.throwError()
-//         t.true(false)
-//     } catch (e) {
-//         t.true(e instanceof Error)
-//     }
-//     try {
-//         await remoteFunctions.throwError()
-//         t.true(false)
-//     } catch (e) {
-//         t.true(e instanceof Error)
-//     }
-// })
+test('throw new Error()', async function(t) {
+    try {
+        localFunctions.throwError()
+        t.true(false)
+    } catch (e) {
+        t.true(e instanceof Error)
+    }
+    try {
+        await remoteFunctions.throwError()
+        t.true(false)
+    } catch (e) {
+        t.true(e instanceof Error)
+    }
+})
+
+test('throwUndefined', async function(t) {
+    try {
+        localFunctions.throwUndefined()
+        t.true(false)
+    } catch (e) {
+        t.is(e, undefined)
+    }
+    try {
+        await remoteFunctions.throwUndefined()
+        t.true(false)
+    } catch (e) {
+        t.is(e, null)
+    }
+})
+
+test('throwNull', async function(t) {
+    try {
+        localFunctions.throwNull()
+        t.true(false)
+    } catch (e) {
+        t.is(e, null)
+    }
+    try {
+        await remoteFunctions.throwNull()
+        t.true(false)
+    } catch (e) {
+        t.is(e, null)
+    }
+})
+
+test('throwZero', async function(t) {
+    try {
+        localFunctions.throwZero()
+        t.true(false)
+    } catch (e) {
+        t.is(e, 0)
+    }
+    try {
+        await remoteFunctions.throwZero('lel')
+        t.true(false)
+    } catch (e) {
+        t.is(e, null)
+    }
+})