Test passed for socket.io

Author: Josema

dist/browser.js

@@ -177,8 +177,9 @@ function websocket(dop, node, options) {
             send_queue.push(message); 
     }
     function sendQueue() {
-        while (send_queue.length>0)
-            socket.send(send_queue.shift());
+        if (socket.readyState===socket.constructor.OPEN)
+            while (send_queue.length>0)
+                socket.send(send_queue.shift());
     }
 
     // Socket events
@@ -216,7 +217,7 @@ function websocket(dop, node, options) {
             dop.core.emitDisconnect(node);
             dop.core.setSocketToNode(node, socket);
         }
-        socket.send(message_response);
+        send(message_response);
         readyState = CONNECT;
         dop.core.emitConnect(node);
         sendQueue();
@@ -227,7 +228,7 @@ function websocket(dop, node, options) {
     }
 
     function reconnect() {
-        if (readyState !== CONNECT) {
+        if (readyState === CLOSE) {
             oldSocket = socket;
             socket = new api(url);
             readyState = CONNECTING;

dist/browser.min.js

@@ -61,6 +61,7 @@
     "test-safari": "browserify test/*.js | tape-run --render=\"faucet\" --browser safari",
     "test-firefox": "browserify test/*.js | tape-run --render=\"faucet\" --browser firefox",
     "test-websockets": "tap test/transports/**.js --test-arg=websockets",
+    "test-socketio": "tap test/transports/**.js --test-arg=socketio",
     "test-sockjs": "tap test/transports/**.js --test-arg=sockjs"
   }
 }

package.json

@@ -1,7 +1,6 @@
 
 var test = require('tape');
 // require('tabe').createStream( test );
-var requireNew = require('require-new');
 var dop = require('../dist/nodejs');
 
 

test/collectors.js

@@ -3,7 +3,7 @@ var dop = require('../../dist/nodejs');
 var dopServer = dop.create();
 var dopClient = dop.create();
 
-var transportName = process.argv[2] || 'local';
+var transportName = process.argv[2] || 'socketio';
 var transportListen = require('dop-transports').listen[transportName];
 var transportConnect = require('dop-transports').connect[transportName];
 
@@ -53,7 +53,9 @@ test('CONNECT TEST', function(t) {
             t.equal(message, String(incC++), '✅ message `'+message+'`');
             if (incS===16 && incC===16) {
                 t.end();
-                try {server.listener.close();
+                try {
+                    server.listener.close();
+                    nodeClient.socket.close();
                 } catch(e) {process.exit();}
             }
         }

test/transports/queue.js

@@ -43,7 +43,9 @@ test('RECONNECT TEST', function(t) {
     nodeClient.on('reconnect', function(oldSocket) {
         t.equal(oldSocket, socketClient, '✅ reconnect');
         t.end();
-        try {server.listener.close();
+        try {
+            server.listener.close();
+            nodeClient.socket.close();
         } catch(e) {process.exit();}
     });
 });

test/transports/reconnect.js

@@ -3,7 +3,7 @@ var dop = require('../../dist/nodejs');
 var dopServer = dop.create();
 var dopClient = dop.create();
 
-var transportName = process.argv[2] || 'sockjs';
+var transportName = process.argv[2] || 'local';
 var transportListen = require('dop-transports').listen[transportName];
 var transportConnect = require('dop-transports').connect[transportName];
 
@@ -33,7 +33,9 @@ test('RECONNECT TEST', function(t) {
             connected2 = true;
             t.notEqual(node.socket, socketServer, '❌ connect 2');
             t.end();
-            try {server.listener.close();
+            try {
+                server.listener.close();
+                nodeClient.socket.close();
             } catch(e) {process.exit();}
         }
     });