diff --git a/apps/roam/src/components/settings/DiscourseNodeCanvasSettings.tsx b/apps/roam/src/components/settings/DiscourseNodeCanvasSettings.tsx index 287f4194b..6718642e8 100644 --- a/apps/roam/src/components/settings/DiscourseNodeCanvasSettings.tsx +++ b/apps/roam/src/components/settings/DiscourseNodeCanvasSettings.tsx @@ -1,11 +1,9 @@ import { InputGroup, - Label, Radio, RadioGroup, Tooltip, Icon, - ControlGroup, } from "@blueprintjs/core"; import React, { useState, useMemo } from "react"; import getBasicTreeByParentUid from "roamjs-components/queries/getBasicTreeByParentUid"; @@ -37,10 +35,6 @@ const DiscourseNodeCanvasSettings = ({ uid: string; }) => { const tree = useMemo(() => getBasicTreeByParentUid(uid), [uid]); - const [color, setColor] = useState(() => { - const color = getSettingValueFromTree({ tree, key: "color" }); - return formatHexColor(color); - }); const alias = getSettingValueFromTree({ tree, key: "alias" }); const [queryBuilderAlias, setQueryBuilderAlias] = useState(() => getSettingValueFromTree({ tree, key: "query-builder-alias" }), @@ -54,49 +48,6 @@ const DiscourseNodeCanvasSettings = ({ return (
-
- - - { - const colorValue = e.target.value.replace("#", ""); // remove hash to not create roam link - setColor(e.target.value); - void setInputSetting({ - blockUid: uid, - key: "color", - value: colorValue, - }); - setDiscourseNodeSetting( - nodeType, - ["canvasSettings", "color"], - colorValue, - ); - }} - /> - - { - setColor(""); - void setInputSetting({ - blockUid: uid, - key: "color", - value: "", - }); - setDiscourseNodeSetting( - nodeType, - ["canvasSettings", "color"], - "", - ); - }} - /> - - -
getBasicTreeByParentUid(canvasUid), + [canvasUid], + ); + const [color, setColor] = useState(() => { + const colorValue = getSettingValueFromTree({ + tree: canvasTree, + key: "color", + }); + return formatHexColor(colorValue); + }); + const [selectedTabId, setSelectedTabId] = useState("general"); const [tagError, setTagError] = useState(""); const [formatError, setFormatError] = useState(""); @@ -180,7 +206,51 @@ const NodeConfig = ({ order={2} parentUid={node.type} uid={tagUid} + inputStyle={color ? { color } : undefined} /> +
+ + + { + const colorValue = e.target.value.replace("#", ""); // remove hash to not create roam link + setColor(e.target.value); + void setInputSetting({ + blockUid: canvasUid, + key: "color", + value: colorValue, + }); + setDiscourseNodeSetting( + node.type, + ["canvasSettings", "color"], + colorValue, + ); + }} + /> + + { + setColor(""); + void setInputSetting({ + blockUid: canvasUid, + key: "color", + value: "", + }); + setDiscourseNodeSetting( + node.type, + ["canvasSettings", "color"], + "", + ); + }} + /> + + +
} /> diff --git a/apps/roam/src/components/settings/components/BlockPropSettingPanels.tsx b/apps/roam/src/components/settings/components/BlockPropSettingPanels.tsx index eeed53191..d31972d97 100644 --- a/apps/roam/src/components/settings/components/BlockPropSettingPanels.tsx +++ b/apps/roam/src/components/settings/components/BlockPropSettingPanels.tsx @@ -50,6 +50,7 @@ type BaseTextPanelProps = { multiline?: boolean; error?: string; onChange?: (value: string) => void; + inputStyle?: React.CSSProperties; } & RoamBlockSyncProps; type BaseFlagPanelProps = { @@ -105,6 +106,7 @@ const BaseTextPanel = ({ multiline, error, onChange, + inputStyle, parentUid, uid, order, @@ -162,6 +164,7 @@ const BaseTextPanel = ({ value={value} onChange={handleChange} placeholder={placeholder || initialValue} + style={inputStyle} /> )} @@ -612,6 +615,7 @@ export const DiscourseNodeTextPanel = ({ multiline?: boolean; error?: string; onChange?: (value: string) => void; + inputStyle?: React.CSSProperties; }) => ( );