feat(dvc): close channel API for server and client#1302
Draft
uchouT (uchouT) wants to merge 2 commits into
Draft
feat(dvc): close channel API for server and client#1302uchouT (uchouT) wants to merge 2 commits into
uchouT (uchouT) wants to merge 2 commits into
Conversation
MS-RDPEDYC 3.2.5.2: > A channel can be closed by either a DVC client manager or a DVC server > manager. A DYNVC_CLOSE (section 2.2.4) PDU is used for both a close > request and a close response. DYNVC_CLOSE is a symmetric PDU. > If the client receives a DYNVC_CLOSE (section 2.2.4) PDU for a channel > that is not in the list of active ChannelIds, the client MUST ignore the > PDU and SHOULD NOT respond with a DYNVC_CLOSE (section 2.2.4) PDU. Currently the client always responds with a DYNVC_CLOSE Signed-off-by: uchouT <i@uchout.moe>
Signed-off-by: uchouT <i@uchout.moe>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Quesions
The server-side
close_channelis not implemented yet.A server-initiated
DYNVC_CLOSEmay receive a response from the client. Should the server perform the local channel teardown when sending the request, or only after the client's response arrives?When the server currently handles an incoming
ClosePdu, it just marksChannelState::Closed. Should it instead remove the DVC instance entirely?