fix(server): drop raw user_data dump from McsMessage::SendDataRequest debug log#1295
Open
Greg Lamberson (glamberson) wants to merge 1 commit into
Open
Conversation
… debug log `debug!(?data, "McsMessage::SendDataRequest")` invoked the derived Debug impl on `SendDataRequest<'a>`, which formats `user_data: Cow<'a, [u8]>` as a decimal byte sequence. At DEBUG level the log line then ran to several hundred bytes per MCS request -- and there is one MCS request per keystroke, mouse event, channel message, etc. The raw bytes themselves carry no diagnostic value at this layer (channel processors log their own decoded PDUs); channel id, initiator, and payload length are the actionable fields. Switch to structured logging that preserves those three fields and drops the payload. Single log statement, no API or behaviour change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
debug!(?data, "McsMessage::SendDataRequest")invoked derivedDebugonSendDataRequest<'a>, formattinguser_data: Cow<'a, [u8]>as a decimal byte sequence.Validation
cargo xtask check fmt/lints/tests/typos/locksall pass.Notes
?datadumps.user_data_lenfield name matches existingresponse_lenprecedent inironrdp-async,ironrdp-acceptor,ironrdp-blocking.