fix: move Web instantiation

dnitsch · dnitsch · commit cbb17a802e96 · 2022-03-25T15:00:13.000Z
to an if block to avoid booting up chromium every time
diff --git a/Makefile b/Makefile
@@ -1,5 +1,5 @@
 NAME := aws-cli-auth
-VERSION := v0.6.0
+VERSION := v0.6.1
 REVISION := $(shell git rev-parse --short HEAD)
 
 LDFLAGS := -ldflags="-s -w -X \"github.com/dnitsch/aws-cli-auth/cmd.Version=$(VERSION)\" -X \"github.com/dnitsch/aws-cli-auth/cmd.Revision=$(REVISION)\" -extldflags -static"
diff --git a/internal/auth/saml.go b/internal/auth/saml.go
@@ -15,7 +15,6 @@ func GetSamlCreds(conf config.SamlConfig) {
 		util.Exit(nil)
 	}
 
-	web := web.New()
 	secretStore := util.NewSecretStore(conf.BaseConfig.Role)
 	var awsCreds *util.AWSCredentials
 
@@ -27,6 +26,7 @@ func GetSamlCreds(conf config.SamlConfig) {
 	}
 
 	if !util.IsValid(awsCreds) || err != nil {
+		web := web.New()
 
 		t, err := web.GetSamlLogin(conf)
 		if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,6 @@ func GetSamlCreds(conf config.SamlConfig) {`
`15`	`15`	`util.Exit(nil)`
`16`	`16`	`}`
`17`	`17`
`18`		`- web := web.New()`
`19`	`18`	`secretStore := util.NewSecretStore(conf.BaseConfig.Role)`
`20`	`19`	`var awsCreds *util.AWSCredentials`
`21`	`20`
`@@ -27,6 +26,7 @@ func GetSamlCreds(conf config.SamlConfig) {`
`27`	`26`	`}`
`28`	`27`
`29`	`28`	`if !util.IsValid(awsCreds) \|\| err != nil {`
	`29`	`+ web := web.New()`
`30`	`30`
`31`	`31`	`t, err := web.GetSamlLogin(conf)`
`32`	`32`	`if err != nil {`