Fix: add linters to the CI tasks (#23)

* fix: add linters

* fix: os process find and kill properly

* fix: correct condition

Author: dnitsch

.github/workflows/ci.yml

@@ -56,7 +56,7 @@ jobs:
 
       - name: Run linters
         run: |
-          echo 'eirctl run vuln:check'
+          eirctl run lints
 
       - name: Unit Tests
         run: |

.golangci.yaml

@@ -0,0 +1,31 @@
+version: "2"
+linters:
+  # Default set of linters.
+  # The value can be: `standard`, `all`, `none`, or `fast`.
+  # Default: standard
+  default: standard
+  exclusions:
+    generated: lax
+    # Log a warning if an exclusion rule is unused.
+    # Default: false
+    warn-unused: true
+    # Predefined exclusion rules.
+    # Default: []
+    presets:
+      - comments
+      - std-error-handling
+      - common-false-positives
+      - legacy
+    # Excluding configuration per-path, per-linter, per-text and per-source.
+    rules:
+      # Exclude some linters from running on tests files.
+      - path: _test\.go
+        linters:
+          - gocyclo
+          - errcheck
+          - dupl
+          - gosec
+          - ineffassign
+          - staticcheck
+          - unused
+          - govet

Makefile

@@ -67,7 +67,7 @@ func newSamlCmd(r *Root) {
 				return err
 			}
 
-			allRoles := credentialexchange.MergeRoleChain(flags.role, r.rootFlags.roleChain, sc.flags.isSso)
+			allRoles := credentialexchange.MergeRoleChain(flags.role, r.rootFlags.roleChain, flags.isSso)
 			conf := credentialexchange.CredentialConfig{
 				ProviderUrl:  flags.providerUrl,
 				PrincipalArn: flags.principalArn,

cmd/saml.go

@@ -74,7 +74,7 @@ tasks:
       - |
         mkdir -p .deps
         ldflags="-s -w -X \"github.com/{{.RepoOwner}}/{{.BinName}}/cmd.Version={{.Version}}\" -X \"github.com/{{.RepoOwner}}/{{.BinName}}/cmd.Revision={{.Revision}}\" -extldflags -static"
-        CGO_ENABLED=0 GOPATH=$PWD/.deps GOOS=${BUILD_GOOS} GOARCH=${BUILD_GOARCH} go build -mod=readonly -buildvcs=false -ldflags="$ldflags" -o dist/{{.BinName}}-${BUILD_GOOS}${BUILD_GOARCH} .
+        CGO_ENABLED=0 GOPATH=$PWD/.deps GOOS=${BUILD_GOOS} GOARCH=${BUILD_GOARCH} go build -mod=readonly -buildvcs=false -ldflags="$ldflags" -o dist/{{.BinName}}-${BUILD_GOOS}-${BUILD_GOARCH} .
     variations:
       - BUILD_GOOS: windows
         BUILD_GOARCH: amd64

eirctl.yaml

@@ -227,6 +227,7 @@ func (web *Web) MustClose() {
 	utils.Sleep(0.5)
 	// remove process just in case
 	// os.Process is cross platform safe way to remove a process
-	osprocess := os.Process{Pid: web.launcher.PID()}
-	_ = osprocess.Kill()
+	if osprocess, err := os.FindProcess(web.launcher.PID()); err == nil && osprocess != nil {
+		_ = osprocess.Kill()
+	}
 }