Skip to content

Commit 4b0fa5d

Browse files
authored
fix: mark SSE connection as connected when COMMENT events are received (#104)
related to ld-eventsource comment events
1 parent 54ad4a2 commit 4b0fa5d

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

devcycle_python_sdk/managers/sse_manager.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@ def read_events(
4242
handle_error(event)
4343
elif isinstance(event, ld_eventsource.actions.Event):
4444
handle_message(event)
45+
elif isinstance(event, ld_eventsource.actions.Comment):
46+
handle_state(None)
4547
except Exception as e:
4648
logger.debug(f"DevCycle: failed to read SSE message: {e}")
4749

devcycle_python_sdk/options.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ def __init__(
3737
self,
3838
config_cdn_uri: str = "https://config-cdn.devcycle.com/",
3939
config_request_timeout_ms: int = 5000,
40-
config_polling_interval_ms: int = 1000,
40+
config_polling_interval_ms: int = 30000,
4141
config_retry_delay_ms: int = 200, # milliseconds
4242
on_client_initialized: Optional[Callable] = None,
4343
events_api_uri: str = "https://events.devcycle.com/",

0 commit comments

Comments
 (0)