From 61a7ce87ec7956d9834a722d868f9c5c48956b09 Mon Sep 17 00:00:00 2001 From: Jonathan Norris Date: Mon, 20 Jan 2025 12:58:00 -0500 Subject: [PATCH] feat: set SSE connections as the default --- .../local/managers/EnvironmentConfigManager.java | 2 +- .../sdk/server/local/model/DevCycleLocalOptions.java | 11 ++++++++++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/devcycle/sdk/server/local/managers/EnvironmentConfigManager.java b/src/main/java/com/devcycle/sdk/server/local/managers/EnvironmentConfigManager.java index 9ee497c4..5460cad1 100644 --- a/src/main/java/com/devcycle/sdk/server/local/managers/EnvironmentConfigManager.java +++ b/src/main/java/com/devcycle/sdk/server/local/managers/EnvironmentConfigManager.java @@ -83,7 +83,7 @@ public boolean isConfigInitialized() { private ProjectConfig getConfig() throws DevCycleException { Call config = this.configApiClient.getConfig(this.sdkKey, this.configETag, this.configLastModified); this.config = getResponseWithRetries(config, 1); - if (this.options.isEnableBetaRealtimeUpdates()) { + if (!this.options.isDisableRealtimeUpdates()) { try { URI uri = new URI(this.config.getSse().getHostname() + this.config.getSse().getPath()); if (sseManager == null) { diff --git a/src/main/java/com/devcycle/sdk/server/local/model/DevCycleLocalOptions.java b/src/main/java/com/devcycle/sdk/server/local/model/DevCycleLocalOptions.java index e6e36ccb..6e13b839 100644 --- a/src/main/java/com/devcycle/sdk/server/local/model/DevCycleLocalOptions.java +++ b/src/main/java/com/devcycle/sdk/server/local/model/DevCycleLocalOptions.java @@ -28,6 +28,12 @@ public class DevCycleLocalOptions implements IDevCycleOptions { private boolean disableAutomaticEventLogging = false; + private boolean disableRealtimeUpdates = false; + + /** + * @deprecated real time updates are enabled by default now + */ + @Deprecated private boolean enableBetaRealtimeUpdates = false; @JsonIgnore @@ -52,7 +58,9 @@ public DevCycleLocalOptions( boolean disableCustomEventLogging, IDevCycleLogger customLogger, IRestOptions restOptions, - boolean enableBetaRealtimeUpdates + @Deprecated + boolean enableBetaRealtimeUpdates, + boolean disableRealtimeUpdates ) { this.configRequestTimeoutMs = configRequestTimeoutMs > 0 ? configRequestTimeoutMs : this.configRequestTimeoutMs; this.configPollingIntervalMS = getConfigPollingIntervalMS(configPollingIntervalMs, configPollingIntervalMS); @@ -67,6 +75,7 @@ public DevCycleLocalOptions( this.customLogger = customLogger; this.restOptions = restOptions; this.enableBetaRealtimeUpdates = enableBetaRealtimeUpdates; + this.disableRealtimeUpdates = disableRealtimeUpdates; if (this.flushEventQueueSize >= this.maxEventQueueSize) { DevCycleLogger.warning("flushEventQueueSize: " + this.flushEventQueueSize + " must be smaller than maxEventQueueSize: " + this.maxEventQueueSize);