Fix analysis params not cleared after deleting results

Closes #285

Author: PierreRaybaut

datalab/gui/actionhandler.py

@@ -50,6 +50,10 @@
 from datalab.adapters_metadata import GeometryAdapter, TableAdapter, have_results
 from datalab.config import Conf, _
 from datalab.gui import newobject
+from datalab.gui.processor.base import (
+    clear_analysis_parameters,
+    extract_analysis_parameters,
+)
 from datalab.widgets import fitdialog
 
 if TYPE_CHECKING:
@@ -361,6 +365,15 @@ def _delete_single_result(
             obj: Object containing the result
             adapter: Adapter for the result to delete
         """
+        # Check if this result matches the stored analysis parameters
+        # If so, clear them to prevent auto-recompute from attempting to
+        # recompute the deleted analysis when ROI changes
+        analysis_params = extract_analysis_parameters(obj)
+        if (
+            analysis_params is not None
+            and analysis_params.func_name == adapter.func_name
+        ):
+            clear_analysis_parameters(obj)
         adapter.remove_from(obj)
         # Update properties panel to reflect the removal
         if obj is self.panel.objview.get_current_object():

datalab/gui/panel/base.py

@@ -79,6 +79,7 @@
 from datalab.gui.processor.base import (
     PROCESSING_PARAMETERS_OPTION,
     ProcessingParameters,
+    clear_analysis_parameters,
     extract_processing_parameters,
     insert_processing_parameters,
 )
@@ -3276,6 +3277,9 @@ def delete_results(self) -> None:
                     # Remove all table and geometry results using adapter methods
                     TableAdapter.remove_all_from(obj)
                     GeometryAdapter.remove_all_from(obj)
+                    # Clear analysis parameters to prevent auto-recompute from
+                    # attempting to recompute deleted analyses when ROI changes
+                    clear_analysis_parameters(obj)
                     if obj is self.objview.get_current_object():
                         self.objprop.update_properties_from(obj)
                 # Update action states to reflect the removal

datalab/gui/processor/base.py

@@ -195,6 +195,21 @@ def insert_processing_parameters(
         obj.set_metadata_option(PROCESSING_PARAMETERS_OPTION, pp.to_dict())
 
 
+def clear_analysis_parameters(obj: SignalObj | ImageObj) -> None:
+    """Clear analysis parameters from object metadata.
+
+    This removes the stored analysis parameters (1-to-0 operations) from the object.
+    Should be called when all analysis results are deleted to prevent the
+    auto_recompute_analysis function from attempting to recompute deleted analyses.
+
+    Args:
+        obj: Signal or Image object
+    """
+    key = f"__{ANALYSIS_PARAMETERS_OPTION}"
+    if key in obj.metadata:
+        del obj.metadata[key]
+
+
 def run_with_env(func: Callable, args: tuple, env_json: str) -> CompOut:
     """Wrapper to apply environment config before calling func
 

datalab/tests/features/common/result_deletion_unit_test.py

@@ -12,12 +12,13 @@
 
 from __future__ import annotations
 
-from sigima.objects import Gauss2DParam, create_image_from_param
+from sigima.objects import Gauss2DParam, create_image_from_param, create_image_roi
 from sigima.tests.data import create_paracetamol_signal
 
 from datalab.adapters_metadata import GeometryAdapter, TableAdapter
 from datalab.config import Conf
 from datalab.env import execenv
+from datalab.gui.processor.base import extract_analysis_parameters
 from datalab.objectmodel import get_uuid
 from datalab.tests import datalab_test_app_context
 
@@ -91,6 +92,69 @@ def test_delete_results_signal():
         execenv.print("  ✓ Stats result deleted")
 
 
+def test_delete_results_clears_analysis_parameters():
+    """Test that deleting results also clears analysis parameters.
+
+    This prevents auto_recompute_analysis from attempting to recompute
+    deleted analyses when ROI changes.
+    """
+    with datalab_test_app_context(console=False) as win:
+        execenv.print("Test delete_results clears analysis parameters:")
+        panel = win.imagepanel
+
+        # Create a test image
+        param = Gauss2DParam.create(height=200, width=200, sigma=20)
+        img = create_image_from_param(param)
+        panel.add_object(img)
+
+        # Run centroid analysis to create results and store analysis parameters
+        execenv.print("  Running centroid analysis...")
+        with Conf.proc.show_result_dialog.temp(False):
+            panel.processor.run_feature("centroid")
+
+        # Verify that analysis parameters exist
+        img_refreshed = panel.objmodel[get_uuid(img)]
+        analysis_params = extract_analysis_parameters(img_refreshed)
+        assert analysis_params is not None, (
+            "Analysis parameters should exist after running centroid"
+        )
+        assert analysis_params.func_name == "centroid", (
+            "Analysis parameters should store the centroid function name"
+        )
+        execenv.print("  ✓ Analysis parameters stored")
+
+        # Delete all results
+        execenv.print("  Deleting all results...")
+        panel.objview.select_objects([get_uuid(img)])
+        panel.delete_results()
+
+        # Verify that analysis parameters were also cleared
+        img_after = panel.objmodel[get_uuid(img)]
+        analysis_params_after = extract_analysis_parameters(img_after)
+        assert analysis_params_after is None, (
+            "Analysis parameters should be cleared after deleting results"
+        )
+        execenv.print("  ✓ Analysis parameters cleared")
+
+        # Now add a ROI and verify no auto-recompute happens (no new results)
+        execenv.print("  Adding ROI to verify no auto-recompute...")
+        roi = create_image_roi("rectangle", [25, 25, 100, 100])
+        img_after.roi = roi
+        panel.processor.auto_recompute_analysis(img_after)
+
+        # Verify that no new results were created
+        adapter_after_roi = GeometryAdapter.from_obj(img_after, "centroid")
+        assert adapter_after_roi is None, (
+            "No centroid result should be created after ROI change "
+            "because analysis parameters were cleared"
+        )
+        execenv.print(
+            "  ✓ No auto-recompute after ROI change (analysis params cleared)"
+        )
+        execenv.print("\n✓ All tests passed!")
+
+
 if __name__ == "__main__":
     test_delete_results_image()
     test_delete_results_signal()
+    test_delete_results_clears_analysis_parameters()

doc/locale/fr/LC_MESSAGES/release_notes/release_1.00.po

@@ -7,7 +7,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: DataLab \n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2025-12-16 10:16+0100\n"
+"POT-Creation-Date: 2025-12-16 10:56+0100\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language: fr\n"
@@ -27,6 +27,21 @@ msgstr ""
 msgid "🛠️ Bug Fixes since version 1.0.2"
 msgstr "🛠️ Correctifs depuis la version 1.0.2"
 
+msgid "**Analysis auto-recompute - Stale parameters after deleting results:**"
+msgstr "**Recalcul automatique de l'analyse - Paramètres obsolètes après suppression des résultats :**"
+
+msgid "Fixed analysis parameters not being cleared when deleting analysis results, which could cause unexpected auto-recompute behavior when modifying ROIs"
+msgstr "Correction des paramètres d'analyse qui n'étaient pas effacés lors de la suppression des résultats, ce qui pouvait provoquer un comportement de recalcul automatique inattendu lors de la modification des ROI"
+
+msgid "After deleting results (via \"Delete all results\" or individual result deletion), changing the ROI would trigger recomputation of the deleted analysis because the stored parameters remained in object metadata"
+msgstr "Après la suppression des résultats (via « Supprimer tous les résultats » ou suppression individuelle), la modification de la ROI déclenchait le recalcul de l'analyse supprimée car les paramètres restaient dans les métadonnées de l'objet"
+
+msgid "The fix ensures analysis parameters are properly cleared alongside the results, preventing unwanted automatic recomputation"
+msgstr "Le correctif assure que les paramètres d'analyse sont correctement effacés avec les résultats, empêchant le recalcul automatique indésirable"
+
+msgid "This closes [Issue #285](https://github.com/DataLab-Platform/DataLab/issues/285) - Analysis parameters not cleared after deleting results"
+msgstr "Ceci clôture [Issue #285](https://github.com/datalab-platform/datalab/issues/285) - Analysis parameters not cleared after deleting results"
+
 msgid "**Backwards-drawn rectangular ROI causes NaN statistics:**"
 msgstr "**ROI rectangulaire dessinée à l'envers cause des statistiques NaN :**"
 

doc/release_notes/release_1.00.md

@@ -4,6 +4,13 @@
 
 ### 🛠️ Bug Fixes since version 1.0.2 ###
 
+**Analysis auto-recompute - Stale parameters after deleting results:**
+
+* Fixed analysis parameters not being cleared when deleting analysis results, which could cause unexpected auto-recompute behavior when modifying ROIs
+* After deleting results (via "Delete all results" or individual result deletion), changing the ROI would trigger recomputation of the deleted analysis because the stored parameters remained in object metadata
+* The fix ensures analysis parameters are properly cleared alongside the results, preventing unwanted automatic recomputation
+* This closes [Issue #285](https://github.com/DataLab-Platform/DataLab/issues/285) - Analysis parameters not cleared after deleting results
+
 **Backwards-drawn rectangular ROI causes NaN statistics:**
 
 * Fixed rectangular ROI statistics returning NaN values when the ROI was drawn "backwards" (from bottom-right to top-left instead of top-left to bottom-right)