-
Notifications
You must be signed in to change notification settings - Fork 468
ci: fix flaky test_partial_flush_log stdout #15285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 221 ± 3 ms. The average import time from base is: 225 ± 3 ms. The import time difference between this PR and base is: -4.4 ± 0.1 ms. Import time breakdownThe following import paths have grown:
|
Performance SLOsComparing candidate brettlangdon/improve.flaky.test (2905f3b) with baseline main (15cd5b6) 📈 Performance Regressions (2 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.402µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -1.5% Memory: ✅ 39.341MB (SLO: <41.500MB -5.2%) vs baseline: +4.5% ✅ add_inplace_aspectTime: ✅ 0.409µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.8% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +4.7% ✅ add_inplace_noaspectTime: ✅ 0.320µs (SLO: <10.000µs 📉 -96.8%) vs baseline: +0.7% Memory: ✅ 39.400MB (SLO: <41.500MB -5.1%) vs baseline: +5.0% ✅ add_noaspectTime: ✅ 0.276µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -0.4% Memory: ✅ 39.518MB (SLO: <41.500MB -4.8%) vs baseline: +5.2% ✅ bytearray_aspectTime: ✅ 1.315µs (SLO: <10.000µs 📉 -86.9%) vs baseline: ~same Memory: ✅ 39.400MB (SLO: <41.500MB -5.1%) vs baseline: +4.6% ✅ bytearray_extend_aspectTime: ✅ 1.542µs (SLO: <10.000µs 📉 -84.6%) vs baseline: -0.4% Memory: ✅ 39.381MB (SLO: <41.500MB -5.1%) vs baseline: +5.0% ✅ bytearray_extend_noaspectTime: ✅ 0.618µs (SLO: <10.000µs 📉 -93.8%) vs baseline: +1.3% Memory: ✅ 39.381MB (SLO: <41.500MB -5.1%) vs baseline: +4.6% ✅ bytearray_noaspectTime: ✅ 0.481µs (SLO: <10.000µs 📉 -95.2%) vs baseline: +0.1% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +5.3% ✅ bytes_aspectTime: ✅ 1.457µs (SLO: <10.000µs 📉 -85.4%) vs baseline: 📈 +13.7% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +4.9% ✅ bytes_noaspectTime: ✅ 0.495µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.6% Memory: ✅ 39.538MB (SLO: <41.500MB -4.7%) vs baseline: +5.0% ✅ bytesio_aspectTime: ✅ 1.323µs (SLO: <10.000µs 📉 -86.8%) vs baseline: +0.6% Memory: ✅ 39.361MB (SLO: <41.500MB -5.2%) vs baseline: +4.8% ✅ bytesio_noaspectTime: ✅ 0.496µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -1.1% Memory: ✅ 39.381MB (SLO: <41.500MB -5.1%) vs baseline: +4.8% ✅ capitalize_aspectTime: ✅ 0.736µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.5% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +4.9% ✅ capitalize_noaspectTime: ✅ 0.431µs (SLO: <10.000µs 📉 -95.7%) vs baseline: -0.6% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +5.0% ✅ casefold_aspectTime: ✅ 0.732µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -1.0% Memory: ✅ 39.420MB (SLO: <41.500MB -5.0%) vs baseline: +4.9% ✅ casefold_noaspectTime: ✅ 0.367µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.9% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +4.9% ✅ decode_aspectTime: ✅ 0.724µs (SLO: <10.000µs 📉 -92.8%) vs baseline: ~same Memory: ✅ 39.420MB (SLO: <41.500MB -5.0%) vs baseline: +5.1% ✅ decode_noaspectTime: ✅ 0.424µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +1.2% Memory: ✅ 39.499MB (SLO: <41.500MB -4.8%) vs baseline: +4.8% ✅ encode_aspectTime: ✅ 0.709µs (SLO: <10.000µs 📉 -92.9%) vs baseline: -0.4% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +4.6% ✅ encode_noaspectTime: ✅ 0.404µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +0.4% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +5.3% ✅ format_aspectTime: ✅ 3.403µs (SLO: <10.000µs 📉 -66.0%) vs baseline: +4.3% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +5.1% ✅ format_map_aspectTime: ✅ 3.455µs (SLO: <10.000µs 📉 -65.5%) vs baseline: +0.6% Memory: ✅ 39.617MB (SLO: <41.500MB -4.5%) vs baseline: +5.3% ✅ format_map_noaspectTime: ✅ 0.775µs (SLO: <10.000µs 📉 -92.2%) vs baseline: ~same Memory: ✅ 39.341MB (SLO: <41.500MB -5.2%) vs baseline: +4.6% ✅ format_noaspectTime: ✅ 0.590µs (SLO: <10.000µs 📉 -94.1%) vs baseline: -0.2% Memory: ✅ 39.400MB (SLO: <41.500MB -5.1%) vs baseline: +4.7% ✅ index_aspectTime: ✅ 0.357µs (SLO: <10.000µs 📉 -96.4%) vs baseline: +0.7% Memory: ✅ 39.420MB (SLO: <41.500MB -5.0%) vs baseline: +4.6% ✅ index_noaspectTime: ✅ 0.276µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -0.1% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +4.9% ✅ join_aspectTime: ✅ 1.445µs (SLO: <10.000µs 📉 -85.5%) vs baseline: +3.7% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +4.9% ✅ join_noaspectTime: ✅ 0.487µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.5% Memory: ✅ 39.361MB (SLO: <41.500MB -5.2%) vs baseline: +4.8% ✅ ljust_aspectTime: ✅ 2.463µs (SLO: <20.000µs 📉 -87.7%) vs baseline: -0.7% Memory: ✅ 39.381MB (SLO: <41.500MB -5.1%) vs baseline: +4.7% ✅ ljust_noaspectTime: ✅ 0.407µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +1.0% Memory: ✅ 39.381MB (SLO: <41.500MB -5.1%) vs baseline: +5.0% ✅ lower_aspectTime: ✅ 2.265µs (SLO: <10.000µs 📉 -77.4%) vs baseline: +4.7% Memory: ✅ 39.577MB (SLO: <41.500MB -4.6%) vs baseline: +4.9% ✅ lower_noaspectTime: ✅ 0.367µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.2% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +5.1% ✅ lstrip_aspectTime: ✅ 2.490µs (SLO: <20.000µs 📉 -87.6%) vs baseline: 📈 +12.8% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +5.0% ✅ lstrip_noaspectTime: ✅ 0.382µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.2% Memory: ✅ 39.400MB (SLO: <41.500MB -5.1%) vs baseline: +4.6% ✅ modulo_aspectTime: ✅ 1.054µs (SLO: <10.000µs 📉 -89.5%) vs baseline: +0.9% Memory: ✅ 39.577MB (SLO: <41.500MB -4.6%) vs baseline: +5.3% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.599µs (SLO: <10.000µs 📉 -84.0%) vs baseline: +3.5% Memory: ✅ 39.617MB (SLO: <41.500MB -4.5%) vs baseline: +5.1% ✅ modulo_aspect_for_bytesTime: ✅ 0.966µs (SLO: <10.000µs 📉 -90.3%) vs baseline: -1.1% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +5.1% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.304µs (SLO: <10.000µs 📉 -87.0%) vs baseline: +5.4% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +5.1% ✅ modulo_noaspectTime: ✅ 0.631µs (SLO: <10.000µs 📉 -93.7%) vs baseline: +1.1% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +5.0% ✅ replace_aspectTime: ✅ 5.287µs (SLO: <10.000µs 📉 -47.1%) vs baseline: +9.5% Memory: ✅ 39.499MB (SLO: <41.500MB -4.8%) vs baseline: +4.9% ✅ replace_noaspectTime: ✅ 0.462µs (SLO: <10.000µs 📉 -95.4%) vs baseline: +0.4% Memory: ✅ 39.361MB (SLO: <41.500MB -5.2%) vs baseline: +4.8% ✅ repr_aspectTime: ✅ 0.905µs (SLO: <10.000µs 📉 -90.9%) vs baseline: -0.2% Memory: ✅ 39.361MB (SLO: <41.500MB -5.2%) vs baseline: +4.6% ✅ repr_noaspectTime: ✅ 0.415µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +0.2% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +5.1% ✅ rstrip_aspectTime: ✅ 1.887µs (SLO: <20.000µs 📉 -90.6%) vs baseline: +1.7% Memory: ✅ 39.499MB (SLO: <41.500MB -4.8%) vs baseline: +4.9% ✅ rstrip_noaspectTime: ✅ 0.380µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +1.1% Memory: ✅ 39.499MB (SLO: <41.500MB -4.8%) vs baseline: +5.1% ✅ slice_aspectTime: ✅ 0.492µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.2% Memory: ✅ 39.341MB (SLO: <41.500MB -5.2%) vs baseline: +4.6% ✅ slice_noaspectTime: ✅ 0.448µs (SLO: <10.000µs 📉 -95.5%) vs baseline: ~same Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +5.0% ✅ stringio_aspectTime: ✅ 1.670µs (SLO: <10.000µs 📉 -83.3%) vs baseline: +9.4% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +5.0% ✅ stringio_noaspectTime: ✅ 0.719µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +0.5% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +5.0% ✅ strip_aspectTime: ✅ 2.194µs (SLO: <20.000µs 📉 -89.0%) vs baseline: ~same Memory: ✅ 39.302MB (SLO: <41.500MB -5.3%) vs baseline: +4.4% ✅ strip_noaspectTime: ✅ 0.381µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.4% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +5.1% ✅ swapcase_aspectTime: ✅ 2.493µs (SLO: <10.000µs 📉 -75.1%) vs baseline: +5.1% Memory: ✅ 39.420MB (SLO: <41.500MB -5.0%) vs baseline: +5.1% ✅ swapcase_noaspectTime: ✅ 0.534µs (SLO: <10.000µs 📉 -94.7%) vs baseline: +0.4% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +5.0% ✅ title_aspectTime: ✅ 2.296µs (SLO: <10.000µs 📉 -77.0%) vs baseline: -0.1% Memory: ✅ 39.420MB (SLO: <41.500MB -5.0%) vs baseline: +4.7% ✅ title_noaspectTime: ✅ 0.497µs (SLO: <10.000µs 📉 -95.0%) vs baseline: ~same Memory: ✅ 39.381MB (SLO: <41.500MB -5.1%) vs baseline: +4.6% ✅ translate_aspectTime: ✅ 3.159µs (SLO: <10.000µs 📉 -68.4%) vs baseline: +0.3% Memory: ✅ 39.302MB (SLO: <41.500MB -5.3%) vs baseline: +4.7% ✅ translate_noaspectTime: ✅ 1.038µs (SLO: <10.000µs 📉 -89.6%) vs baseline: +0.2% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +5.2% ✅ upper_aspectTime: ✅ 2.181µs (SLO: <10.000µs 📉 -78.2%) vs baseline: +0.5% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +4.9% ✅ upper_noaspectTime: ✅ 0.371µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.3% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +5.2% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.311µs (SLO: <10.000µs 📉 -56.9%) vs baseline: +1.3% Memory: ✅ 39.833MB (SLO: <41.000MB -2.8%) vs baseline: +4.9% ✅ ospathbasename_noaspectTime: ✅ 1.091µs (SLO: <10.000µs 📉 -89.1%) vs baseline: +0.3% Memory: ✅ 39.793MB (SLO: <41.000MB -2.9%) vs baseline: +4.8% ✅ ospathjoin_aspectTime: ✅ 6.220µs (SLO: <10.000µs 📉 -37.8%) vs baseline: +0.5% Memory: ✅ 39.793MB (SLO: <41.000MB -2.9%) vs baseline: +4.9% ✅ ospathjoin_noaspectTime: ✅ 2.302µs (SLO: <10.000µs 📉 -77.0%) vs baseline: +0.3% Memory: ✅ 39.833MB (SLO: <41.000MB -2.8%) vs baseline: +4.9% ✅ ospathnormcase_aspectTime: ✅ 3.527µs (SLO: <10.000µs 📉 -64.7%) vs baseline: -1.4% Memory: ✅ 39.813MB (SLO: <41.000MB -2.9%) vs baseline: +5.0% ✅ ospathnormcase_noaspectTime: ✅ 0.572µs (SLO: <10.000µs 📉 -94.3%) vs baseline: +0.6% Memory: ✅ 39.872MB (SLO: <41.000MB -2.8%) vs baseline: +5.0% ✅ ospathsplit_aspectTime: ✅ 4.834µs (SLO: <10.000µs 📉 -51.7%) vs baseline: +0.3% Memory: ✅ 39.813MB (SLO: <41.000MB -2.9%) vs baseline: +4.9% ✅ ospathsplit_noaspectTime: ✅ 1.603µs (SLO: <10.000µs 📉 -84.0%) vs baseline: +1.0% Memory: ✅ 39.931MB (SLO: <41.000MB -2.6%) vs baseline: +5.2% ✅ ospathsplitdrive_aspectTime: ✅ 4.130µs (SLO: <10.000µs 📉 -58.7%) vs baseline: 📈 +10.2% Memory: ✅ 39.852MB (SLO: <41.000MB -2.8%) vs baseline: +4.6% ✅ ospathsplitdrive_noaspectTime: ✅ 0.702µs (SLO: <10.000µs 📉 -93.0%) vs baseline: +0.4% Memory: ✅ 39.892MB (SLO: <41.000MB -2.7%) vs baseline: +4.9% ✅ ospathsplitext_aspectTime: ✅ 4.600µs (SLO: <10.000µs 📉 -54.0%) vs baseline: -0.3% Memory: ✅ 39.813MB (SLO: <41.000MB -2.9%) vs baseline: +5.0% ✅ ospathsplitext_noaspectTime: ✅ 1.379µs (SLO: <10.000µs 📉 -86.2%) vs baseline: +0.4% Memory: ✅ 39.911MB (SLO: <41.000MB -2.7%) vs baseline: +5.0% 🟡 Near SLO Breach (2 suites)🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.584ms (SLO: <4.750ms -3.5%) vs baseline: ~same Memory: ✅ 64.105MB (SLO: <66.500MB -3.6%) vs baseline: +5.0% ✅ appsec-postTime: ✅ 6.629ms (SLO: <6.750ms 🟡 -1.8%) vs baseline: +0.1% Memory: ✅ 64.222MB (SLO: <66.500MB -3.4%) vs baseline: +5.1% ✅ appsec-telemetryTime: ✅ 4.599ms (SLO: <4.750ms -3.2%) vs baseline: +0.3% Memory: ✅ 63.963MB (SLO: <66.500MB -3.8%) vs baseline: +4.7% ✅ debuggerTime: ✅ 1.852ms (SLO: <2.000ms -7.4%) vs baseline: ~same Memory: ✅ 47.868MB (SLO: <49.500MB -3.3%) vs baseline: +4.8% ✅ iast-getTime: ✅ 1.860ms (SLO: <2.000ms -7.0%) vs baseline: +0.3% Memory: ✅ 44.458MB (SLO: <49.000MB -9.3%) vs baseline: +5.0% ✅ profilerTime: ✅ 1.931ms (SLO: <2.100ms -8.0%) vs baseline: +0.4% Memory: ✅ 48.680MB (SLO: <50.000MB -2.6%) vs baseline: +4.8% ✅ resource-renamingTime: ✅ 3.375ms (SLO: <3.650ms -7.5%) vs baseline: -0.1% Memory: ✅ 54.300MB (SLO: <56.000MB -3.0%) vs baseline: +4.8% ✅ tracerTime: ✅ 3.365ms (SLO: <3.650ms -7.8%) vs baseline: +0.2% Memory: ✅ 54.243MB (SLO: <56.500MB -4.0%) vs baseline: +4.7% ✅ tracer-nativeTime: ✅ 3.360ms (SLO: <3.650ms -7.9%) vs baseline: +0.1% Memory: ✅ 54.281MB (SLO: <60.000MB -9.5%) vs baseline: +4.7% 🟡 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.022µs (SLO: <20.000µs 📉 -84.9%) vs baseline: +0.9% Memory: ✅ 34.465MB (SLO: <35.500MB -2.9%) vs baseline: +4.6% ✅ 1-count-metrics-100-timesTime: ✅ 199.295µs (SLO: <220.000µs -9.4%) vs baseline: -1.7% Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +5.2% ✅ 1-distribution-metric-1-timesTime: ✅ 3.427µs (SLO: <20.000µs 📉 -82.9%) vs baseline: +2.3% Memory: ✅ 34.446MB (SLO: <35.500MB -3.0%) vs baseline: +4.7% ✅ 1-distribution-metrics-100-timesTime: ✅ 218.663µs (SLO: <220.000µs 🟡 -0.6%) vs baseline: -0.1% Memory: ✅ 34.505MB (SLO: <35.500MB -2.8%) vs baseline: +4.7% ✅ 1-gauge-metric-1-timesTime: ✅ 2.186µs (SLO: <20.000µs 📉 -89.1%) vs baseline: -1.1% Memory: ✅ 34.485MB (SLO: <35.500MB -2.9%) vs baseline: +4.8% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.677µs (SLO: <150.000µs -8.9%) vs baseline: -0.3% Memory: ✅ 34.446MB (SLO: <35.500MB -3.0%) vs baseline: +4.6% ✅ 1-rate-metric-1-timesTime: ✅ 3.117µs (SLO: <20.000µs 📉 -84.4%) vs baseline: +0.2% Memory: ✅ 34.465MB (SLO: <35.500MB -2.9%) vs baseline: +4.6% ✅ 1-rate-metrics-100-timesTime: ✅ 212.783µs (SLO: <250.000µs 📉 -14.9%) vs baseline: -1.5% Memory: ✅ 34.485MB (SLO: <35.500MB -2.9%) vs baseline: +4.7% ✅ 100-count-metrics-100-timesTime: ✅ 20.186ms (SLO: <22.000ms -8.2%) vs baseline: +0.4% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +5.0% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.255ms (SLO: <2.300ms 🟡 -2.0%) vs baseline: -1.6% Memory: ✅ 34.564MB (SLO: <35.500MB -2.6%) vs baseline: +4.8% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.418ms (SLO: <1.550ms -8.5%) vs baseline: +1.1% Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.201ms (SLO: <2.550ms 📉 -13.7%) vs baseline: ~same Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +4.9% ✅ flush-1-metricTime: ✅ 4.694µs (SLO: <20.000µs 📉 -76.5%) vs baseline: +1.5% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +4.8% ✅ flush-100-metricsTime: ✅ 175.213µs (SLO: <250.000µs 📉 -29.9%) vs baseline: +0.4% Memory: ✅ 34.485MB (SLO: <35.500MB -2.9%) vs baseline: +4.7% ✅ flush-1000-metricsTime: ✅ 2.125ms (SLO: <2.500ms 📉 -15.0%) vs baseline: +0.2% Memory: ✅ 35.311MB (SLO: <36.500MB -3.3%) vs baseline: +4.9%
|
|
I realized, a better way is probably just to set Since the tests is already validating a specific log is happening, we don't really need to care about any of the other logs. I'll update next week to fix. |
238fa47 to
40938af
Compare
Description
Attempt to address the flaky test
test_partial_flush_logThis is just a race condition with flushing and logging, it is safe to ignore.
Testing
Risks
Additional Notes