Skip to content

Commit f82a7d2

Browse files
committed
review
1 parent e63db2d commit f82a7d2

File tree

1 file changed

+20
-37
lines changed

1 file changed

+20
-37
lines changed

tests/debugging/test_encoding.py

Lines changed: 20 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -271,50 +271,33 @@ def test_process_tags_are_not_included_by_default():
271271

272272

273273
def test_process_tags_are_included():
274-
from unittest.mock import patch
275-
276-
from ddtrace.internal.process_tags import _process_tag_reload
277-
from ddtrace.internal.process_tags.constants import ENTRYPOINT_BASEDIR_TAG
278-
from ddtrace.internal.process_tags.constants import ENTRYPOINT_NAME_TAG
279-
from ddtrace.internal.process_tags.constants import ENTRYPOINT_TYPE_SCRIPT
280-
from ddtrace.internal.process_tags.constants import ENTRYPOINT_TYPE_TAG
281-
from ddtrace.internal.process_tags.constants import ENTRYPOINT_WORKDIR_TAG
282-
from ddtrace.settings._config import config
274+
from ddtrace.internal.settings._config import config
275+
from tests.utils import process_tag_reload
283276

284277
try:
285-
with patch("sys.argv", ["/path/to/test_script.py"]), patch("os.getcwd", return_value="/path/to/workdir"):
286-
config._process_tags_enabled = True
287-
_process_tag_reload()
288-
s = Snapshot(
289-
probe=create_snapshot_line_probe(probe_id="batch-test", source_file="foo.py", line=42),
290-
frame=inspect.currentframe(),
291-
thread=threading.current_thread(),
292-
)
293-
buffer_size = 30 * (1 << 20)
294-
queue = SignalQueue(encoder=LogSignalJsonEncoder(None), buffer_size=buffer_size)
278+
config._process_tags_enabled = True
279+
process_tag_reload()
280+
s = Snapshot(
281+
probe=create_snapshot_line_probe(probe_id="batch-test", source_file="foo.py", line=42),
282+
frame=inspect.currentframe(),
283+
thread=threading.current_thread(),
284+
)
285+
buffer_size = 30 * (1 << 20)
286+
queue = SignalQueue(encoder=LogSignalJsonEncoder(None), buffer_size=buffer_size)
295287

296-
s.line({})
288+
s.line({})
297289

298-
queue = SignalQueue(encoder=LogSignalJsonEncoder("test-service"))
299-
queue.put(s)
300-
data = queue.flush()
301-
assert data is not None
302-
payload, _ = data
303-
decoded = json.loads(payload.decode())
304-
305-
assert "process_tags" in decoded[0]
306-
307-
expected_raw = (
308-
f"{ENTRYPOINT_BASEDIR_TAG}:to,"
309-
f"{ENTRYPOINT_NAME_TAG}:test_script,"
310-
f"{ENTRYPOINT_TYPE_TAG}:{ENTRYPOINT_TYPE_SCRIPT},"
311-
f"{ENTRYPOINT_WORKDIR_TAG}:workdir"
312-
)
290+
queue = SignalQueue(encoder=LogSignalJsonEncoder("test-service"))
291+
queue.put(s)
292+
data = queue.flush()
293+
assert data is not None
294+
payload, _ = data
295+
decoded = json.loads(payload.decode())
313296

314-
assert decoded[0]["process_tags"] == expected_raw
297+
assert "process_tags" in decoded[0]
315298
finally:
316299
config._process_tags_enabled = False
317-
_process_tag_reload()
300+
process_tag_reload()
318301

319302

320303
def test_batch_flush_reencode():

0 commit comments

Comments
 (0)