Skip to content

Commit 0795f26

Browse files
committed
review
1 parent 515903a commit 0795f26

File tree

1 file changed

+4
-20
lines changed

1 file changed

+4
-20
lines changed

tests/debugging/test_encoding.py

Lines changed: 4 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -271,20 +271,13 @@ def test_process_tags_are_not_included_by_default():
271271

272272

273273
def test_process_tags_are_included():
274-
from unittest.mock import patch
275274

276-
from ddtrace.internal.process_tags import _process_tag_reload
277-
from ddtrace.internal.process_tags.constants import ENTRYPOINT_BASEDIR_TAG
278-
from ddtrace.internal.process_tags.constants import ENTRYPOINT_NAME_TAG
279-
from ddtrace.internal.process_tags.constants import ENTRYPOINT_TYPE_SCRIPT
280-
from ddtrace.internal.process_tags.constants import ENTRYPOINT_TYPE_TAG
281-
from ddtrace.internal.process_tags.constants import ENTRYPOINT_WORKDIR_TAG
282-
from ddtrace.settings._config import config
275+
from tests.utils import process_tag_reload
276+
from ddtrace.internal.settings._config import config
283277

284278
try:
285-
with patch("sys.argv", ["/path/to/test_script.py"]), patch("os.getcwd", return_value="/path/to/workdir"):
286279
config._process_tags_enabled = True
287-
_process_tag_reload()
280+
process_tag_reload()
288281
s = Snapshot(
289282
probe=create_snapshot_line_probe(probe_id="batch-test", source_file="foo.py", line=42),
290283
frame=inspect.currentframe(),
@@ -303,18 +296,9 @@ def test_process_tags_are_included():
303296
decoded = json.loads(payload.decode())
304297

305298
assert "process_tags" in decoded[0]
306-
307-
expected_raw = (
308-
f"{ENTRYPOINT_BASEDIR_TAG}:to,"
309-
f"{ENTRYPOINT_NAME_TAG}:test_script,"
310-
f"{ENTRYPOINT_TYPE_TAG}:{ENTRYPOINT_TYPE_SCRIPT},"
311-
f"{ENTRYPOINT_WORKDIR_TAG}:workdir"
312-
)
313-
314-
assert decoded[0]["process_tags"] == expected_raw
315299
finally:
316300
config._process_tags_enabled = False
317-
_process_tag_reload()
301+
process_tag_reload()
318302

319303

320304
def test_batch_flush_reencode():

0 commit comments

Comments
 (0)