Skip to content

Commit 957638a

Browse files
committed
Address review comments
1 parent c52f728 commit 957638a

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

packages/dd-trace/src/debugger/devtools_client/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ session.on('Debugger.paused', async ({ params }) => {
216216
}
217217

218218
if (probe.captureSnapshot) {
219-
if (captureErrors.length > 0) {
219+
if (captureErrors?.length > 0) {
220220
// There was an error collecting the snapshot for this probe, let's not try again
221221
probe.captureSnapshot = false
222222
probe.permanentEvaluationErrors = captureErrors.map(error => ({

packages/dd-trace/src/debugger/devtools_client/snapshot/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ async function getLocalStateForCallFrame (
6969
{ cause: err } // TODO: The cause is not used by the backend
7070
))
7171
}
72-
if (opts.ctx.deadlineReached === true) break // TODO: Bad UX; Variables in remaining scopes are silently dropped
72+
if (ctx.deadlineReached === true) break // TODO: Bad UX; Variables in remaining scopes are silently dropped
7373
}
7474

7575
// Delay calling `processRawState` so the caller gets a chance to resume the main thread before processing `rawState`

0 commit comments

Comments
 (0)