chore: Readability of CallSiteUtils::toURL

Author: bric3

buildSrc/.kotlin/sessions/kotlin-compiler-1497087473482789025.salive

@@ -3,6 +3,7 @@
 import java.io.File;
 import java.net.MalformedURLException;
 import java.net.URL;
+import java.nio.file.Files;
 import java.nio.file.Path;
 import java.util.stream.Collectors;
 import java.util.stream.IntStream;
@@ -48,9 +49,13 @@ public static String repeat(final char value, int count) {
   public static URL toURL(final Path path) {
     try {
       URL url = path.toUri().toURL();
-      // There's a subtle detail where `URLClassLoader` requires directory URLs to end with '/',
-      // otherwise they are assimilated to jar file, and vice versa.
-      if (path.toFile().isDirectory() || !path.toString().endsWith(".jar")) {
+      // URLClassLoader interprets URLs ending with '/' as directories. If the trailing '/' is
+      // missing, a directory URL is treated as a JAR. If the path does yet exist on disk
+      // assumes that paths not ending with ".jar" are directories.
+      boolean shouldAddSlash =
+          Files.exists(path) ? Files.isDirectory(path) : !path.toString().endsWith(".jar");
+
+      if (shouldAddSlash) {
         String urlString = url.toString();
         if (!urlString.endsWith("/")) {
           url = new URL(urlString + "/");

buildSrc/call-site-instrumentation-plugin/src/main/java/datadog/trace/plugin/csi/util/CallSiteUtils.java

@@ -1,7 +1,5 @@
 package datadog.gradle.plugin.csi
 
-import org.gradle.api.Project
-import org.gradle.api.artifacts.Configuration
 import org.gradle.api.file.ConfigurableFileCollection
 import org.gradle.api.file.DirectoryProperty
 import org.gradle.api.file.ProjectLayout
@@ -19,7 +17,6 @@ import javax.inject.Inject
  * This extension allows to configure the Call Site Instrumenter plugin execution.
  */
 abstract class CallSiteInstrumentationExtension @Inject constructor(
-  project: Project,
   objectFactory: ObjectFactory,
   layout: ProjectLayout
 ) {