Skip to content

Commit 85d8580

Browse files
authored
Fix client stats payload (#9743)
1 parent 6dc3f85 commit 85d8580

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

dd-trace-core/src/main/java/datadog/trace/common/metrics/SerializingMetricWriter.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212

1313
public final class SerializingMetricWriter implements MetricWriter {
1414

15-
private static final byte[] SEQUENCE = "Seq".getBytes(ISO_8859_1);
16-
private static final byte[] RUNTIME_ID = "RuntimeId".getBytes(ISO_8859_1);
15+
private static final byte[] SEQUENCE = "Sequence".getBytes(ISO_8859_1);
16+
private static final byte[] RUNTIME_ID = "RuntimeID".getBytes(ISO_8859_1);
1717
private static final byte[] HOSTNAME = "Hostname".getBytes(ISO_8859_1);
1818
private static final byte[] NAME = "Name".getBytes(ISO_8859_1);
1919
private static final byte[] ENV = "Env".getBytes(ISO_8859_1);
@@ -61,7 +61,7 @@ public SerializingMetricWriter(WellKnownTags wellKnownTags, Sink sink, int initi
6161
public void startBucket(int metricCount, long start, long duration) {
6262
final UTF8BytesString processTags = ProcessTags.getTagsForSerialization();
6363
final boolean writeProcessTags = processTags != null;
64-
writer.startMap(6 + (writeProcessTags ? 1 : 0));
64+
writer.startMap(7 + (writeProcessTags ? 1 : 0));
6565

6666
writer.writeUTF8(RUNTIME_ID);
6767
writer.writeUTF8(wellKnownTags.getRuntimeId());
@@ -72,6 +72,9 @@ public void startBucket(int metricCount, long start, long duration) {
7272
writer.writeUTF8(HOSTNAME);
7373
writer.writeUTF8(wellKnownTags.getHostname());
7474

75+
writer.writeUTF8(SERVICE);
76+
writer.writeUTF8(wellKnownTags.getService());
77+
7578
writer.writeUTF8(ENV);
7679
writer.writeUTF8(wellKnownTags.getEnv());
7780

dd-trace-core/src/test/groovy/datadog/trace/common/metrics/SerializingMetricWriterTest.groovy

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,13 +125,15 @@ class SerializingMetricWriterTest extends DDSpecification {
125125
void accept(int messageCount, ByteBuffer buffer) {
126126
MessageUnpacker unpacker = MessagePack.newDefaultUnpacker(buffer)
127127
int mapSize = unpacker.unpackMapHeader()
128-
assert mapSize == (6 + (Config.get().isExperimentalPropagateProcessTagsEnabled() ? 1 : 0))
129-
assert unpacker.unpackString() == "RuntimeId"
128+
assert mapSize == (7 + (Config.get().isExperimentalPropagateProcessTagsEnabled() ? 1 : 0))
129+
assert unpacker.unpackString() == "RuntimeID"
130130
assert unpacker.unpackString() == wellKnownTags.getRuntimeId() as String
131-
assert unpacker.unpackString() == "Seq"
131+
assert unpacker.unpackString() == "Sequence"
132132
assert unpacker.unpackLong() == 0L
133133
assert unpacker.unpackString() == "Hostname"
134134
assert unpacker.unpackString() == wellKnownTags.getHostname() as String
135+
assert unpacker.unpackString() == "Service"
136+
assert unpacker.unpackString() == wellKnownTags.getService() as String
135137
assert unpacker.unpackString() == "Env"
136138
assert unpacker.unpackString() == wellKnownTags.getEnv() as String
137139
assert unpacker.unpackString() == "Version"

0 commit comments

Comments
 (0)