|
7 | 7 | from datadog_lambda.durable import ( |
8 | 8 | _parse_durable_execution_arn, |
9 | 9 | extract_durable_function_tags, |
10 | | - extract_durable_function_status_tag, |
| 10 | + extract_durable_execution_status, |
11 | 11 | ) |
12 | 12 |
|
13 | 13 |
|
@@ -92,63 +92,49 @@ def test_returns_empty_dict_when_event_is_empty(self): |
92 | 92 | self.assertEqual(result, {}) |
93 | 93 |
|
94 | 94 |
|
95 | | -class TestExtractDurableFunctionStatusTag(unittest.TestCase): |
96 | | - def test_succeeded_status(self): |
97 | | - event = {"DurableExecutionArn": "arn:aws:states:us-east-1:123456789012:..."} |
| 95 | +class TestExtractDurableExecutionStatus(unittest.TestCase): |
| 96 | + def test_returns_succeeded(self): |
| 97 | + event = {"DurableExecutionArn": "arn:aws:lambda:us-east-1:123:function:f:1/durable-execution/n/id"} |
98 | 98 | response = {"Status": "SUCCEEDED", "Result": "some-result"} |
99 | | - result = extract_durable_function_status_tag(response, event) |
100 | | - self.assertEqual(result, {"durable_function_execution_status": "SUCCEEDED"}) |
| 99 | + self.assertEqual(extract_durable_execution_status(response, event), "SUCCEEDED") |
101 | 100 |
|
102 | | - def test_failed_status(self): |
103 | | - event = {"DurableExecutionArn": "arn:aws:states:us-east-1:123456789012:..."} |
| 101 | + def test_returns_failed(self): |
| 102 | + event = {"DurableExecutionArn": "arn:aws:lambda:us-east-1:123:function:f:1/durable-execution/n/id"} |
104 | 103 | response = {"Status": "FAILED", "Error": "some-error"} |
105 | | - result = extract_durable_function_status_tag(response, event) |
106 | | - self.assertEqual(result, {"durable_function_execution_status": "FAILED"}) |
| 104 | + self.assertEqual(extract_durable_execution_status(response, event), "FAILED") |
107 | 105 |
|
108 | | - def test_pending_status(self): |
109 | | - event = {"DurableExecutionArn": "arn:aws:states:us-east-1:123456789012:..."} |
| 106 | + def test_returns_pending(self): |
| 107 | + event = {"DurableExecutionArn": "arn:aws:lambda:us-east-1:123:function:f:1/durable-execution/n/id"} |
110 | 108 | response = {"Status": "PENDING"} |
111 | | - result = extract_durable_function_status_tag(response, event) |
112 | | - self.assertEqual(result, {"durable_function_execution_status": "PENDING"}) |
| 109 | + self.assertEqual(extract_durable_execution_status(response, event), "PENDING") |
113 | 110 |
|
114 | | - def test_non_durable_event_returns_empty(self): |
115 | | - event = {"key": "value"} # No DurableExecutionArn |
| 111 | + def test_returns_none_for_non_durable_event(self): |
| 112 | + event = {"key": "value"} |
116 | 113 | response = {"Status": "SUCCEEDED"} |
117 | | - result = extract_durable_function_status_tag(response, event) |
118 | | - self.assertEqual(result, {}) |
| 114 | + self.assertIsNone(extract_durable_execution_status(response, event)) |
119 | 115 |
|
120 | | - def test_non_dict_response_returns_empty(self): |
121 | | - event = {"DurableExecutionArn": "arn:aws:states:us-east-1:123456789012:..."} |
122 | | - response = "string response" |
123 | | - result = extract_durable_function_status_tag(response, event) |
124 | | - self.assertEqual(result, {}) |
| 116 | + def test_returns_none_for_non_dict_response(self): |
| 117 | + event = {"DurableExecutionArn": "arn:aws:lambda:us-east-1:123:function:f:1/durable-execution/n/id"} |
| 118 | + self.assertIsNone(extract_durable_execution_status("string", event)) |
125 | 119 |
|
126 | | - def test_missing_status_returns_empty(self): |
127 | | - event = {"DurableExecutionArn": "arn:aws:states:us-east-1:123456789012:..."} |
128 | | - response = {"Result": "some-result"} # No Status field |
129 | | - result = extract_durable_function_status_tag(response, event) |
130 | | - self.assertEqual(result, {}) |
| 120 | + def test_returns_none_for_missing_status(self): |
| 121 | + event = {"DurableExecutionArn": "arn:aws:lambda:us-east-1:123:function:f:1/durable-execution/n/id"} |
| 122 | + response = {"Result": "some-result"} |
| 123 | + self.assertIsNone(extract_durable_execution_status(response, event)) |
131 | 124 |
|
132 | | - def test_invalid_status_returns_empty(self): |
133 | | - event = {"DurableExecutionArn": "arn:aws:states:us-east-1:123456789012:..."} |
| 125 | + def test_returns_none_for_invalid_status(self): |
| 126 | + event = {"DurableExecutionArn": "arn:aws:lambda:us-east-1:123:function:f:1/durable-execution/n/id"} |
134 | 127 | response = {"Status": "INVALID"} |
135 | | - result = extract_durable_function_status_tag(response, event) |
136 | | - self.assertEqual(result, {}) |
| 128 | + self.assertIsNone(extract_durable_execution_status(response, event)) |
137 | 129 |
|
138 | | - def test_non_dict_event_returns_empty(self): |
139 | | - event = "not-a-dict" |
| 130 | + def test_returns_none_for_non_dict_event(self): |
140 | 131 | response = {"Status": "SUCCEEDED"} |
141 | | - result = extract_durable_function_status_tag(response, event) |
142 | | - self.assertEqual(result, {}) |
| 132 | + self.assertIsNone(extract_durable_execution_status(response, "not-a-dict")) |
143 | 133 |
|
144 | | - def test_none_event_returns_empty(self): |
145 | | - event = None |
| 134 | + def test_returns_none_for_none_event(self): |
146 | 135 | response = {"Status": "SUCCEEDED"} |
147 | | - result = extract_durable_function_status_tag(response, event) |
148 | | - self.assertEqual(result, {}) |
| 136 | + self.assertIsNone(extract_durable_execution_status(response, None)) |
149 | 137 |
|
150 | | - def test_none_response_returns_empty(self): |
151 | | - event = {"DurableExecutionArn": "arn:aws:states:us-east-1:123456789012:..."} |
152 | | - response = None |
153 | | - result = extract_durable_function_status_tag(response, event) |
154 | | - self.assertEqual(result, {}) |
| 138 | + def test_returns_none_for_none_response(self): |
| 139 | + event = {"DurableExecutionArn": "arn:aws:lambda:us-east-1:123:function:f:1/durable-execution/n/id"} |
| 140 | + self.assertIsNone(extract_durable_execution_status(None, event)) |
0 commit comments