-
Notifications
You must be signed in to change notification settings - Fork 17
Generate Log Restriction Query API Spec #2999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2
Are you sure you want to change the base?
Generate Log Restriction Query API Spec #2999
Conversation
|
|
||
| **Note: This endpoint is in public beta. If you have any feedback, contact [Datadog support](https://docs.datadoghq.com/help/).** | ||
|
|
||
| A Restriction Query is a logs query that restricts which logs the `logs_read_data` permission grants read access to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| A Restriction Query is a logs query that restricts which logs the `logs_read_data` permission grants read access to. | |
| A Restriction Query is a logs query that restricts which logs the `logs_read_data` permission grants _read_ access to. |
Italicized the word "read" to differentiate it in the sentence.
| one of their Restriction Queries. This is true whether the user queries log events from any log-related feature, including | ||
| the log explorer, Live Tail, re-hydration, or a dashboard widget. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| one of their Restriction Queries. This is true whether the user queries log events from any log-related feature, including | |
| the log explorer, Live Tail, re-hydration, or a dashboard widget. | |
| one of their Restriction Queries. This is true whether the user queries log events from any log-related feature( | |
| the log explorer, Live Tail, re-hydration), or a dashboard widget. |
This keeps the distance between "whether ... or" a bit shorter for an easier read. Let me know what you think!
| one of their Restriction Queries. This is true whether the user queries log events from any log-related feature, including | ||
| the log explorer, Live Tail, re-hydration, or a dashboard widget. | ||
|
|
||
| Restriction Queries currently only support use of the following components of log events: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Restriction Queries currently only support use of the following components of log events: | |
| Currently, Restriction Queries only support the following components of log events: |
Small nitpick here to address the flow of reading. Let me know your thoughts.
| - The log message | ||
| - Tags | ||
|
|
||
| To restrict read access on log data, add a team tag to log events to indicate which teams own them, and then scope Restriction Queries to the relevant values of the team tag. Tags can be applied to log events in many ways, and a log event can have multiple tags with the same key (like team) and different values. This means the same log event can be visible to roles whose restriction queries are scoped to different team values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| To restrict read access on log data, add a team tag to log events to indicate which teams own them, and then scope Restriction Queries to the relevant values of the team tag. Tags can be applied to log events in many ways, and a log event can have multiple tags with the same key (like team) and different values. This means the same log event can be visible to roles whose restriction queries are scoped to different team values. | |
| To restrict _read_ access on log data, add a **team** tag to log events to indicate which teams own them, and then scope Restriction Queries to the relevant values of the team tag. Tags can be applied to log events in many ways, and a log event can have multiple tags with the same key (like team) and different values. This means the same log event can be visible to roles whose restriction queries are scoped to different team values. |
Should "restriction queries" always be capitalized? I see that was the case in all instances prior to this one. Thanks for confirming!
|
|
||
| To restrict read access on log data, add a team tag to log events to indicate which teams own them, and then scope Restriction Queries to the relevant values of the team tag. Tags can be applied to log events in many ways, and a log event can have multiple tags with the same key (like team) and different values. This means the same log event can be visible to roles whose restriction queries are scoped to different team values. | ||
|
|
||
| See [How to Set Up RBAC for Logs](https://docs.datadoghq.com/logs/guide/logs-rbac/?tab=api#restrict-access-to-logs) for details on how to add restriction queries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| See [How to Set Up RBAC for Logs](https://docs.datadoghq.com/logs/guide/logs-rbac/?tab=api#restrict-access-to-logs) for details on how to add restriction queries. | |
| See [How to Set Up RBAC for Logs](https://docs.datadoghq.com/logs/guide/logs-rbac/?tab=api#restrict-access-to-logs) for details on how to add restriction queries. |
same question about restriction queries here.
iadjivon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there,
I added some comments here. Let me know if you have any questions!
a2b4089 to
a541b5e
Compare
See DataDog/datadog-api-spec#4566 Test branch datadog-api-spec/v2/test/dinu.wijetunga/generate_lrq_go_schema_2