Making sure the fix also works with Optionals

admkopec · admkopec · commit f7f8f5fe6761 · 2024-02-11T17:33:56.000+01:00
diff --git a/Sources/ManagedModels/SchemaCompatibility/NSAttributeDescription+Data.swift b/Sources/ManagedModels/SchemaCompatibility/NSAttributeDescription+Data.swift
@@ -92,7 +92,7 @@ extension CoreData.NSAttributeDescription: SchemaProperty {
         return
       }
 
-        if let valueTransformerName = valueTransformerName, newValue is any NSObjectProtocol.Type {
+        if let valueTransformerName = valueTransformerName {
         self.attributeType = .transformableAttributeType
         self.isOptional    = newValue is any AnyOptional.Type
         
diff --git a/Tests/ManagedModelTests/Schemas/TransformablePropertySchema.swift b/Tests/ManagedModelTests/Schemas/TransformablePropertySchema.swift
@@ -21,6 +21,8 @@ extension Fixtures {
             var expires : Date
             @Attribute(.transformable(by: AccessSIPTransformer.self))
             var sip     : AccessSIP
+            @Attribute(.transformable(by: AccessSIPTransformer.self))
+            var optionalSIP : AccessSIP?
         }
         
         class AccessSIP: NSObject {

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ extension CoreData.NSAttributeDescription: SchemaProperty {`
`92`	`92`	`return`
`93`	`93`	`}`
`94`	`94`
`95`		`- if let valueTransformerName = valueTransformerName, newValue is any NSObjectProtocol.Type {`
	`95`	`+ if let valueTransformerName = valueTransformerName {`
`96`	`96`	`self.attributeType = .transformableAttributeType`
`97`	`97`	`self.isOptional = newValue is any AnyOptional.Type`
`98`	`98`
Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,8 @@ extension Fixtures {`
`21`	`21`	`var expires : Date`
`22`	`22`	`@Attribute(.transformable(by: AccessSIPTransformer.self))`
`23`	`23`	`var sip : AccessSIP`
	`24`	`+ @Attribute(.transformable(by: AccessSIPTransformer.self))`
	`25`	`+ var optionalSIP : AccessSIP?`
`24`	`26`	`}`
`25`	`27`
`26`	`28`	`class AccessSIP: NSObject {`