From 3f3a2ab41134ee0b1408b6cceb091078b3e89aaf Mon Sep 17 00:00:00 2001 From: Dakera Ops Date: Thu, 21 May 2026 14:04:55 +0000 Subject: [PATCH 1/2] fix(DAK-5433): clear stale deb/rpm artifacts before build + enforce brew tests Two fixes: - publish-linux-packages.yml: rm -rf target/debian/ and target/generate-rpm/ before building. A cache hit on `target/` left the old `dakera-cli_*.deb` alongside the new `dk_*.deb`; head -1 in the publish step picked the wrong one alphabetically. Clearing ensures only the freshly-named package exists. - install-test.yml: remove continue-on-error from brew jobs now that homebrew-tap is public (DAK-5437 resolved). Co-Authored-By: Claude Sonnet 4.6 --- .github/workflows/install-test.yml | 5 +---- .github/workflows/publish-linux-packages.yml | 8 ++++++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/.github/workflows/install-test.yml b/.github/workflows/install-test.yml index 7b5b14d..84bc9bc 100644 --- a/.github/workflows/install-test.yml +++ b/.github/workflows/install-test.yml @@ -10,19 +10,16 @@ on: branches: [main] jobs: - # NOTE: Homebrew tap (dakera-ai/homebrew-tap) is private. - # brew install requires a public tap. These jobs run with continue-on-error until - # the tap is made public (requires founder approval per org security policy). test-brew-dk: name: Homebrew — dk runs-on: macos-latest - continue-on-error: true steps: - name: Install dk via Homebrew run: brew install dakera-ai/tap/dk - name: Verify dk version run: dk --version + test-apt: name: APT — dk runs-on: ubuntu-22.04 diff --git a/.github/workflows/publish-linux-packages.yml b/.github/workflows/publish-linux-packages.yml index 0dc858e..cd0cbaa 100644 --- a/.github/workflows/publish-linux-packages.yml +++ b/.github/workflows/publish-linux-packages.yml @@ -27,7 +27,9 @@ jobs: - name: Install cargo-deb run: cargo install cargo-deb --locked - name: Build .deb package - run: cargo deb + run: | + rm -rf target/debian/ + cargo deb - name: Upload deb artifact uses: actions/upload-artifact@v4 with: @@ -52,7 +54,9 @@ jobs: - name: Build release binary run: cargo build --release - name: Build .rpm package - run: cargo generate-rpm + run: | + rm -rf target/generate-rpm/ + cargo generate-rpm - name: Upload rpm artifact uses: actions/upload-artifact@v4 with: From bc5f8beb799861e85d8081f92e5580171b921d14 Mon Sep 17 00:00:00 2001 From: Dakera Ops Date: Thu, 21 May 2026 14:38:26 +0000 Subject: [PATCH 2/2] fix: use crate name dakera-cli in install-test workflow (not binary name dk) cargo install and cargo binstall require the crate name, not the binary name. The crate is published as dakera-cli on crates.io and installs the dk binary. Also removes continue-on-error and the stale DAK-5436 NOTE comment now that dakera-cli v0.6.0 is live on crates.io. Co-Authored-By: Claude Sonnet 4.6 --- .github/workflows/install-test.yml | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/.github/workflows/install-test.yml b/.github/workflows/install-test.yml index 84bc9bc..5d8ba45 100644 --- a/.github/workflows/install-test.yml +++ b/.github/workflows/install-test.yml @@ -55,12 +55,9 @@ jobs: - name: Verify dk version run: dk --version - # NOTE: cargo install and cargo binstall require dk to be published on crates.io. - # These jobs are expected to fail until that happens. Tracked in DAK-5436. test-cargo-install: - name: cargo install — dk + name: cargo install — dakera-cli runs-on: ubuntu-latest - continue-on-error: true steps: - uses: dtolnay/rust-toolchain@stable - uses: actions/cache@v4 @@ -68,22 +65,21 @@ jobs: path: ~/.cargo/registry key: cargo-install-${{ runner.os }}-${{ github.run_id }} restore-keys: cargo-install-${{ runner.os }}- - - name: Install dk from crates.io - run: cargo install dk --locked + - name: Install dakera-cli from crates.io + run: cargo install dakera-cli --locked - name: Verify dk version run: dk --version test-cargo-binstall: - name: cargo binstall — dk + name: cargo binstall — dakera-cli runs-on: ubuntu-latest - continue-on-error: true steps: - name: Install cargo-binstall run: | curl -L --proto '=https' --tlsv1.2 -sSf \ https://raw.githubusercontent.com/cargo-bins/cargo-binstall/main/install-from-binstall-release.sh \ | bash - - name: Install dk via binstall - run: cargo binstall dk --no-confirm + - name: Install dakera-cli via binstall + run: cargo binstall dakera-cli --no-confirm - name: Verify dk version run: dk --version