-
Notifications
You must be signed in to change notification settings - Fork 278
Symfony 7.4 upgrade #3240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Symfony 7.4 upgrade #3240
Conversation
9ebfa38 to
8479fcd
Compare
9ec2280 to
3cbf43e
Compare
3c8992b to
3fe9239
Compare
.github/jobs/composer_setup.sh
Outdated
| PHPVERSION=$(php -r 'echo PHP_MAJOR_VERSION.".".PHP_MINOR_VERSION."\n";') | ||
| export PHPVERSION | ||
| echo "$PHPVERSION" | tee -a "$ARTIFACTS"/phpversion.txt | ||
| sudo apt-get -y purge "php$PHPVERSION-redis" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a comment why this is required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the new CI image doesn't have this anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did now remove it, which broke CI. I assume you'll look into it.
webapp/src/DependencyInjection/Compiler/DoctrineNativeLazyObjectsPass.php
Show resolved
Hide resolved
…ible with symfony/cache anymore Since we don't use or need Redis, this is fine
e9f9013 to
ca4f47d
Compare
No description provided.