From 1ddadde63c60fb99f666e115b4bd52dc3b68456a Mon Sep 17 00:00:00 2001 From: Tobias Werth Date: Sat, 29 Nov 2025 18:03:47 +0100 Subject: [PATCH 1/5] Make sure the g++ version is modern enough where it is available but not the default (such as old Ubuntu LTS). --- .github/jobs/configure-checks/setup_configure_image.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/jobs/configure-checks/setup_configure_image.sh b/.github/jobs/configure-checks/setup_configure_image.sh index b3bdcad686..7d492454ec 100755 --- a/.github/jobs/configure-checks/setup_configure_image.sh +++ b/.github/jobs/configure-checks/setup_configure_image.sh @@ -10,6 +10,8 @@ case $distro_id in dnf install pkg-config make bats autoconf automake util-linux -y ;; *) apt-get update; apt-get full-upgrade -y + # Install g++-12 to make sure we can use -std=c++20 + version=$(g++ -dumpversion 2>/dev/null | awk -F'.' '{print $1}' 2>/dev/null || echo 0); [ "${version}" -lt 12 ] && apt install -y g++-12 apt-get install pkg-config make bats autoconf -y ;; esac From 9ceed94cc540d430aac84d1920700f253e81d8c0 Mon Sep 17 00:00:00 2001 From: Kevin Jilissen Date: Sat, 29 Nov 2025 17:28:45 +0100 Subject: [PATCH 2/5] Disable diff selection if there is no other Also, do not store the preferred diff tag when there is no other diff. This prevents going back to no-diff after viewing a submission without a diff. --- webapp/public/js/domjudge.js | 2 +- webapp/templates/jury/partials/submission_diff.html.twig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/webapp/public/js/domjudge.js b/webapp/public/js/domjudge.js index 0cb848ba23..68d8a7373b 100644 --- a/webapp/public/js/domjudge.js +++ b/webapp/public/js/domjudge.js @@ -1422,7 +1422,7 @@ function initDiffEditor(editorId) { }); const selected = select[0].options[select[0].selectedIndex]; - if (selected && selected.dataset.tag) { + if (!select[0].disabled && selected && selected.dataset.tag) { setDiffTag(selected.dataset.tag); } diff --git a/webapp/templates/jury/partials/submission_diff.html.twig b/webapp/templates/jury/partials/submission_diff.html.twig index fae494ecae..de391147c4 100644 --- a/webapp/templates/jury/partials/submission_diff.html.twig +++ b/webapp/templates/jury/partials/submission_diff.html.twig @@ -26,7 +26,7 @@ {% endif %}
- {%- for other in otherSubmissions %}