Don't display clarification time from before/after contest #3192
Conversation
vmcj
force-pushed
the
time_before_contest
branch
from
29417ed to
34a63fe
Compare
nickygerritsen
left a comment
nickygerritsen
left a comment
There was a problem hiding this comment.
I wonder if we have any cases where this would look ugly but can't think of any.
I like the idea but would wait for other opinions before merging.
I looked at the pages and I think it works in most locations, I disabled it for one. The question is if we do like this for Fine with waiting for some extra opinions. |
I don't see any changes to .twig files? |
vmcj
force-pushed
the
time_before_contest
branch
from
34a63fe to
71c0111
Compare
It looks ugly in some cases and less professional in others where printing happened much earlier. The exact time is not relevant and could lead to discussions with teams. Originally this was only for the team interface but it does add information for the jury. It's more important to know that something happened before the contest (or after) and the interpretation of that time as knowing when it exactly happened. We still do this in case we explicit set the format such as for the countdown etc.
vmcj
force-pushed
the
time_before_contest
branch
from
71c0111 to
1b214ae
Compare
I was talking about and I think I removed it as it should already work. I've now added it back just to be sure. |
| if ($relativeTime < 0 && $squash) { | ||
| return "Before contest"; | ||
| } | ||
| if ($relativeTime > $contest->getContestTime($contest->getEndtime())) { |
There was a problem hiding this comment.
I'd say this also requires $squash.
3 participants
It looks ugly in some cases and less professional in others where printing happened much earlier. The exact time is not relevant and could lead to discussions with teams.
Originally this was only for the team interface but it does add information for the jury. It's more important to know that something happened before the contest (or after) and the interpretation of that time as knowing when it exactly happened.