Random improvements

Better script creation screen
Move some script errors to overlay

Author: GeorgeRNG

src/main/java/io/github/techstreet/dfscript/screen/script/ScriptCreationScreen.java

@@ -3,41 +3,55 @@
 import io.github.techstreet.dfscript.DFScript;
 import io.github.techstreet.dfscript.screen.CScreen;
 import io.github.techstreet.dfscript.screen.widget.CButton;
+import io.github.techstreet.dfscript.screen.widget.CText;
 import io.github.techstreet.dfscript.screen.widget.CTextField;
 import io.github.techstreet.dfscript.script.ScriptManager;
+import net.minecraft.text.Text;
+
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
 public class ScriptCreationScreen extends CScreen {
 
     // invalid file name chars
     // there's definitely a better place to put this but this felt the simplest rn
-    Pattern ILLEGAL_CHARS = Pattern.compile("[\\\\/:*?\"<>|]");
+    Pattern ILLEGAL_CHARS = Pattern.compile("[\\\\/:*?\"<>|\n]");
 
     protected ScriptCreationScreen() {
-        super(105, 60);
+        super(100, 33);
+
+        widgets.add(new CText(4, 4, Text.of("Create Script")));
+
+        CTextField name = new CTextField("My Script", 4, 9, 92, 9, true){
+            @Override
+            public void keyPressed(int keyCode, int scanCode, int modifiers) {
+                if(keyCode == 257) return;
+                super.keyPressed(keyCode, scanCode, modifiers);
+            }
+        };
 
-        CTextField name = new CTextField("My Script", 2, 2, 96, 36, true);
+        name.setChangedListener(() -> {
+            String scriptName = name.getText();
+
+            Matcher m = ILLEGAL_CHARS.matcher(scriptName);
 
-        name.setChangedListener(() -> name.textColor = 0xFFFFFF);
+            name.textColor = m.find() ? 0xFF3333 : 0xFFFFFF;
+        });
 
         widgets.add(name);
 
-        widgets.add(new CButton(2, 42, 48, 15, "Create", () -> {
+        widgets.add(new CButton(4, 20, 44, 9, "Create", () -> {
             String scriptName = name.getText();
 
             Matcher m = ILLEGAL_CHARS.matcher(scriptName);
 
-            if (m.find()) {
-                name.textColor = 0xFF3333;
-                return;
-            }
+            if (m.find()) return;
 
             ScriptManager.getInstance().createScript(name.getText());
             DFScript.MC.setScreen(new ScriptListScreen(true));
         }));
 
-        widgets.add(new CButton(50, 42, 48, 15, "Cancel", () -> {
+        widgets.add(new CButton(52, 20, 44, 9, "Cancel", () -> {
             DFScript.MC.setScreen(new ScriptAddScreen());
         }));
     }

src/main/java/io/github/techstreet/dfscript/script/action/ScriptActionType.java

@@ -809,7 +809,7 @@ public enum ScriptActionType {
                     }
 
                     if (similiar.size() > 0) {
-                        ChatUtil.error("Did you mean: \n" + String.join(", \n", similiar));
+                        OverlayManager.getInstance().add("Did you mean: \n" + String.join(", \n", similiar));
                     }
                 } catch (Exception err) {
                     err.printStackTrace();
@@ -1229,7 +1229,7 @@ public enum ScriptActionType {
                     OverlayManager.getInstance().add("Unable to get text field value! (Not owned by script)");
                 }
             } else {
-                ChatUtil.error("Unable to get text field value! (Unknown menu type)");
+                OverlayManager.getInstance().add("Unable to get text field value! (Unknown menu type)");
             }
         })),
 
@@ -1615,7 +1615,7 @@ public void run(ScriptActionContext ctx) {
             }
         }
 
-        ChatUtil.error("Invalid arguments for " + name + ".");
+        OverlayManager.getInstance().add("Invalid arguments for " + name + ".");
     }
 
     private void generatePossibilities(List<List<ScriptActionArgument>> possibilities, ArrayList<ScriptActionArgument> current, List<ScriptActionArgument> arguments, int pos) {

src/main/java/io/github/techstreet/dfscript/util/RenderUtil.java

@@ -162,7 +162,6 @@ public static void popScissor() {
     public static void renderGuiItem(DrawContext context, ItemStack item) {
         MatrixStack stack = context.getMatrices();
         stack.push();
-        ItemRenderer renderer = DFScript.MC.getItemRenderer();
         stack.translate(0.0F, 0.0F, 100.0F);
         stack.scale(0.5F,0.5F,1F);
         context.drawItem(item, 0, 0);