From fa2a9b12c81b0cb754521233e346bd81224b0ea8 Mon Sep 17 00:00:00 2001 From: Al Rigazzi Date: Tue, 3 Feb 2026 18:11:14 +0200 Subject: [PATCH 1/4] Fix patch for rocm6.3 --- .../_core/_install/configs/mlpackages/LinuxX64ROCM6.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/smartsim/_core/_install/configs/mlpackages/LinuxX64ROCM6.json b/smartsim/_core/_install/configs/mlpackages/LinuxX64ROCM6.json index c528db50b..83113f91f 100644 --- a/smartsim/_core/_install/configs/mlpackages/LinuxX64ROCM6.json +++ b/smartsim/_core/_install/configs/mlpackages/LinuxX64ROCM6.json @@ -30,10 +30,10 @@ "replacement": "set_property(TARGET torch_c PROPERTY CXX_STANDARD 17)" }, { - "description": "Fix Regex, Load HIP", + "description": "Fix LoadHIP.cmake regex to match tabs in ROCm version header", "source_file": "../package/libtorch/share/cmake/Caffe2/public/LoadHIP.cmake", - "regex": ".*string.*", - "replacement": "" + "regex": "\\[ \\]\\+", + "replacement": "[ \\t]+" }, { "description": "Replace `/opt/rocm` with `$ENV{ROCM_PATH}`", From 846568037c60a34bfd4374c4f829a4bb7db39c1a Mon Sep 17 00:00:00 2001 From: Al Rigazzi Date: Tue, 3 Feb 2026 18:13:37 +0200 Subject: [PATCH 2/4] Update gitignore --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 97132aff7..0714fadd6 100644 --- a/.gitignore +++ b/.gitignore @@ -8,6 +8,7 @@ htmlcov smartsim.egg-info tests/test_output .DS_Store +build # Dependencies smartsim/_core/.third-party From 39fe09b28d5acb6cb83e7f81b41afb4eb1fa0d8b Mon Sep 17 00:00:00 2001 From: Al Rigazzi Date: Tue, 3 Feb 2026 18:30:32 +0200 Subject: [PATCH 3/4] Update changelog --- doc/changelog.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/doc/changelog.md b/doc/changelog.md index f6d922f85..6f80a91b5 100644 --- a/doc/changelog.md +++ b/doc/changelog.md @@ -11,6 +11,7 @@ To be released at some point in the future Description +- Update install patch for PyTorch 2.7.1+rocm6.3 - Modernize typing syntax to Python 3.10+ standards - Removed telemetry functionality, LaunchedManifest tracking classes, and SmartDashboard integration @@ -26,6 +27,9 @@ Description Detailed Notes +- Updated the post-install patch which is applied to the Caffe2/PyTorch + CMakeFind module. + ([SmartSim-PR793](https://github.com/CrayLabs/SmartSim/pull/793)) - Modernized typing syntax to use Python 3.10+ standards, replacing `Union[X, Y]` with `X | Y`, `Optional[X]` with `X | None`, and generic collections (`List[X]` → `list[X]`, `Dict[X, Y]` → `dict[X, Y]`, etc.). From dccd177ca158a5a8d3f8797c23d65b330d96270a Mon Sep 17 00:00:00 2001 From: Al Rigazzi Date: Thu, 5 Feb 2026 10:19:56 +0200 Subject: [PATCH 4/4] Comply to MattToast order. --- smartsim/_core/_install/configs/mlpackages/LinuxX64ROCM6.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/smartsim/_core/_install/configs/mlpackages/LinuxX64ROCM6.json b/smartsim/_core/_install/configs/mlpackages/LinuxX64ROCM6.json index 83113f91f..1df40d3af 100644 --- a/smartsim/_core/_install/configs/mlpackages/LinuxX64ROCM6.json +++ b/smartsim/_core/_install/configs/mlpackages/LinuxX64ROCM6.json @@ -33,7 +33,7 @@ "description": "Fix LoadHIP.cmake regex to match tabs in ROCm version header", "source_file": "../package/libtorch/share/cmake/Caffe2/public/LoadHIP.cmake", "regex": "\\[ \\]\\+", - "replacement": "[ \\t]+" + "replacement": "[ \\\\t]+" }, { "description": "Replace `/opt/rocm` with `$ENV{ROCM_PATH}`",