feat(translations): consolidate miscellaneous error translations

Author: adi-herwana-nus

app/controllers/course/assessment/submission/submissions_controller.rb

@@ -250,7 +250,7 @@ def download_statistics
     submission_ids = @assessment.submissions.by_users(course_user_ids).pluck(:id)
     if submission_ids.empty?
       return render json: {
-        error: I18n.t('course.assessment.submission.submissions.download_statistics.no_submission_statistics')
+        error: I18n.t('errors.course.assessment.submission.download_statistics.no_submissions')
       }, status: :bad_request
     end
 

app/controllers/course/survey/responses_controller.rb

@@ -14,7 +14,7 @@ def create
       @response.save!
       render_response_json
     else
-      render json: { error: t('course.survey.responses.no_course_user') }, status: :bad_request
+      render json: { error: t('errors.course.survey.responses.no_course_user') }, status: :bad_request
     end
   rescue ActiveRecord::RecordInvalid => e
     handle_create_error(e)

app/controllers/course/user_invitations_controller.rb

@@ -159,7 +159,7 @@ def aggregate_errors
   def invalid_course_user_errors
     invalid_course_users.map do |course_user|
       user = self.class.helpers.display_course_user(course_user)
-      t('course.user_invitations.errors.duplicate_user', user: user)
+      t('errors.course.user_invitations.duplicate_user', user: user)
     end
   end
 
@@ -176,7 +176,7 @@ def invalid_course_users
   def invalid_invitation_email_errors
     invalid_invitations.map do |invitation|
       message = invitation.errors.full_messages.to_sentence
-      t('course.user_invitations.errors.invalid_email', email: invitation.email, message: message)
+      t('errors.course.user_invitations.invalid_email', email: invitation.email, message: message)
     end
   end
 

app/controllers/course/user_registrations_controller.rb

@@ -23,8 +23,8 @@ def registration_params
   def ensure_unregistered_user
     return unless current_course.course_users.exists?(user: current_user)
 
-    role = t("course.users.role.#{current_course_user.role}")
-    message = t('course.users.new.already_registered', role: role)
+    role = t("errors.course.users.role.#{current_course_user.role}")
+    message = t('errors.course.users.already_registered', role: role)
 
     render json: { errors: message }, status: :conflict
   end

app/controllers/user/emails_controller.rb

@@ -33,7 +33,7 @@ def set_primary
 
   def send_confirmation
     if @email.confirmed?
-      render json: { errors: t('.already_confirmed', email: @email.email) }, status: :bad_request
+      render json: { errors: t('errors.user.emails.already_confirmed', email: @email.email) }, status: :bad_request
     else
       @email.send_confirmation_instructions
       head :ok

app/controllers/user/registrations_controller.rb

@@ -7,7 +7,11 @@ class User::RegistrationsController < Devise::RegistrationsController
   # GET /resource/sign_up
   def new
     if @invitation&.confirmed?
-      message = @invitation.confirmer ? t('.used_with_email', email: @invitation.confirmer.email) : t('.used')
+      message = if @invitation.confirmer
+                  t('errors.user.registrations.used_with_email', email: @invitation.confirmer.email)
+                else
+                  t('errors.user.registrations.used')
+                end
       render json: { message: message }, status: :conflict and return
     elsif @invitation.is_a?(Course::UserInvitation)
       course = @invitation.course
@@ -34,7 +38,7 @@ def new
   def create
     unless verify_recaptcha
       build_resource(sign_up_params)
-      render json: { errors: { recaptcha: t('user.registrations.create.verify_recaptcha_alert') } },
+      render json: { errors: { recaptcha: t('errors.user.registrations.verify_recaptcha_alert') } },
              status: :unprocessable_entity
       return
     end

app/helpers/application_html_formatters_helper.rb

@@ -41,7 +41,7 @@ def sanitize_ckeditor_rich_text(text)
   def format_code_block(code, language = nil, start_line = 1)
     if code_size_exceeds_limit?(code)
       content_tag(:div, class: 'alert alert-warning') do
-        I18n.t('layouts.code_formatter.size_too_big')
+        I18n.t('errors.code_formatter.size_too_big')
       end
     else
       sanitize_and_format_code(code, language, start_line)

app/helpers/application_jobs_helper.rb

@@ -6,13 +6,13 @@ def job_error_message(error)
 
     case error['class']
     when Docker::Error::ConflictError.name
-      I18n.t('course.assessment.answer.programming_auto_grading.job.failure.time_limit_breached')
+      I18n.t('errors.course.assessment.answer.programming_auto_grading.job.failure.time_limit_breached')
     when Timeout::Error.name
-      I18n.t('course.assessment.answer.programming_auto_grading.job.failure.timeout_error')
+      I18n.t('errors.course.assessment.answer.programming_auto_grading.job.failure.timeout_error')
     when Docker::Error::TimeoutError
-      I18n.t('course.assessment.answer.programming_auto_grading.job.failure.container_unreachable')
+      I18n.t('errors.course.assessment.answer.programming_auto_grading.job.failure.container_unreachable')
     else
-      I18n.t('course.assessment.answer.programming_auto_grading.job.failure.generic_error', error: error['message'])
+      I18n.t('errors.course.assessment.answer.programming_auto_grading.job.failure.generic_error', error: error['message'])
     end
   end
 end

app/models/course/assessment/live_feedback/thread.rb

@@ -22,7 +22,7 @@ def validate_at_most_one_active_thread_per_submission_question
 
     return if active_thread_count <= 1
 
-    errors.add(:base, I18n.t('course.assessment.live_feedback.thread.only_one_active_thread'))
+    errors.add(:base, I18n.t('errors.course.assessment.live_feedback.thread.only_one_active_thread'))
   end
 
   def sent_user_messages(user_id)

app/models/user/email.rb

@@ -44,7 +44,7 @@ def set_new_user_primary_email
 
     return if user.set_next_email_as_primary
 
-    errors.add(:base, I18n.t('user.emails.set_primary.no_confirmed_emails'))
+    errors.add(:base, I18n.t('errors.user.emails.no_confirmed_emails'))
     raise ActiveRecord::Rollback
   end