Settings: log level, log folder actions, Support ID reset, OK/Cancel

AppLogger now owns the Serilog configuration so the level can change at
runtime and the log files can be released and deleted. Settings offers
Off / Errors only / Normal / Detailed, defaulting to Detailed on alpha
and beta builds and Normal on stable. The dialog shows the log folder
path with Open and Delete buttons, and the Support ID with Copy and
Reset; resetting the ID also removes the local report copies that
carry the old one. Diagnostics and logging choices are pending until
OK; Cancel discards them.

Author: Computer-Tsu

App.xaml.cs

@@ -21,11 +21,13 @@ protected override async void OnStartup(StartupEventArgs e)
     {
         base.OnStartup(e);
 
-        ConfigureSerilog();
+        // Settings are read before the host exists because the log level lives there.
+        var earlySettings = new SettingsService();
+        AppLogger.Configure(AppLogger.ResolveLevel(earlySettings.Current.LogLevel));
 
         _host = Host.CreateDefaultBuilder()
             .UseSerilog()
-            .ConfigureServices(RegisterServices)
+            .ConfigureServices(s => RegisterServices(s, earlySettings))
             .Build();
 
         await _host.StartAsync();
@@ -93,11 +95,11 @@ protected override async void OnExit(ExitEventArgs e)
 
     // ── Service registration ─────────────────────────────────────────────
 
-    private static void RegisterServices(IServiceCollection services)
+    private static void RegisterServices(IServiceCollection services, SettingsService earlySettings)
     {
         // Infrastructure
         services.AddSingleton<AppLogger>();
-        services.AddSingleton<SettingsService>();
+        services.AddSingleton(earlySettings);
         services.AddSingleton(new HttpClient { Timeout = TimeSpan.FromSeconds(5) });
         services.AddSingleton<TelemetryService>();
 
@@ -123,26 +125,4 @@ private static void RegisterServices(IServiceCollection services)
         services.AddTransient<MainWindow>();
     }
 
-    // ── Logging setup ────────────────────────────────────────────────────
-
-    private static void ConfigureSerilog()
-    {
-        var logDir = Path.Combine(
-            Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData),
-            BrandingInfo.SuiteName,
-            BrandingInfo.AppName,
-            BrandingInfo.LogFolder);
-
-        Directory.CreateDirectory(logDir);
-
-        Log.Logger = new LoggerConfiguration()
-            .MinimumLevel.Debug()
-            .WriteTo.File(
-                path: Path.Combine(logDir, BrandingInfo.LogFileName),
-                rollingInterval: RollingInterval.Day,
-                retainedFileCountLimit: 7,
-                outputTemplate: "{Timestamp:yyyy-MM-dd HH:mm:ss.fff} [{Level:u3}] {Message:lj}{NewLine}{Exception}")
-            .WriteTo.Debug()
-            .CreateLogger();
-    }
 }

CHANGELOG.md

@@ -19,7 +19,9 @@ Version numbers: patch (x.x.1) for landed features and fixes, minor (x.1.0) for
   telemetry endpoint: a startup report and a per-test-run report with radio model, serial settings,
   USB cable identifiers, and test outcomes. Every report is stored locally and viewable under
   Help > View collected data. Support ID shown in Help > About.
-- Settings window now has content: the diagnostics toggle, data viewer, and privacy link
+- Settings window: diagnostics toggle, log level (Off / Errors only / Normal / Detailed —
+  Detailed by default on test builds), log folder path with Open and Delete buttons, Support ID
+  with Copy and Reset. Changes apply on OK; Cancel discards them.
 - Unhandled exceptions are logged, reported if diagnostics are on, and shown to the operator
   before the app closes
 

Logging/AppLogger.cs

@@ -1,29 +1,103 @@
 using Serilog;
+using Serilog.Events;
+using System.IO;
 
 namespace RigCheck.Logging;
 
 /// <summary>
-/// Thin wrapper around Serilog for structured logging.
-/// Provides a contextual logger for classes that need one.
-/// Mirrors the PortPane AppLogger pattern.
+/// Owns the Serilog configuration so the level can change at runtime from
+/// Settings and the log files can be released and deleted on request.
+/// Instance members are a thin contextual wrapper for classes that take
+/// a logger by injection.
 /// </summary>
 public class AppLogger
 {
-    public ILogger ForContext<T>() =>
-        Log.ForContext<T>();
+    // ── Levels offered in Settings ────────────────────────────────────────
+    // Stored as these strings; empty means "channel default".
+    public const string LevelOff      = "Off";
+    public const string LevelErrors   = "Error";
+    public const string LevelNormal   = "Information";
+    public const string LevelDetailed = "Debug";
 
-    public ILogger ForContext(string propertyName, object value) =>
-        Log.ForContext(propertyName, value);
+    public static string LogDirectory { get; } = Path.Combine(
+        Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData),
+        BrandingInfo.SuiteName, BrandingInfo.AppName, BrandingInfo.LogFolder);
 
-    public void Info(string messageTemplate, params object[] args) =>
-        Log.Information(messageTemplate, args);
+    public static string CurrentLevel { get; private set; } = LevelNormal;
 
-    public void Debug(string messageTemplate, params object[] args) =>
-        Log.Debug(messageTemplate, args);
+    /// <summary>Test-channel builds log in detail by default; stable logs normally.</summary>
+    public static string ChannelDefaultLevel =>
+        BuildInfo.IsAlpha || BuildInfo.IsBeta ? LevelDetailed : LevelNormal;
 
-    public void Warn(string messageTemplate, params object[] args) =>
-        Log.Warning(messageTemplate, args);
+    /// <summary>Resolve a stored setting ("" = channel default) to a concrete level.</summary>
+    public static string ResolveLevel(string? stored) =>
+        string.IsNullOrEmpty(stored) ? ChannelDefaultLevel : stored;
 
-    public void Error(Exception ex, string messageTemplate, params object[] args) =>
-        Log.Error(ex, messageTemplate, args);
+    // ── Configuration ─────────────────────────────────────────────────────
+
+    /// <summary>Build (or rebuild) the global logger at the given level. Safe to call repeatedly.</summary>
+    public static void Configure(string level)
+    {
+        Log.CloseAndFlush();
+        CurrentLevel = level;
+
+        if (level == LevelOff)
+        {
+            Log.Logger = new LoggerConfiguration().CreateLogger();
+            return;
+        }
+
+        Directory.CreateDirectory(LogDirectory);
+
+        var minimum = level switch
+        {
+            LevelErrors   => LogEventLevel.Error,
+            LevelDetailed => LogEventLevel.Debug,
+            _             => LogEventLevel.Information,
+        };
+
+        Log.Logger = new LoggerConfiguration()
+            .MinimumLevel.Is(minimum)
+            .WriteTo.File(
+                path: Path.Combine(LogDirectory, BrandingInfo.LogFileName),
+                rollingInterval: RollingInterval.Day,
+                retainedFileCountLimit: 7,
+                outputTemplate: "{Timestamp:yyyy-MM-dd HH:mm:ss.fff} [{Level:u3}] {Message:lj}{NewLine}{Exception}")
+            .WriteTo.Debug()
+            .CreateLogger();
+    }
+
+    /// <summary>
+    /// Delete every log file. The logger is closed first so the current
+    /// day's file is released, then reopened at the same level.
+    /// Returns the number of files removed.
+    /// </summary>
+    public static int DeleteLogs()
+    {
+        Log.CloseAndFlush();
+
+        var removed = 0;
+        if (Directory.Exists(LogDirectory))
+        {
+            foreach (var file in Directory.GetFiles(LogDirectory, "*.log"))
+            {
+                try { File.Delete(file); removed++; }
+                catch { /* a file held by another process stays; the rest go */ }
+            }
+        }
+
+        Configure(CurrentLevel);
+        Log.Information("Log files deleted by user ({Count} removed)", removed);
+        return removed;
+    }
+
+    // ── Contextual wrapper ────────────────────────────────────────────────
+
+    public ILogger ForContext<T>() => Log.ForContext<T>();
+    public ILogger ForContext(string propertyName, object value) => Log.ForContext(propertyName, value);
+
+    public void Info(string messageTemplate, params object[] args)  => Log.Information(messageTemplate, args);
+    public void Debug(string messageTemplate, params object[] args) => Log.Debug(messageTemplate, args);
+    public void Warn(string messageTemplate, params object[] args)  => Log.Warning(messageTemplate, args);
+    public void Error(Exception ex, string messageTemplate, params object[] args) => Log.Error(ex, messageTemplate, args);
 }

Resources/Strings.resx

@@ -165,6 +165,68 @@ Alpha builds stop running after {2} days so that testers always use current code
     <value>View collected data…</value>
     <comment>Button in Settings that opens the telemetry data viewer.</comment>
   </data>
+  <data name="Settings_LoggingHeading" xml:space="preserve">
+    <value>Logging</value>
+    <comment>Section heading in Settings.</comment>
+  </data>
+  <data name="Settings_LogLevel" xml:space="preserve">
+    <value>Write to log files:</value>
+    <comment>Label before the log level dropdown.</comment>
+  </data>
+  <data name="LogLevel_Off" xml:space="preserve">
+    <value>Off</value>
+  </data>
+  <data name="LogLevel_Error" xml:space="preserve">
+    <value>Errors only</value>
+  </data>
+  <data name="LogLevel_Information" xml:space="preserve">
+    <value>Normal</value>
+  </data>
+  <data name="LogLevel_Debug" xml:space="preserve">
+    <value>Detailed (recommended for test builds)</value>
+  </data>
+  <data name="Settings_LogPath" xml:space="preserve">
+    <value>Log files are stored in:</value>
+  </data>
+  <data name="Settings_OpenLogFolder" xml:space="preserve">
+    <value>Open log folder</value>
+    <comment>Button. Opens the log folder in Windows Explorer.</comment>
+  </data>
+  <data name="Settings_DeleteLogs" xml:space="preserve">
+    <value>Delete log files</value>
+    <comment>Button.</comment>
+  </data>
+  <data name="Settings_DeleteLogsConfirm" xml:space="preserve">
+    <value>Delete all {0} log files? This cannot be undone.</value>
+    <comment>Confirmation question. {0} is the app name.</comment>
+  </data>
+  <data name="Settings_DeleteLogsDone" xml:space="preserve">
+    <value>{0} log file(s) deleted.</value>
+    <comment>{0} is a number.</comment>
+  </data>
+  <data name="Settings_SupportIdHeading" xml:space="preserve">
+    <value>Support ID</value>
+    <comment>Section heading in Settings.</comment>
+  </data>
+  <data name="Settings_SupportIdHint" xml:space="preserve">
+    <value>A random identifier created when you first ran the program. It is the only identifier ever sent in diagnostic reports, and lets a support request be matched to them. Resetting it breaks that link for all past reports and deletes their local copies.</value>
+  </data>
+  <data name="Settings_ResetId" xml:space="preserve">
+    <value>Reset Support ID…</value>
+    <comment>Button.</comment>
+  </data>
+  <data name="Settings_ResetIdConfirm" xml:space="preserve">
+    <value>Create a new Support ID? Past diagnostic reports can no longer be matched to this installation, and their local copies will be deleted.</value>
+    <comment>Confirmation question.</comment>
+  </data>
+  <data name="Common_OK" xml:space="preserve">
+    <value>OK</value>
+    <comment>Button. Saves changes and closes the dialog.</comment>
+  </data>
+  <data name="Common_Cancel" xml:space="preserve">
+    <value>Cancel</value>
+    <comment>Button. Discards changes and closes the dialog.</comment>
+  </data>
   <data name="Menu_HelpViewData" xml:space="preserve">
     <value>_View collected data</value>
     <comment>Help menu item. Opens the telemetry data viewer.</comment>

Services/SettingsService.cs

@@ -52,6 +52,9 @@ public class RigCheckSettings
     public string InstallId         { get; set; } = Guid.NewGuid().ToString("D");
     public bool   TelemetryEnabled  { get; set; } = false;
     public bool   TelemetryPrompted { get; set; } = false;
+
+    // Logging level; empty means the channel default (see AppLogger).
+    public string LogLevel          { get; set; } = string.Empty;
 }
 
 // ── Settings service ──────────────────────────────────────────────────────

Views/SettingsDialog.xaml

@@ -3,13 +3,19 @@
         xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
         xmlns:loc="clr-namespace:RigCheck.Localization"
         Title="{loc:Str Settings_Title}"
-        Width="480" SizeToContent="Height"
+        Width="520" SizeToContent="Height"
         ResizeMode="NoResize"
         WindowStartupLocation="CenterOwner"
         ShowInTaskbar="False"
         Background="{StaticResource BrushBackground}"
         Foreground="{StaticResource BrushForeground}">
 
+    <!--
+        Settings are held as pending values and written only on OK.
+        Buttons that act on files (open folder, delete logs, reset ID) act
+        immediately and confirm first where destructive.
+    -->
+
     <StackPanel Margin="24,20,24,16">
 
         <!-- ── Anonymous diagnostics ── -->
@@ -19,13 +25,12 @@
         <CheckBox x:Name="TelemetryCheckBox"
                   Content="{loc:Str Telemetry_Checkbox}"
                   Foreground="{StaticResource BrushForeground}" FontSize="13"
-                  Margin="0,0,0,8"
-                  Checked="Telemetry_Changed" Unchecked="Telemetry_Changed" />
+                  Margin="0,0,0,8" />
 
         <TextBlock x:Name="WhatIsSentText" TextWrapping="Wrap"
                    Foreground="{StaticResource BrushMuted}" FontSize="12" Margin="0,0,0,6" />
         <TextBlock Text="{loc:Str Telemetry_WhatIsNotSent}" TextWrapping="Wrap"
-                   Foreground="{StaticResource BrushMuted}" FontSize="12" Margin="0,0,0,12" />
+                   Foreground="{StaticResource BrushMuted}" FontSize="12" Margin="0,0,0,10" />
 
         <StackPanel Orientation="Horizontal" Margin="0,0,0,20">
             <Button Content="{loc:Str Settings_ViewData}"
@@ -38,9 +43,58 @@
             </Button>
         </StackPanel>
 
-        <Button Content="{loc:Str Common_Close}"
-                Style="{StaticResource PrimaryButtonStyle}"
-                HorizontalAlignment="Right" MinWidth="90"
-                IsDefault="True" IsCancel="True" />
+        <!-- ── Logging ── -->
+        <TextBlock Text="{loc:Str Settings_LoggingHeading}"
+                   FontWeight="SemiBold" FontSize="14" Margin="0,0,0,8" />
+
+        <DockPanel Margin="0,0,0,8">
+            <Label Content="{loc:Str Settings_LogLevel}" Style="{StaticResource FieldLabelStyle}" />
+            <ComboBox x:Name="LogLevelCombo"
+                      SelectedValuePath="Value" DisplayMemberPath="Label"
+                      Style="{StaticResource ComboBoxStyle}" MinWidth="260" HorizontalAlignment="Left" />
+        </DockPanel>
+
+        <TextBlock Text="{loc:Str Settings_LogPath}"
+                   Foreground="{StaticResource BrushMuted}" FontSize="12" />
+        <TextBox x:Name="LogPathText"
+                 Style="{StaticResource TextBoxStyle}"
+                 IsReadOnly="True" FontFamily="Consolas" FontSize="12"
+                 Margin="0,4,0,8" />
+
+        <StackPanel Orientation="Horizontal" Margin="0,0,0,20">
+            <Button Content="{loc:Str Settings_OpenLogFolder}"
+                    Style="{StaticResource SecondaryButtonStyle}" Click="OpenLogFolder_Click" Margin="0,0,8,0" />
+            <Button Content="{loc:Str Settings_DeleteLogs}"
+                    Style="{StaticResource SecondaryButtonStyle}" Click="DeleteLogs_Click" Margin="0,0,12,0" />
+            <TextBlock x:Name="LogActionStatus" VerticalAlignment="Center"
+                       Foreground="{StaticResource BrushMuted}" FontSize="12" />
+        </StackPanel>
+
+        <!-- ── Support ID ── -->
+        <TextBlock Text="{loc:Str Settings_SupportIdHeading}"
+                   FontWeight="SemiBold" FontSize="14" Margin="0,0,0,8" />
+
+        <DockPanel Margin="0,0,0,6">
+            <Button DockPanel.Dock="Right" Content="{loc:Str Common_Copy}"
+                    Style="{StaticResource CopyButtonStyle}" Click="CopyId_Click" />
+            <TextBox x:Name="SupportIdText"
+                     Style="{StaticResource TextBoxStyle}"
+                     IsReadOnly="True" FontFamily="Consolas" FontSize="12" />
+        </DockPanel>
+        <TextBlock Text="{loc:Str Settings_SupportIdHint}" TextWrapping="Wrap"
+                   Foreground="{StaticResource BrushMuted}" FontSize="12" Margin="0,0,0,8" />
+        <Button Content="{loc:Str Settings_ResetId}"
+                Style="{StaticResource SecondaryButtonStyle}" HorizontalAlignment="Left"
+                Click="ResetId_Click" Margin="0,0,0,24" />
+
+        <!-- ── Footer ── -->
+        <StackPanel Orientation="Horizontal" HorizontalAlignment="Right">
+            <Button Content="{loc:Str Common_OK}"
+                    Style="{StaticResource PrimaryButtonStyle}"
+                    MinWidth="90" IsDefault="True" Click="Ok_Click" Margin="0,0,8,0" />
+            <Button Content="{loc:Str Common_Cancel}"
+                    Style="{StaticResource SecondaryButtonStyle}"
+                    MinWidth="90" IsCancel="True" />
+        </StackPanel>
     </StackPanel>
 </Window>