From 1759f9fc2d132c6c71291c2a1b39e8056a7b6095 Mon Sep 17 00:00:00 2001 From: Wei Hai Date: Thu, 30 Jul 2026 13:56:27 -0700 Subject: [PATCH] fix: make .coderabbit.yaml valid so the repo config is actually used MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit tone_instructions is capped at 250 characters by the CodeRabbit schema and this file held 539, so the whole config failed validation and reviews silently fell back to the org-level UI settings — none of the guidance here has been taking effect. The schema describes tone_instructions as a persona field ("Set the tone of reviews and chat"), not a place for review rules, and gives path_instructions 20000 characters. So the two repo-wide rules move to a `**` path_instruction rather than being cut: don't repeat what ruff/mypy already report, and don't flag pre-existing issues in moved or reformatted code. Nothing is lost. The rest of the old tone_instructions — public API stability, network error handling, type hints on the public surface — was already covered verbatim by the src/comfy_sdk/** entry. Validated against https://coderabbit.ai/integrations/schema.v2.json: 1 error before, 0 after. --- .coderabbit.yaml | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/.coderabbit.yaml b/.coderabbit.yaml index ab208dd..ce8af71 100644 --- a/.coderabbit.yaml +++ b/.coderabbit.yaml @@ -2,14 +2,8 @@ language: "en-US" early_access: false tone_instructions: | - This is a public Python SDK (comfy-python-sdk). CI already runs - `ruff check`, `ruff format --check`, and `mypy` on every PR — do not repeat - their findings or nitpick style/formatting. Focus on public API stability - (this SDK is consumed by external users, so flag breaking changes to - public method signatures or types), correct error handling for network - calls, and clear type hints on the public surface. Only comment on issues - introduced by this PR's changes; do not flag pre-existing problems in - moved, re-indented, or reformatted code. + Direct and technical. Lead with the concrete risk or breakage, not praise. + No compliments or filler — if a change is fine, say nothing. reviews: profile: "assertive" @@ -35,6 +29,16 @@ reviews: - "!.venv/**" path_instructions: + # Repo-wide review rules. These used to live in `tone_instructions`, but + # that field is capped at 250 characters by the CodeRabbit schema, which + # silently invalidated this whole file. + - path: "**" + instructions: | + CI already runs `ruff check`, `ruff format --check`, and `mypy` on + every PR — do not repeat their findings or nitpick style/formatting. + + Only comment on issues introduced by this PR's changes; do not flag + pre-existing problems in moved, re-indented, or reformatted code. - path: "src/comfy_sdk/**" instructions: | Public SDK surface. Focus on: