From 4765894d102439c19e7dde3214c834f53ba8afc2 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Mon, 12 Oct 2026 13:51:14 +0100 Subject: [PATCH 01/53] Passes classify right angle test --- implement-and-rewrite-tests/implement/1-get-angle-type.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/implement-and-rewrite-tests/implement/1-get-angle-type.js b/implement-and-rewrite-tests/implement/1-get-angle-type.js index 8a6fba050..a2646fb93 100644 --- a/implement-and-rewrite-tests/implement/1-get-angle-type.js +++ b/implement-and-rewrite-tests/implement/1-get-angle-type.js @@ -17,5 +17,7 @@ // execute the code to ensure all tests pass. export function getAngleType(angle) { - // TODO: Implement this function + if (angle === 90){ + return "Right angle"; + } } From f6f742f52af29aa91b6318c3c8f3a02533155904 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Mon, 12 Oct 2026 13:54:05 +0100 Subject: [PATCH 02/53] Add test for invalid 0 degree angle and update function to pass --- .../implement-tests-with-node-test/1-get-angle-type.test.js | 6 ++++++ implement-and-rewrite-tests/implement/1-get-angle-type.js | 2 ++ 2 files changed, 8 insertions(+) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js index cf50f6cad..f887ddc4b 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js @@ -10,3 +10,9 @@ test("Classifies right angles", () => { const right = getAngleType(90); assert.equal(right, "Right angle"); }); + +test("Classifies invalid angle 0 degrees", () => { + const right = getAngleType(0); + assert.equal(right, "Invalid angle"); +}); + diff --git a/implement-and-rewrite-tests/implement/1-get-angle-type.js b/implement-and-rewrite-tests/implement/1-get-angle-type.js index a2646fb93..075560ee6 100644 --- a/implement-and-rewrite-tests/implement/1-get-angle-type.js +++ b/implement-and-rewrite-tests/implement/1-get-angle-type.js @@ -19,5 +19,7 @@ export function getAngleType(angle) { if (angle === 90){ return "Right angle"; + } else { + return "Invalid angle"; } } From 048e29dea1d8ad9904f6f21947d936481b5259bb Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Mon, 12 Oct 2026 13:56:43 +0100 Subject: [PATCH 03/53] Add test for acute 1 degree angle and update function to pass --- .../implement-tests-with-node-test/1-get-angle-type.test.js | 6 ++++++ implement-and-rewrite-tests/implement/1-get-angle-type.js | 6 +++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js index f887ddc4b..f7a8e33a2 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js @@ -16,3 +16,9 @@ test("Classifies invalid angle 0 degrees", () => { assert.equal(right, "Invalid angle"); }); +test("Classifies acute angle 1 degree", () => { + const right = getAngleType(1); + assert.equal(right, "Acute angle"); +}); + + diff --git a/implement-and-rewrite-tests/implement/1-get-angle-type.js b/implement-and-rewrite-tests/implement/1-get-angle-type.js index 075560ee6..e86f5fff9 100644 --- a/implement-and-rewrite-tests/implement/1-get-angle-type.js +++ b/implement-and-rewrite-tests/implement/1-get-angle-type.js @@ -17,9 +17,13 @@ // execute the code to ensure all tests pass. export function getAngleType(angle) { - if (angle === 90){ + + if (angle >=1 && angle < 90){ + return "Acute angle"; + } else if (angle === 90){ return "Right angle"; } else { return "Invalid angle"; } + } From 36145c06db3eb2f10b0739d934d2ab155242c016 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Mon, 12 Oct 2026 13:58:15 +0100 Subject: [PATCH 04/53] Add test for acute 89 degree angle, function already passes --- .../1-get-angle-type.test.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js index f7a8e33a2..66085270b 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js @@ -16,9 +16,14 @@ test("Classifies invalid angle 0 degrees", () => { assert.equal(right, "Invalid angle"); }); -test("Classifies acute angle 1 degree", () => { +test("Classifies acute angle 1 degrees", () => { const right = getAngleType(1); assert.equal(right, "Acute angle"); }); +test("Classifies acute angle 89 degrees", () => { + const right = getAngleType(89); + assert.equal(right, "Acute angle"); +}); + From d41cebef9c1428c697e45fd47fa1c99f19dfab86 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Mon, 12 Oct 2026 14:01:16 +0100 Subject: [PATCH 05/53] Add test for obtuse 91 degree angle and update function to pass --- .../implement-tests-with-node-test/1-get-angle-type.test.js | 4 ++++ implement-and-rewrite-tests/implement/1-get-angle-type.js | 2 ++ 2 files changed, 6 insertions(+) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js index 66085270b..f68b43c61 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js @@ -26,4 +26,8 @@ test("Classifies acute angle 89 degrees", () => { assert.equal(right, "Acute angle"); }); +test("Classifies obtuse angle 91 degrees", () => { + const right = getAngleType(91); + assert.equal(right, "Obtuse angle"); +}); diff --git a/implement-and-rewrite-tests/implement/1-get-angle-type.js b/implement-and-rewrite-tests/implement/1-get-angle-type.js index e86f5fff9..2472ebadd 100644 --- a/implement-and-rewrite-tests/implement/1-get-angle-type.js +++ b/implement-and-rewrite-tests/implement/1-get-angle-type.js @@ -22,6 +22,8 @@ export function getAngleType(angle) { return "Acute angle"; } else if (angle === 90){ return "Right angle"; + } else if (angle > 90 && angle < 180){ + return "Obtuse angle" } else { return "Invalid angle"; } From 52463f479db02d1a62d4f28f540cb1a67d560f18 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Mon, 12 Oct 2026 14:03:46 +0100 Subject: [PATCH 06/53] Add test for obtuse 179 degree angle, function already passes --- .../implement-tests-with-node-test/1-get-angle-type.test.js | 5 +++++ implement-and-rewrite-tests/implement/1-get-angle-type.js | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js index f68b43c61..1ff9a2c38 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js @@ -31,3 +31,8 @@ test("Classifies obtuse angle 91 degrees", () => { assert.equal(right, "Obtuse angle"); }); +test("Classifies obtuse angle 179 degrees", () => { + const right = getAngleType(179); + assert.equal(right, "Obtuse angle"); +}); + diff --git a/implement-and-rewrite-tests/implement/1-get-angle-type.js b/implement-and-rewrite-tests/implement/1-get-angle-type.js index 2472ebadd..7668e98b2 100644 --- a/implement-and-rewrite-tests/implement/1-get-angle-type.js +++ b/implement-and-rewrite-tests/implement/1-get-angle-type.js @@ -18,7 +18,7 @@ export function getAngleType(angle) { - if (angle >=1 && angle < 90){ + if (angle > 0 && angle < 90){ return "Acute angle"; } else if (angle === 90){ return "Right angle"; From 3ff0de2c7d5f12e2254132fb738abda69c1ea183 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Mon, 12 Oct 2026 14:05:53 +0100 Subject: [PATCH 07/53] Add test for straight 180 degree angle and update function to pass --- .../implement-tests-with-node-test/1-get-angle-type.test.js | 4 ++++ implement-and-rewrite-tests/implement/1-get-angle-type.js | 2 ++ 2 files changed, 6 insertions(+) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js index 1ff9a2c38..1034465f5 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js @@ -36,3 +36,7 @@ test("Classifies obtuse angle 179 degrees", () => { assert.equal(right, "Obtuse angle"); }); +test("Classifies straight angle 180 degrees", () => { + const right = getAngleType(180); + assert.equal(right, "Straight angle"); +}); \ No newline at end of file diff --git a/implement-and-rewrite-tests/implement/1-get-angle-type.js b/implement-and-rewrite-tests/implement/1-get-angle-type.js index 7668e98b2..4ac26c156 100644 --- a/implement-and-rewrite-tests/implement/1-get-angle-type.js +++ b/implement-and-rewrite-tests/implement/1-get-angle-type.js @@ -24,6 +24,8 @@ export function getAngleType(angle) { return "Right angle"; } else if (angle > 90 && angle < 180){ return "Obtuse angle" + } else if (angle === 180){ + return "Straight angle"; } else { return "Invalid angle"; } From 0252cf1676200c4efc8051d598e0291dd3086673 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Mon, 12 Oct 2026 14:09:50 +0100 Subject: [PATCH 08/53] Add test for reflex 181 degree angle and update function to pass --- .../implement-tests-with-node-test/1-get-angle-type.test.js | 5 +++++ implement-and-rewrite-tests/implement/1-get-angle-type.js | 2 ++ 2 files changed, 7 insertions(+) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js index 1034465f5..43f51dc61 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js @@ -39,4 +39,9 @@ test("Classifies obtuse angle 179 degrees", () => { test("Classifies straight angle 180 degrees", () => { const right = getAngleType(180); assert.equal(right, "Straight angle"); +}); + +test("Classifies reflex angle 181 degrees", () => { + const right = getAngleType(181); + assert.equal(right, "Reflex angle"); }); \ No newline at end of file diff --git a/implement-and-rewrite-tests/implement/1-get-angle-type.js b/implement-and-rewrite-tests/implement/1-get-angle-type.js index 4ac26c156..4302d8f3a 100644 --- a/implement-and-rewrite-tests/implement/1-get-angle-type.js +++ b/implement-and-rewrite-tests/implement/1-get-angle-type.js @@ -26,6 +26,8 @@ export function getAngleType(angle) { return "Obtuse angle" } else if (angle === 180){ return "Straight angle"; + } else if (angle > 180 && angle < 360){ + return "Reflex angle"; } else { return "Invalid angle"; } From aab5bd4cdb60d63af1873ef05c7fdbcb357c66e7 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Mon, 12 Oct 2026 14:11:02 +0100 Subject: [PATCH 09/53] Add test for reflex 359 degree angle, function already passes --- .../implement-tests-with-node-test/1-get-angle-type.test.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js index 43f51dc61..66d4f11ae 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js @@ -44,4 +44,9 @@ test("Classifies straight angle 180 degrees", () => { test("Classifies reflex angle 181 degrees", () => { const right = getAngleType(181); assert.equal(right, "Reflex angle"); +}); + +test("Classifies reflex angle 359 degrees", () => { + const right = getAngleType(359); + assert.equal(right, "Reflex angle"); }); \ No newline at end of file From ad2c349f30c1598a633b0adce60f6017f69e61da Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Mon, 12 Oct 2026 14:12:31 +0100 Subject: [PATCH 10/53] Add test for invalid 360 degree angle, function already passes --- .../implement-tests-with-node-test/1-get-angle-type.test.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js index 66d4f11ae..436594780 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js @@ -49,4 +49,9 @@ test("Classifies reflex angle 181 degrees", () => { test("Classifies reflex angle 359 degrees", () => { const right = getAngleType(359); assert.equal(right, "Reflex angle"); +}); + +test("Classifies invalid angle 360 degrees", () => { + const right = getAngleType(360); + assert.equal(right, "Invalid angle"); }); \ No newline at end of file From d4feec55a3cfa053f6eaff5d1223382fb49228b1 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Mon, 12 Oct 2026 15:44:12 +0100 Subject: [PATCH 11/53] Implemented my function is proper fraction --- .../implement/2-is-proper-fraction.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/implement-and-rewrite-tests/implement/2-is-proper-fraction.js b/implement-and-rewrite-tests/implement/2-is-proper-fraction.js index f983800f0..2bb1b4a1e 100644 --- a/implement-and-rewrite-tests/implement/2-is-proper-fraction.js +++ b/implement-and-rewrite-tests/implement/2-is-proper-fraction.js @@ -14,5 +14,12 @@ // execute the code to ensure all tests pass. export function isProperFraction(numerator, denominator) { - // TODO: Implement this function + + const fraction = Math.absolute(numerator / denominator); + + if (fraction >= 0 && fraction < 1){ + return true; + } + + return false; } From 79cdd8a4f99e972f2f0111dbfa5aa98d1ff2f209 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Mon, 12 Oct 2026 15:47:55 +0100 Subject: [PATCH 12/53] Failed basic proper fraction and fixed the function so it now passes --- implement-and-rewrite-tests/implement/2-is-proper-fraction.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/implement-and-rewrite-tests/implement/2-is-proper-fraction.js b/implement-and-rewrite-tests/implement/2-is-proper-fraction.js index 2bb1b4a1e..0aa1a84cb 100644 --- a/implement-and-rewrite-tests/implement/2-is-proper-fraction.js +++ b/implement-and-rewrite-tests/implement/2-is-proper-fraction.js @@ -15,11 +15,11 @@ export function isProperFraction(numerator, denominator) { - const fraction = Math.absolute(numerator / denominator); + const fraction = Math.abs(numerator / denominator); if (fraction >= 0 && fraction < 1){ return true; } return false; -} +} \ No newline at end of file From 3a8d29eebe669254ac4f8853c11a04a8978bdd3d Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Mon, 12 Oct 2026 23:00:59 +0100 Subject: [PATCH 13/53] Add test for improper fraction, it passes --- .../2-is-proper-fraction.test.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js index a29084605..6c521e613 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js @@ -10,3 +10,7 @@ test("Basic proper fraction", () => { // Example: 1/2 is a proper fraction assert.equal(isProperFraction(1, 2), true); }); + +test("Basic improper fraction", () => { + assert.equal(isProperFraction(4, 2), false); +}); \ No newline at end of file From 6086f7649b100e51da0a66a442b8ca25203de845 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Mon, 12 Oct 2026 23:01:57 +0100 Subject: [PATCH 14/53] Add test for edge case improper fraction, it passes --- .../2-is-proper-fraction.test.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js index 6c521e613..f21af79e0 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js @@ -13,4 +13,8 @@ test("Basic proper fraction", () => { test("Basic improper fraction", () => { assert.equal(isProperFraction(4, 2), false); +}); + +test("Edge case improper fraction", () => { + assert.equal(isProperFraction(2, 2), false); }); \ No newline at end of file From 4f3db68b04a1521d7d10f498047b97af0cd628d1 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Mon, 12 Oct 2026 23:02:59 +0100 Subject: [PATCH 15/53] Add test for negative proper fraction, it passes --- .../2-is-proper-fraction.test.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js index f21af79e0..6db47503e 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js @@ -17,4 +17,8 @@ test("Basic improper fraction", () => { test("Edge case improper fraction", () => { assert.equal(isProperFraction(2, 2), false); +}); + +test("Negative proper fraction", () => { + assert.equal(isProperFraction(-5, 8), true); }); \ No newline at end of file From 5052e1cf64bcc17c5a8818b3afba97c7d6115374 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Mon, 12 Oct 2026 23:03:47 +0100 Subject: [PATCH 16/53] Add test for negative improper fraction, it passes --- .../2-is-proper-fraction.test.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js index 6db47503e..93a5b97d3 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js @@ -21,4 +21,8 @@ test("Edge case improper fraction", () => { test("Negative proper fraction", () => { assert.equal(isProperFraction(-5, 8), true); +}); + +test("Negative improper fraction", () => { + assert.equal(isProperFraction(-8, 5), false); }); \ No newline at end of file From e59a4ac6c5dae3795fb81fed862ba0b6ca29e4b4 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Tue, 13 Oct 2026 14:35:21 +0100 Subject: [PATCH 17/53] Wrote first draft of function, passes valid card test, not non-card string test --- .../implement/3-get-card-value.js | 32 ++++++++++++++++++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/implement-and-rewrite-tests/implement/3-get-card-value.js b/implement-and-rewrite-tests/implement/3-get-card-value.js index 9614ab1ee..a4500c7ce 100644 --- a/implement-and-rewrite-tests/implement/3-get-card-value.js +++ b/implement-and-rewrite-tests/implement/3-get-card-value.js @@ -24,5 +24,35 @@ // execute the code to ensure all tests pass. export function getCardValue(card) { - // TODO: Implement this function + const suitString = "♠♥♦♣"; + const rankString = "JQK"; + + if (card){ + const suit = card[card.length - 1]; + if (suitString.includes(suit)){ + const rank = card.slice(0,-1) + if (rank === "10"){ + return 10; + + } else if (rank.length === 1){ + + if (rank === "A"){ + return 11; + } + + if (rankString.includes(rank)){ + return 10; + } + + const rankNum = Number(rank); + + if (rankNum >= 2){ + return rankNum; + } + } + } + } + + throw new Error("Card string isn't valid"); + } From 6656eb2c3373944fa854fbefa8a48819396e5781 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Tue, 13 Oct 2026 22:30:18 +0100 Subject: [PATCH 18/53] Changed error message so function passes second test --- implement-and-rewrite-tests/implement/3-get-card-value.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/implement-and-rewrite-tests/implement/3-get-card-value.js b/implement-and-rewrite-tests/implement/3-get-card-value.js index a4500c7ce..098217989 100644 --- a/implement-and-rewrite-tests/implement/3-get-card-value.js +++ b/implement-and-rewrite-tests/implement/3-get-card-value.js @@ -53,6 +53,6 @@ export function getCardValue(card) { } } - throw new Error("Card string isn't valid"); + throw new Error(`/Expected a number followed by a suit, but got "${card}"/`); } From 8efb17d6b7554f672d620aa6cfc15cbf54c537da Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Tue, 13 Oct 2026 22:33:57 +0100 Subject: [PATCH 19/53] =?UTF-8?q?Add=20test=20for=2019=E2=99=A0,=20throws?= =?UTF-8?q?=20error,=20test=20passes?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../3-get-card-value.test.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js index f5092d9b1..b756177ca 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js @@ -14,3 +14,11 @@ test("Arbitrary non-card string", () => { }); // TODO: What other invalid card cases can you think of? + +test("Arbitrary non-card string '19♠'", () => { + assert.throws( + () => getCardValue("19♠"), + /Expected a number followed by a suit, but got "19♠"/, + "Expected clear error" + ); +}); \ No newline at end of file From 96fb07844f08f599c4797fc74a02eebb8dd3c509 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Tue, 13 Oct 2026 22:35:15 +0100 Subject: [PATCH 20/53] =?UTF-8?q?Add=20test=20for=20'P=E2=99=A6',=20test?= =?UTF-8?q?=20passes?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../3-get-card-value.test.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js index b756177ca..1ff07f29d 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js @@ -21,4 +21,12 @@ test("Arbitrary non-card string '19♠'", () => { /Expected a number followed by a suit, but got "19♠"/, "Expected clear error" ); +}); + +test("Arbitrary non-card string 'P♦'", () => { + assert.throws( + () => getCardValue("P♦"), + /Expected a number followed by a suit, but got "P♦"/, + "Expected clear error" + ); }); \ No newline at end of file From e9444cd3ea73a3cc23f5c69809d2279190c93241 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 13:21:07 +0100 Subject: [PATCH 21/53] =?UTF-8?q?Add=20test=20for=20invalid=20's=E2=99=A6'?= =?UTF-8?q?,=20test=20passes?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../3-get-card-value.test.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js index 1ff07f29d..4b063ed41 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js @@ -29,4 +29,12 @@ test("Arbitrary non-card string 'P♦'", () => { /Expected a number followed by a suit, but got "P♦"/, "Expected clear error" ); +}); + +test("Arbitrary non-card string 's♦'", () => { + assert.throws( + () => getCardValue("s♦"), + /Expected a number followed by a suit, but got "s♦"/, + "Expected clear error" + ); }); \ No newline at end of file From de0efffd8f53cd0efce2b9351912298d31deb338 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 13:22:03 +0100 Subject: [PATCH 22/53] =?UTF-8?q?Add=20test=20for=20invalid=20'soUp?= =?UTF-8?q?=E2=99=A6',=20test=20passes?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../3-get-card-value.test.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js index 4b063ed41..599a42b56 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js @@ -37,4 +37,12 @@ test("Arbitrary non-card string 's♦'", () => { /Expected a number followed by a suit, but got "s♦"/, "Expected clear error" ); +}); + +test("Arbitrary non-card string 'sOup♦'", () => { + assert.throws( + () => getCardValue("soUp♦"), + /Expected a number followed by a suit, but got "soUp♦"/, + "Expected clear error" + ); }); \ No newline at end of file From 16db07cbe39e96f3a1e84e4f49934164bcb5a879 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 13:23:13 +0100 Subject: [PATCH 23/53] =?UTF-8?q?Add=20test=20for=20invalid=20'-3=E2=99=A6?= =?UTF-8?q?',=20test=20passes?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../3-get-card-value.test.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js index 599a42b56..74418d04d 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js @@ -45,4 +45,12 @@ test("Arbitrary non-card string 'sOup♦'", () => { /Expected a number followed by a suit, but got "soUp♦"/, "Expected clear error" ); +}); + +test("Arbitrary non-card string '-3♦'", () => { + assert.throws( + () => getCardValue("-3♦"), + /Expected a number followed by a suit, but got "-3♦"/, + "Expected clear error" + ); }); \ No newline at end of file From 2f33741cacab2312b0fd07c3768003a199a148a9 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 13:24:35 +0100 Subject: [PATCH 24/53] Add test for invalid '5', test passes --- .../3-get-card-value.test.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js index 74418d04d..af948b212 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js @@ -53,4 +53,12 @@ test("Arbitrary non-card string '-3♦'", () => { /Expected a number followed by a suit, but got "-3♦"/, "Expected clear error" ); +}); + +test("Arbitrary non-card string '5'", () => { + assert.throws( + () => getCardValue("5"), + /Expected a number followed by a suit, but got "5"/, + "Expected clear error" + ); }); \ No newline at end of file From ea29e283090c2935211215110f0f12443aee36c1 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 13:25:19 +0100 Subject: [PATCH 25/53] Add test for invalid 'Q', test passes --- .../3-get-card-value.test.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js index af948b212..1d85a9005 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js @@ -61,4 +61,12 @@ test("Arbitrary non-card string '5'", () => { /Expected a number followed by a suit, but got "5"/, "Expected clear error" ); +}); + +test("Arbitrary non-card string 'Q'", () => { + assert.throws( + () => getCardValue("Q"), + /Expected a number followed by a suit, but got "Q"/, + "Expected clear error" + ); }); \ No newline at end of file From 0a1c1b474716649fde1376b316d8528542c43bae Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 13:28:35 +0100 Subject: [PATCH 26/53] =?UTF-8?q?Add=20test=20for=20valid=20'A=E2=99=A3',?= =?UTF-8?q?=20test=20passes?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../implement-tests-with-node-test/3-get-card-value.test.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js index 1d85a9005..e0f8b1119 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js @@ -69,4 +69,10 @@ test("Arbitrary non-card string 'Q'", () => { /Expected a number followed by a suit, but got "Q"/, "Expected clear error" ); +}); + +//Valid cases + +test("Valid card 'A♣'", () => { + assert.equal(getCardValue("A♣"), 11); }); \ No newline at end of file From f0f349f52a9993a84ed74771b299237f34dca8c4 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 13:30:20 +0100 Subject: [PATCH 27/53] =?UTF-8?q?Add=20test=20for=20valid=20'10=E2=99=A3',?= =?UTF-8?q?=20test=20passes?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../implement-tests-with-node-test/3-get-card-value.test.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js index e0f8b1119..205d4ba73 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js @@ -75,4 +75,8 @@ test("Arbitrary non-card string 'Q'", () => { test("Valid card 'A♣'", () => { assert.equal(getCardValue("A♣"), 11); +}); + +test("Valid card '10♣'", () => { + assert.equal(getCardValue("10♣"), 10); }); \ No newline at end of file From ba1b297163e6355a9991800b4a238961075ac785 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 13:31:13 +0100 Subject: [PATCH 28/53] =?UTF-8?q?Add=20test=20for=20valid=20'K=E2=99=A0',?= =?UTF-8?q?=20test=20passes?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../implement-tests-with-node-test/3-get-card-value.test.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js index 205d4ba73..57d7677ed 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js @@ -79,4 +79,8 @@ test("Valid card 'A♣'", () => { test("Valid card '10♣'", () => { assert.equal(getCardValue("10♣"), 10); +}); + +test("Valid card 'K♠'", () => { + assert.equal(getCardValue("K♠"), 10); }); \ No newline at end of file From a451ef895505d6600e94b0bd6948d3f701bd66f9 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 13:34:04 +0100 Subject: [PATCH 29/53] Change to suitable variable names in tests --- .../1-get-angle-type.test.js | 36 +++++++++---------- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js index 436594780..1096d2381 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js @@ -12,46 +12,46 @@ test("Classifies right angles", () => { }); test("Classifies invalid angle 0 degrees", () => { - const right = getAngleType(0); - assert.equal(right, "Invalid angle"); + const invalid = getAngleType(0); + assert.equal(invalid, "Invalid angle"); }); test("Classifies acute angle 1 degrees", () => { - const right = getAngleType(1); - assert.equal(right, "Acute angle"); + const acute = getAngleType(1); + assert.equal(acute, "Acute angle"); }); test("Classifies acute angle 89 degrees", () => { - const right = getAngleType(89); - assert.equal(right, "Acute angle"); + const acute = getAngleType(89); + assert.equal(acute, "Acute angle"); }); test("Classifies obtuse angle 91 degrees", () => { - const right = getAngleType(91); - assert.equal(right, "Obtuse angle"); + const obtuse = getAngleType(91); + assert.equal(obtuse, "Obtuse angle"); }); test("Classifies obtuse angle 179 degrees", () => { - const right = getAngleType(179); - assert.equal(right, "Obtuse angle"); + const obtuse = getAngleType(179); + assert.equal(obtuse, "Obtuse angle"); }); test("Classifies straight angle 180 degrees", () => { - const right = getAngleType(180); - assert.equal(right, "Straight angle"); + const straight = getAngleType(180); + assert.equal(straight, "Straight angle"); }); test("Classifies reflex angle 181 degrees", () => { - const right = getAngleType(181); - assert.equal(right, "Reflex angle"); + const reflex = getAngleType(181); + assert.equal(reflex, "Reflex angle"); }); test("Classifies reflex angle 359 degrees", () => { - const right = getAngleType(359); - assert.equal(right, "Reflex angle"); + const reflex = getAngleType(359); + assert.equal(reflex, "Reflex angle"); }); test("Classifies invalid angle 360 degrees", () => { - const right = getAngleType(360); - assert.equal(right, "Invalid angle"); + const invalid = getAngleType(360); + assert.equal(invalid, "Invalid angle"); }); \ No newline at end of file From 57095e09bb4a88bb3ac5270c3b0b7fed72c83ef5 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 15:46:25 +0100 Subject: [PATCH 30/53] Add jest test for right angle, it passes --- .../rewrite-tests-with-jest/1-get-angle-type.test.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js index e0ba786ab..0003eed0e 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js @@ -4,6 +4,7 @@ import { getAngleType } from "../implement/1-get-angle-type.js"; // including boundary and invalid cases. // Case 1: Acute angles + test(`should return "Acute angle" when (0 < angle < 90)`, () => { // Test various acute angles, including boundary cases expect(getAngleType(1)).toEqual("Acute angle"); @@ -12,6 +13,11 @@ test(`should return "Acute angle" when (0 < angle < 90)`, () => { }); // Case 2: Right angle + +test(`should return "Right angle" when (angle = 90)`, () => { + expect(getAngleType(90)).toEqual("Right angle"); +}); + // Case 3: Obtuse angles // Case 4: Straight angle // Case 5: Reflex angles From 0c0519ed7b81cb76d15193d9e79ae90a1a24aeda Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 15:51:17 +0100 Subject: [PATCH 31/53] Add jest tests for obtuse angles, they pass --- .../rewrite-tests-with-jest/1-get-angle-type.test.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js index 0003eed0e..ca7cb75ec 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js @@ -19,6 +19,13 @@ test(`should return "Right angle" when (angle = 90)`, () => { }); // Case 3: Obtuse angles + +test(`should return "Obtuse angle" when (90 < angle < 180)`, () => { + expect(getAngleType(91)).toEqual("Obtuse angle"); + expect(getAngleType(135)).toEqual("Obtuse angle"); + expect(getAngleType(179)).toEqual("Obtuse angle"); +}); + // Case 4: Straight angle // Case 5: Reflex angles // Case 6: Invalid angles From 07f9f45b2b3a773c0e730daa3f7bfe74cf427418 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 15:53:06 +0100 Subject: [PATCH 32/53] Add jest test for straight angle, it passes --- .../rewrite-tests-with-jest/1-get-angle-type.test.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js index ca7cb75ec..f59d02728 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js @@ -27,5 +27,10 @@ test(`should return "Obtuse angle" when (90 < angle < 180)`, () => { }); // Case 4: Straight angle + +test(`should return "Straight angle" when (angle = 180)`, () => { + expect(getAngleType(180)).toEqual("Straight angle"); +}); + // Case 5: Reflex angles // Case 6: Invalid angles From 42061e26c506db9f79c71943fbe582982f162e95 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 15:54:24 +0100 Subject: [PATCH 33/53] Add jest tests for Reflex angles, they pass --- .../rewrite-tests-with-jest/1-get-angle-type.test.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js index f59d02728..e95537cc9 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js @@ -33,4 +33,11 @@ test(`should return "Straight angle" when (angle = 180)`, () => { }); // Case 5: Reflex angles + +test(`should return "Reflex angle" when (180 < angle < 360)`, () => { + expect(getAngleType(181)).toEqual("Reflex angle"); + expect(getAngleType(270)).toEqual("Reflex angle"); + expect(getAngleType(359)).toEqual("Reflex angle"); +}); + // Case 6: Invalid angles From 42ae1fa6fe0e6ccd26f06cd9932c553928ef511e Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 15:56:18 +0100 Subject: [PATCH 34/53] Add jes tests for invalid angles, they pass --- .../rewrite-tests-with-jest/1-get-angle-type.test.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js index e95537cc9..1847517b5 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js @@ -41,3 +41,10 @@ test(`should return "Reflex angle" when (180 < angle < 360)`, () => { }); // Case 6: Invalid angles + +test(`should return "Invalid angle" when (angle =< 0 and angle >= 360)`, () => { + expect(getAngleType(0)).toEqual("Invalid angle"); + expect(getAngleType(-1)).toEqual("Invalid angle"); + expect(getAngleType(360)).toEqual("Invalid angle"); + expect(getAngleType(361)).toEqual("Invalid angle"); +}); From aa567321c1b3d5a59c29217576118ee2c77da09e Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 16:17:40 +0100 Subject: [PATCH 35/53] Add jest test for passed 1 and 2 return true, test passes --- .../rewrite-tests-with-jest/2-is-proper-fraction.test.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js index 5d49e2d8b..f3da0051d 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js @@ -6,3 +6,7 @@ import { isProperFraction } from "../implement/2-is-proper-fraction.js"; test(`should return false when denominator is zero`, () => { expect(isProperFraction(1, 0)).toEqual(false); }); + +test(`should return true when 1 and 2 is passed`, () => { + expect(isProperFraction(1, 2)).toEqual(true); +}); From bc669acb914f6a3748b20b0803438c101f1cc070 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 16:18:49 +0100 Subject: [PATCH 36/53] Add jest test for passed 4 and 2 returns false, test passes --- .../rewrite-tests-with-jest/2-is-proper-fraction.test.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js index f3da0051d..f02e27438 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js @@ -10,3 +10,7 @@ test(`should return false when denominator is zero`, () => { test(`should return true when 1 and 2 is passed`, () => { expect(isProperFraction(1, 2)).toEqual(true); }); + +test(`should return false when 4 and 2 is passed`, () => { + expect(isProperFraction(4, 2)).toEqual(false); +}); From 543fbecada222313eaf823665f05d5c355081a16 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 16:19:50 +0100 Subject: [PATCH 37/53] Add jest test for passed 2 and 2 returns false, test passes --- .../rewrite-tests-with-jest/2-is-proper-fraction.test.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js index f02e27438..dce06b866 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js @@ -14,3 +14,7 @@ test(`should return true when 1 and 2 is passed`, () => { test(`should return false when 4 and 2 is passed`, () => { expect(isProperFraction(4, 2)).toEqual(false); }); + +test(`should return false when edge case 2 and 2 is passed`, () => { + expect(isProperFraction(2, 2)).toEqual(false); +}); \ No newline at end of file From add0f70651fe2b8bb422bea4a4decbf8e338e0b4 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 16:20:39 +0100 Subject: [PATCH 38/53] Add jest test for passes -5 and 8 returns true, test passes --- .../rewrite-tests-with-jest/2-is-proper-fraction.test.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js index dce06b866..40ff709ef 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js @@ -17,4 +17,8 @@ test(`should return false when 4 and 2 is passed`, () => { test(`should return false when edge case 2 and 2 is passed`, () => { expect(isProperFraction(2, 2)).toEqual(false); +}); + +test(`should return true when -5 and 8 is passed`, () => { + expect(isProperFraction(-5, 8)).toEqual(true); }); \ No newline at end of file From 17305f802372970d8a6dc13554511f2ab289ee41 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 16:22:26 +0100 Subject: [PATCH 39/53] Add jest test for passes -8 and 5 returns false, test passes --- .../rewrite-tests-with-jest/2-is-proper-fraction.test.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js index 40ff709ef..62d8b95c6 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js @@ -21,4 +21,8 @@ test(`should return false when edge case 2 and 2 is passed`, () => { test(`should return true when -5 and 8 is passed`, () => { expect(isProperFraction(-5, 8)).toEqual(true); +}); + +test(`should return false when -8 and 5 is passed`, () => { + expect(isProperFraction(-8, 5)).toEqual(false); }); \ No newline at end of file From 666eb6c25fdca1fb5acc1f02f63ceb9ea156ad2c Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 16:24:00 +0100 Subject: [PATCH 40/53] Add jest test for passes 0 and 5 returns true, test passes --- .../rewrite-tests-with-jest/2-is-proper-fraction.test.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js index 62d8b95c6..763af9dda 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js @@ -25,4 +25,8 @@ test(`should return true when -5 and 8 is passed`, () => { test(`should return false when -8 and 5 is passed`, () => { expect(isProperFraction(-8, 5)).toEqual(false); +}); + +test(`should return true when 0 and 5 is passed`, () => { + expect(isProperFraction(0, 5)).toEqual(true); }); \ No newline at end of file From 6c1c939cc585cd610bd6ddded29e8729d1361b73 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 16:24:57 +0100 Subject: [PATCH 41/53] Add jest test for passes 3 and -7 returns true, test passes --- .../rewrite-tests-with-jest/2-is-proper-fraction.test.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js index 763af9dda..951af2dc5 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js @@ -29,4 +29,8 @@ test(`should return false when -8 and 5 is passed`, () => { test(`should return true when 0 and 5 is passed`, () => { expect(isProperFraction(0, 5)).toEqual(true); +}); + +test(`should return true when 3 and -7 is passed`, () => { + expect(isProperFraction(3, -7)).toEqual(true); }); \ No newline at end of file From a00da07b3be8be84486ac7341cc0de5c1a8a8534 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 16:54:37 +0100 Subject: [PATCH 42/53] =?UTF-8?q?Add=20jest=20test=20for=20valid=20card=20?= =?UTF-8?q?'10=E2=99=A3',=20it=20passes?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../rewrite-tests-with-jest/3-get-card-value.test.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js index a6de5a82a..8017a7dc7 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js @@ -9,6 +9,11 @@ test(`Should return 11 when given an ace card`, () => { // Suggestion: Group the remaining test data into these categories: // Number Cards (2-10) + +test(`Should return 10 when given '10♣' `, () => { + expect(getCardValue("10♣")).toEqual(10); +}); + // Face Cards (J, Q, K) // Invalid Cards From a3974ae5a76531095c0a8a281b5b332d6134eca9 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 16:56:21 +0100 Subject: [PATCH 43/53] =?UTF-8?q?Add=20jest=20test=20for=20valid=20card=20?= =?UTF-8?q?'K=E2=99=A0',=20test=20passes?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../rewrite-tests-with-jest/3-get-card-value.test.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js index 8017a7dc7..74948e404 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js @@ -15,6 +15,11 @@ test(`Should return 10 when given '10♣' `, () => { }); // Face Cards (J, Q, K) + +test(`Should return 10 when given 'K♠' `, () => { + expect(getCardValue("K♠")).toEqual(10); +}); + // Invalid Cards // To learn how to test whether a function throws an error as expected in Jest, From 247bf0d38f7907d835e43d03b3bcdd48e4cbb4d4 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 16:57:35 +0100 Subject: [PATCH 44/53] =?UTF-8?q?Add=20jest=20test=20for=20valid=20card=20?= =?UTF-8?q?'A=E2=99=A3',=20test=20passes?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../rewrite-tests-with-jest/3-get-card-value.test.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js index 74948e404..bf017976a 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js @@ -20,6 +20,10 @@ test(`Should return 10 when given 'K♠' `, () => { expect(getCardValue("K♠")).toEqual(10); }); +test(`Should return 11 when given 'A♣'`, () => { + expect(getCardValue("A♣")).toEqual(11); +}); + // Invalid Cards // To learn how to test whether a function throws an error as expected in Jest, From 51a2b3806ded80f992d80b4f220bc717baf43168 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 17:06:29 +0100 Subject: [PATCH 45/53] Add jest test for invalid card 'invalid', throws error, test passes --- .../rewrite-tests-with-jest/3-get-card-value.test.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js index bf017976a..10d4512d8 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js @@ -26,6 +26,12 @@ test(`Should return 11 when given 'A♣'`, () => { // Invalid Cards +test(`Should throw error when given 'invalid'`, () => { + expect(() => { + getCardValue("invalid"); + }).toThrow(/Expected a number followed by a suit, but got "invalid"/); +}); + // To learn how to test whether a function throws an error as expected in Jest, // please refer to the Jest documentation: // https://jestjs.io/docs/expect#tothrowerror From 856b86107a385331499060c87b8e3f8bfe76bd0f Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 17:09:10 +0100 Subject: [PATCH 46/53] =?UTF-8?q?Add=20jest=20test=20for=20invalid=20card?= =?UTF-8?q?=20'19=E2=99=A0',=20throws=20error,=20test=20passes?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../rewrite-tests-with-jest/3-get-card-value.test.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js index 10d4512d8..ce924fd59 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js @@ -32,6 +32,12 @@ test(`Should throw error when given 'invalid'`, () => { }).toThrow(/Expected a number followed by a suit, but got "invalid"/); }); +test(`Should throw error when given '19♠'`, () => { + expect(() => { + getCardValue("19♠"); + }).toThrow(/Expected a number followed by a suit, but got "19♠"/); +}); + // To learn how to test whether a function throws an error as expected in Jest, // please refer to the Jest documentation: // https://jestjs.io/docs/expect#tothrowerror From d89b7c35bcae5f10b8b05e8041b88740e1eed64c Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 17:10:51 +0100 Subject: [PATCH 47/53] =?UTF-8?q?Add=20jest=20test=20for=20invalid=20card?= =?UTF-8?q?=20'P=E2=99=A6',=20throws=20error,=20test=20passes?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../rewrite-tests-with-jest/3-get-card-value.test.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js index ce924fd59..bb1e5676f 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js @@ -38,6 +38,12 @@ test(`Should throw error when given '19♠'`, () => { }).toThrow(/Expected a number followed by a suit, but got "19♠"/); }); +test(`Should throw error when given 'P♦'`, () => { + expect(() => { + getCardValue("P♦"); + }).toThrow(/Expected a number followed by a suit, but got "P♦"/); +}); + // To learn how to test whether a function throws an error as expected in Jest, // please refer to the Jest documentation: // https://jestjs.io/docs/expect#tothrowerror From bd931e338588386607964f00c72df98008736b85 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 17:11:37 +0100 Subject: [PATCH 48/53] =?UTF-8?q?Add=20jest=20test=20for=20invalid=20card?= =?UTF-8?q?=20's=E2=99=A6',=20throws=20error,=20test=20passes?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../rewrite-tests-with-jest/3-get-card-value.test.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js index bb1e5676f..1f5380053 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js @@ -44,6 +44,12 @@ test(`Should throw error when given 'P♦'`, () => { }).toThrow(/Expected a number followed by a suit, but got "P♦"/); }); +test(`Should throw error when given 's♦'`, () => { + expect(() => { + getCardValue("s♦"); + }).toThrow(/Expected a number followed by a suit, but got "s♦"/); +}); + // To learn how to test whether a function throws an error as expected in Jest, // please refer to the Jest documentation: // https://jestjs.io/docs/expect#tothrowerror From 9fc54cf75b342c330e1f34a559d0717f6bd3cb05 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 17:12:16 +0100 Subject: [PATCH 49/53] =?UTF-8?q?Add=20jest=20test=20for=20invalid=20card?= =?UTF-8?q?=20'sOup=E2=99=A6',=20throws=20error,=20test=20passes?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../rewrite-tests-with-jest/3-get-card-value.test.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js index 1f5380053..535a12f00 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js @@ -50,6 +50,13 @@ test(`Should throw error when given 's♦'`, () => { }).toThrow(/Expected a number followed by a suit, but got "s♦"/); }); +test(`Should throw error when given 'sOup♦'`, () => { + expect(() => { + getCardValue("sOup♦"); + }).toThrow(/Expected a number followed by a suit, but got "sOup♦"/); +}); + + // To learn how to test whether a function throws an error as expected in Jest, // please refer to the Jest documentation: // https://jestjs.io/docs/expect#tothrowerror From 1f7930b4742ce312e3ba51241bff34dca5c95f44 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 17:13:14 +0100 Subject: [PATCH 50/53] =?UTF-8?q?Add=20jest=20test=20fir=20invalid=20card?= =?UTF-8?q?=20'-3=E2=99=A6',=20throws=20error,=20test=20passes?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../rewrite-tests-with-jest/3-get-card-value.test.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js index 535a12f00..0252d7993 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js @@ -56,6 +56,11 @@ test(`Should throw error when given 'sOup♦'`, () => { }).toThrow(/Expected a number followed by a suit, but got "sOup♦"/); }); +test(`Should throw error when given '-3♦'`, () => { + expect(() => { + getCardValue("-3♦"); + }).toThrow(/Expected a number followed by a suit, but got "-3♦"/); +}); // To learn how to test whether a function throws an error as expected in Jest, // please refer to the Jest documentation: From ead0e96acecbbb54687abbcabb2ffec4821af885 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 17:13:54 +0100 Subject: [PATCH 51/53] Add jest test for invalid card '5', throws error, test passes --- .../rewrite-tests-with-jest/3-get-card-value.test.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js index 0252d7993..d2f83cc41 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js @@ -62,6 +62,12 @@ test(`Should throw error when given '-3♦'`, () => { }).toThrow(/Expected a number followed by a suit, but got "-3♦"/); }); +test(`Should throw error when given '5'`, () => { + expect(() => { + getCardValue("5"); + }).toThrow(/Expected a number followed by a suit, but got "5"/); +}); + // To learn how to test whether a function throws an error as expected in Jest, // please refer to the Jest documentation: // https://jestjs.io/docs/expect#tothrowerror From fafb4c46ae4ffe28fcd270198f57dd614dc88984 Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 17:14:30 +0100 Subject: [PATCH 52/53] Add jest test for invalid card 'Q', throws error, test passes --- .../rewrite-tests-with-jest/3-get-card-value.test.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js index d2f83cc41..aea8d10c0 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js @@ -68,6 +68,12 @@ test(`Should throw error when given '5'`, () => { }).toThrow(/Expected a number followed by a suit, but got "5"/); }); +test(`Should throw error when given 'Q'`, () => { + expect(() => { + getCardValue("Q"); + }).toThrow(/Expected a number followed by a suit, but got "Q"/); +}); + // To learn how to test whether a function throws an error as expected in Jest, // please refer to the Jest documentation: // https://jestjs.io/docs/expect#tothrowerror From 9737d0883bd4911b7e89abe7d00d6b947036a3bb Mon Sep 17 00:00:00 2001 From: Hanna Bohlin Date: Wed, 14 Oct 2026 17:16:06 +0100 Subject: [PATCH 53/53] Format all files with prettier --- .../1-get-angle-type.test.js | 2 +- .../2-is-proper-fraction.test.js | 2 +- .../3-get-card-value.test.js | 8 +++++-- .../implement/1-get-angle-type.js | 14 ++++++------- .../implement/2-is-proper-fraction.js | 5 ++--- .../implement/3-get-card-value.js | 21 ++++++++----------- .../2-is-proper-fraction.test.js | 2 +- .../3-get-card-value.test.js | 1 - 8 files changed, 26 insertions(+), 29 deletions(-) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js index 1096d2381..dfe8793c3 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js @@ -54,4 +54,4 @@ test("Classifies reflex angle 359 degrees", () => { test("Classifies invalid angle 360 degrees", () => { const invalid = getAngleType(360); assert.equal(invalid, "Invalid angle"); -}); \ No newline at end of file +}); diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js index 93a5b97d3..f6b7464c9 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js @@ -25,4 +25,4 @@ test("Negative proper fraction", () => { test("Negative improper fraction", () => { assert.equal(isProperFraction(-8, 5), false); -}); \ No newline at end of file +}); diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js index 57d7677ed..ee8770784 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js @@ -10,7 +10,11 @@ test("Valid single-digit card", () => { }); test("Arbitrary non-card string", () => { - assert.throws(() => getCardValue("invalid"), /Expected a number followed by a suit, but got "invalid"/, "Expected clear error"); + assert.throws( + () => getCardValue("invalid"), + /Expected a number followed by a suit, but got "invalid"/, + "Expected clear error" + ); }); // TODO: What other invalid card cases can you think of? @@ -83,4 +87,4 @@ test("Valid card '10♣'", () => { test("Valid card 'K♠'", () => { assert.equal(getCardValue("K♠"), 10); -}); \ No newline at end of file +}); diff --git a/implement-and-rewrite-tests/implement/1-get-angle-type.js b/implement-and-rewrite-tests/implement/1-get-angle-type.js index 4302d8f3a..21898423d 100644 --- a/implement-and-rewrite-tests/implement/1-get-angle-type.js +++ b/implement-and-rewrite-tests/implement/1-get-angle-type.js @@ -17,19 +17,17 @@ // execute the code to ensure all tests pass. export function getAngleType(angle) { - - if (angle > 0 && angle < 90){ + if (angle > 0 && angle < 90) { return "Acute angle"; - } else if (angle === 90){ + } else if (angle === 90) { return "Right angle"; - } else if (angle > 90 && angle < 180){ - return "Obtuse angle" - } else if (angle === 180){ + } else if (angle > 90 && angle < 180) { + return "Obtuse angle"; + } else if (angle === 180) { return "Straight angle"; - } else if (angle > 180 && angle < 360){ + } else if (angle > 180 && angle < 360) { return "Reflex angle"; } else { return "Invalid angle"; } - } diff --git a/implement-and-rewrite-tests/implement/2-is-proper-fraction.js b/implement-and-rewrite-tests/implement/2-is-proper-fraction.js index 0aa1a84cb..6029ae39a 100644 --- a/implement-and-rewrite-tests/implement/2-is-proper-fraction.js +++ b/implement-and-rewrite-tests/implement/2-is-proper-fraction.js @@ -14,12 +14,11 @@ // execute the code to ensure all tests pass. export function isProperFraction(numerator, denominator) { - const fraction = Math.abs(numerator / denominator); - if (fraction >= 0 && fraction < 1){ + if (fraction >= 0 && fraction < 1) { return true; } return false; -} \ No newline at end of file +} diff --git a/implement-and-rewrite-tests/implement/3-get-card-value.js b/implement-and-rewrite-tests/implement/3-get-card-value.js index 098217989..a2f75ea80 100644 --- a/implement-and-rewrite-tests/implement/3-get-card-value.js +++ b/implement-and-rewrite-tests/implement/3-get-card-value.js @@ -26,27 +26,25 @@ export function getCardValue(card) { const suitString = "♠♥♦♣"; const rankString = "JQK"; - - if (card){ + + if (card) { const suit = card[card.length - 1]; - if (suitString.includes(suit)){ - const rank = card.slice(0,-1) - if (rank === "10"){ + if (suitString.includes(suit)) { + const rank = card.slice(0, -1); + if (rank === "10") { return 10; - - } else if (rank.length === 1){ - - if (rank === "A"){ + } else if (rank.length === 1) { + if (rank === "A") { return 11; } - if (rankString.includes(rank)){ + if (rankString.includes(rank)) { return 10; } const rankNum = Number(rank); - if (rankNum >= 2){ + if (rankNum >= 2) { return rankNum; } } @@ -54,5 +52,4 @@ export function getCardValue(card) { } throw new Error(`/Expected a number followed by a suit, but got "${card}"/`); - } diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js index 951af2dc5..420df9243 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js @@ -33,4 +33,4 @@ test(`should return true when 0 and 5 is passed`, () => { test(`should return true when 3 and -7 is passed`, () => { expect(isProperFraction(3, -7)).toEqual(true); -}); \ No newline at end of file +}); diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js index aea8d10c0..1fe252cbf 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js @@ -77,4 +77,3 @@ test(`Should throw error when given 'Q'`, () => { // To learn how to test whether a function throws an error as expected in Jest, // please refer to the Jest documentation: // https://jestjs.io/docs/expect#tothrowerror -