I re-edited the finction and tests to match and run the test on node and it passed

Author: Mona-Eltantawy

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -11,11 +11,11 @@
 // execute the code to ensure all tests pass.
 
 function isProperFraction(numerator, denominator) {
-  if (denominator === 0) return false;
+  if (denominator <= 0) return false;
+  if (numerator < 0) return false;
 
-  return Math.abs(numerator) < Math.abs(denominator);
+  return numerator < denominator;
 }
-
 // TODO: Implement this function
 
 // The line below allows us to load the isProperFraction function into tests in other files.
@@ -26,7 +26,7 @@ module.exports = isProperFraction;
 function assertEquals(actualOutput, targetOutput) {
   console.assert(
     actualOutput === targetOutput,
-    `Expected ${actualOutput} to equal ${targetOutput}`
+    `Expected ${actualOutput} toBe ${targetOutput}`
   );
 }
 

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -1,43 +1,41 @@
-// This statement loads the isProperFraction function you wrote in the implement directory.
-// We will use the same function, but write tests for it using Jest in this file.
 const isProperFraction = require("../implement/2-is-proper-fraction");
 
 // denominator is zero
 test("should return false when denominator is zero", () => {
-  expect(isProperFraction(1, 0)).toEqual(false);
+  expect(isProperFraction(1, 0)).toBe(false);
 });
 
-// proper fraction (numerator < denominator)
+// proper fraction
 test("should return true when numerator < denominator", () => {
-  expect(isProperFraction(1, 2)).toEqual(true);
+  expect(isProperFraction(1, 2)).toBe(true);
 });
 
-// improper fraction (numerator > denominator)
+// improper fraction
 test("should return false when numerator > denominator", () => {
-  expect(isProperFraction(5, 3)).toEqual(false);
+  expect(isProperFraction(5, 3)).toBe(false);
 });
 
 // equal numbers
 test("should return false when numerator === denominator", () => {
-  expect(isProperFraction(4, 4)).toEqual(false);
+  expect(isProperFraction(4, 4)).toBe(false);
 });
 
 // numerator is zero
 test("should return true when numerator is zero and denominator is positive", () => {
-  expect(isProperFraction(0, 5)).toEqual(true);
+  expect(isProperFraction(0, 5)).toBe(true);
 });
 
 // negative numerator
 test("should return false when numerator is negative", () => {
-  expect(isProperFraction(-2, 4)).toEqual(false);
+  expect(isProperFraction(-2, 4)).toBe(false);
 });
 
 // negative denominator
 test("should return false when denominator is negative", () => {
-  expect(isProperFraction(5, -4)).toEqual(false);
+  expect(isProperFraction(5, -4)).toBe(false);
 });
 
 // both negative
 test("should return false when both numerator and denominator are negative", () => {
-  expect(isProperFraction(-3, -5)).toEqual(false);
+  expect(isProperFraction(-3, -5)).toBe(false);
 });