Added tests for:

letter for suite - incorrect
Lower case - incorrect
No input

Author: HM-127BTY

implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js

@@ -18,7 +18,7 @@ test("Arbitrary non-card string", () => {
 });
 
 // TODO: What other invalid card cases can you think of?
-//Incorrect suit
+//Incorrect suit as symbol
 test("Incorrect suit", () => {
   assert.throws(
     () => getCardValue("2☺"),
@@ -27,6 +27,15 @@ test("Incorrect suit", () => {
   );
 });
 
+//Incorrect suit as letter
+test("Incorrect suit", () => {
+  assert.throws(
+    () => getCardValue("7l"),
+    /Incorrect suit given/,
+    "Incorrect suit"
+  );
+});
+
 //Incorrect card value to high
 test("Incorrect card number: High value", () => {
   assert.throws(
@@ -59,3 +68,21 @@ test("Incorrect card number: Letter", () => {
     "Incorrect card number given"
   );
 });
+
+//Incorrect card value when lower case Royal
+test("Incorrect card number: lower case Royal", () => {
+  assert.throws(
+    () => getCardValue("k♦"),
+    /Incorrect card number given/,
+    "Incorrect card number given"
+  );
+});
+
+//Incorrect card value when lower case Ace
+test("Incorrect card number: lower case Ace", () => {
+  assert.throws(
+    () => getCardValue("a♦"),
+    /Incorrect card number given/,
+    "Incorrect card number given"
+  );
+});

implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -26,13 +26,14 @@
 export function getCardValue(card) {
   // TODO: Implement this function
   if (card.length >= 4) {
-    throw new Error(`expected a number followed by a suit, but got "invalid"`);
+    throw new Error(`Expected a number followed by a suit, but got "invalid"`);
+  } else if (card === "") {
+    throw new Error("Input needed");
   }
 
   let suit = card.slice(-1);
   let cardNumber = card.slice(0, -1);
   let value = Number(cardNumber);
-
   if (!(suit === "♠" || suit === "♥" || suit === "♦" || suit === "♣")) {
     throw new Error("Incorrect suit given");
   } else if (cardNumber === "J" || cardNumber === "Q" || cardNumber === "K") {

implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -25,6 +25,7 @@ test(`Should return 10 when given a J, Q, K`, () => {
 });
 
 //   Invalid Cards
+
 test(`Should throw error 'expected a number followed by a suit, but got "invalid"' with invalid card`, () => {
   expect(() => getCardValue("120♥")).toThrow(
     new Error('expected a number followed by a suit, but got "invalid"')
@@ -41,6 +42,10 @@ test(`Should throw error "Incorrect suit given" when given wrong symbol"`, () =>
   expect(() => getCardValue("2☺")).toThrow(new Error("Incorrect suit given"));
 });
 
+test(`Should throw error "Incorrect suit given" when given wrong letter"`, () => {
+  expect(() => getCardValue("2K")).toThrow(new Error("Incorrect suit given"));
+});
+
 test(`Should throw error "Incorrect card number given" when given wrong 2 digit number"`, () => {
   expect(() => getCardValue("25♠")).toThrow(
     new Error("Incorrect card number given")
@@ -53,6 +58,18 @@ test(`Should throw error "Incorrect card number given" when given negative numbe
   );
 });
 
+test(`Should throw error "Incorrect card number given" when given a lower case Royal"`, () => {
+  expect(() => getCardValue("k♠")).toThrow(
+    new Error("Incorrect card number given")
+  );
+});
+
+test(`Should throw error "Incorrect card number given" when given a lower case Ace"`, () => {
+  expect(() => getCardValue("a♠")).toThrow(
+    new Error("Incorrect card number given")
+  );
+});
+
 test(`Should throw error "Incorrect card number given" when given a letter"`, () => {
   expect(() => getCardValue("I♠")).toThrow(
     new Error("Incorrect card number given")
@@ -64,3 +81,7 @@ test(`Should throw error "Incorrect card number given" when given symbol"`, () =
     new Error("Incorrect card number given")
   );
 });
+
+test(`Should throw error "Input needed" if no imput given`, () => {
+  expect(() => getCardValue("")).toThrow(new Error("Input needed"));
+});