Address PR review: expand edge and invalid test cases

Author: salahalsabhi

implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js

@@ -26,4 +26,15 @@ test("corrctly get angle type", function(){
     assert.equal(getAngleType(400), "Invalid angle");
 });
 
+test("corrctly get angle type", function(){
+    assert.equal(getAngleType(0), "Invalid angle");
+});
+
+test("corrctly get angle type", function(){
+    assert.equal(getAngleType(360), "Invalid angle");
+});
+
+test("corrctly get angle type", function(){
+    assert.equal(getAngleType(-70), "Invalid angle");
+});
 

implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js

@@ -30,7 +30,13 @@ test("Basic proper fraction", () => {
   assert.equal(isProperFraction(-1, 2), true);
 });
 
+test("Basic proper fraction", () => {
+  assert.equal(isProperFraction(1, -2), true);
+});
 
+test("Basic proper fraction", () => {
+  assert.equal(isProperFraction(-1, -2), true);
+});
 
 
 

implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js

@@ -37,3 +37,38 @@ test("Missing suit throws", () => {
 
 
 // TODO: What other invalid card cases can you think of?
+
+test("Empty string throws", () => {
+  assert.throws(
+    () => getCardValue(""),
+    /Expected a number followed by a suit/
+  );
+});
+
+test("Suit only throws", () => {
+  assert.throws(
+    () => getCardValue("♠"),
+    /Expected a number followed by a suit/
+  );
+});
+
+test("Invalid rank throws", () => {
+  assert.throws(
+    () => getCardValue("1♠"),
+    /Expected a number followed by a suit/
+  );
+});
+
+test("Invalid suit throws", () => {
+  assert.throws(
+    () => getCardValue("9X"),
+    /Expected a number followed by a suit/
+  );
+});
+
+test("Rank with no suit character throws", () => {
+  assert.throws(
+    () => getCardValue("10"),
+    /Expected a number followed by a suit/
+  );
+});

implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -11,6 +11,8 @@ test(`should return true for proper fractions`, () => {
   expect(isProperFraction(1, 2)).toEqual(true);
   expect(isProperFraction(0, 5)).toEqual(true);
   expect(isProperFraction(-1, 2)).toEqual(true);
+  expect(isProperFraction(1, -2)).toEqual(true);
+  expect(isProperFraction(-1, -2)).toEqual(true);
 });
 
 test(`should return false for improper fractions`, () => {

implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -18,6 +18,12 @@ test(`Should return 11 when given an ace card`, () => {
 
 test(`Should return numeric value for number cards`, () => {
   expect(getCardValue("2♥")).toEqual(2);
+  expect(getCardValue("3♠")).toEqual(3);
+  expect(getCardValue("4♣")).toEqual(4);
+  expect(getCardValue("5♥")).toEqual(5);
+  expect(getCardValue("6♦")).toEqual(6);
+  expect(getCardValue("7♠")).toEqual(7);
+  expect(getCardValue("8♣")).toEqual(8);
   expect(getCardValue("9♠")).toEqual(9);
   expect(getCardValue("10♦")).toEqual(10);
 });
@@ -28,11 +34,27 @@ test(`Should return 10 for face cards`, () => {
   expect(getCardValue("K♥")).toEqual(10);
 });
 
-test(`Should throw for invalid cards`, () => {
+// Invalid cards
+test(`should throw for invalid cards`, () => {
   expect(() => getCardValue("invalid")).toThrow(
     /Expected a number followed by a suit, but got "invalid"/
   );
   expect(() => getCardValue("A")).toThrow(
     /Expected a number followed by a suit/
   );
+  expect(() => getCardValue("")).toThrow(
+    /Expected a number followed by a suit/
+  );
+  expect(() => getCardValue("♠")).toThrow(
+    /Expected a number followed by a suit/
+  );
+  expect(() => getCardValue("1♠")).toThrow(
+    /Expected a number followed by a suit/
+  );
+  expect(() => getCardValue("9X")).toThrow(
+    /Expected a number followed by a suit/
+  );
+  expect(() => getCardValue("10")).toThrow(
+    /Expected a number followed by a suit/
+  );
 });