Skip to content

Conversation

@AhmadHmedann
Copy link

@AhmadHmedann AhmadHmedann commented Nov 30, 2025

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Complete all Sprint 2 tasks

Questions

I accidentally committed the median exercise to the Sprint 2 branch. What’s the best way to fix it?

@AhmadHmedann AhmadHmedann added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 30, 2025
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Groups/blob/general-review-feedback/Sprint-2/feedback.md

Doing so can help reviewers speed up the review process. Thanks.


This PR branch is being compared to CYF's main. So the files in CYF's main are considered the original version.

One way to undo (revert changes) is to replace the changed files you want to "undo" by their "original version".

You can download CYF's main as a ZIP file, unzip them to a temp folder, and then manually copy the files from this temp folder to your branch (to replace the files you want to undo).

After you have replaced all the files, make a commit and push your changes to GitHub.

Double check to ensure all unrelated files are replaced.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 30, 2025
@AhmadHmedann AhmadHmedann added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants