-
-
Notifications
You must be signed in to change notification settings - Fork 193
NW | 25-ITP-Sep | Ahmad Hmedan |Sprint 2 | Sprint 2 exercises #897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
NW | 25-ITP-Sep | Ahmad Hmedan |Sprint 2 | Sprint 2 exercises #897
Conversation
…n array,otherwise return null..........Filtered out non-numeric element .......Added a check for emty numeric arrays ....Cloned the array to prevent mutation(avoid side effects)......Sorted numbers in ascending order.......Calculated the median for both even and odd length
cjyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Groups/blob/general-review-feedback/Sprint-2/feedback.md
Doing so can help reviewers speed up the review process. Thanks.
This PR branch is being compared to CYF's main. So the files in CYF's main are considered the original version.
One way to undo (revert changes) is to replace the changed files you want to "undo" by their "original version".
You can download CYF's main as a ZIP file, unzip them to a temp folder, and then manually copy the files from this temp folder to your branch (to replace the files you want to undo).
After you have replaced all the files, make a commit and push your changes to GitHub.
Double check to ensure all unrelated files are replaced.
Learners, PR Template
Self checklist
Changelist
Complete all Sprint 2 tasks
Questions
I accidentally committed the median exercise to the Sprint 2 branch. What’s the best way to fix it?